archive mirror
 help / color / mirror / Atom feed
From: Paulo Alcantara <>
To: David Disseldorp <>
Subject: Re: [PATCH v2] cifs: fix regression when mounting shares with prefix paths
Date: Tue, 04 May 2021 13:47:52 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

David Disseldorp <> writes:

> On Mon,  3 May 2021 11:55:26 -0300, Paulo Alcantara wrote:
>> -	rc = cifs_setup_volume_info(cifs_sb->ctx, NULL, old_ctx->UNC);
>> +	rc = cifs_setup_volume_info(cifs_sb->ctx, NULL, NULL);
> IIUC, with the new behaviour, this call becomes pretty much an
> 	if (!cifs_sb->ctx->username)
> 		root = ERR_PTR(-EINVAL);

Yeah.  We should get rid of the damn thing at some point.  I've just
tried to keep the logic we currently have in fs/cifs/connect.c by
composing new options based upon the chased DFS referrals.

Thanks for pointing it out!

  reply	other threads:[~2021-05-04 16:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30 22:16 [PATCH] cifs: fix regression when mounting shares with prefix paths Paulo Alcantara
2021-04-30 23:40 ` David Disseldorp
2021-05-03 12:41   ` Paulo Alcantara
2021-05-03 14:55 ` [PATCH v2] " Paulo Alcantara
2021-05-03 23:20   ` David Disseldorp
2021-05-04 16:47     ` Paulo Alcantara [this message]
2021-05-04 16:58     ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).