* [PATCH v1] cifs: Add missing sentinel to smb3_fs_parameters
@ 2020-12-14 11:37 Dmitry Osipenko
2020-12-14 12:19 ` Aurélien Aptel
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Osipenko @ 2020-12-14 11:37 UTC (permalink / raw)
To: Steve French, Ronnie Sahlberg; +Cc: linux-cifs, linux-kernel
Add missing sentinel to smb3_fs_parameters. This fixes ARM32 kernel
crashing once CIFS is registered.
Unable to handle kernel paging request at virtual address 33626d73
...
(strcmp) from (fs_validate_description)
(fs_validate_description) from (register_filesystem)
(register_filesystem) from (init_cifs [cifs])
(init_cifs [cifs]) from (do_one_initcall)
(do_one_initcall) from (do_init_module)
(do_init_module) from (load_module)
(load_module) from (sys_finit_module)
(sys_finit_module) from (ret_fast_syscal)
Fixes: e07724d1cf38 ("cifs: switch to new mount api")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
fs/cifs/fs_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/cifs/fs_context.c b/fs/cifs/fs_context.c
index fe5cc60f4393..c41e87af77b6 100644
--- a/fs/cifs/fs_context.c
+++ b/fs/cifs/fs_context.c
@@ -173,6 +173,7 @@ const struct fs_parameter_spec smb3_fs_parameters[] = {
fsparam_flag_no("mand", Opt_ignore),
fsparam_string("cred", Opt_ignore),
fsparam_string("credentials", Opt_ignore),
+ {}
};
int
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] cifs: Add missing sentinel to smb3_fs_parameters
2020-12-14 11:37 [PATCH v1] cifs: Add missing sentinel to smb3_fs_parameters Dmitry Osipenko
@ 2020-12-14 12:19 ` Aurélien Aptel
0 siblings, 0 replies; 2+ messages in thread
From: Aurélien Aptel @ 2020-12-14 12:19 UTC (permalink / raw)
To: Dmitry Osipenko, Steve French, Ronnie Sahlberg; +Cc: linux-cifs, linux-kernel
Dmitry Osipenko <digetx@gmail.com> writes:
> Add missing sentinel to smb3_fs_parameters. This fixes ARM32 kernel
> crashing once CIFS is registered.
Thanks for the fix Dmitry.
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-14 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-14 11:37 [PATCH v1] cifs: Add missing sentinel to smb3_fs_parameters Dmitry Osipenko
2020-12-14 12:19 ` Aurélien Aptel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).