linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu>
@ 2021-05-09 23:33 wenhuizhang
  2021-05-11 16:32 ` Aurélien Aptel
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: wenhuizhang @ 2021-05-09 23:33 UTC (permalink / raw)
  Cc: wenhui, Steve French, linux-cifs, samba-technical, linux-kernel

Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group).

line 741 struct cifsInodeInfo *cinode;
line 747 cinode = CIFS_I(d_inode(cfile->dentry));
could be deleted.

Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu>

cinode on filesystem should not be deleted when files are closed, they are representations of some data fields on a physical disk, thus no further action is required.
The virtual inode on vfs will be handled by vfs automatically, and the denotation is inode, which is different from the cinode.
---
 fs/cifs/misc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
index 524dbdfb7184..801a5300f765 100644
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -738,13 +738,11 @@ void
 cifs_close_all_deferred_files(struct cifs_tcon *tcon)
 {
 	struct cifsFileInfo *cfile;
-	struct cifsInodeInfo *cinode;
 	struct list_head *tmp;
 
 	spin_lock(&tcon->open_file_lock);
 	list_for_each(tmp, &tcon->openFileList) {
 		cfile = list_entry(tmp, struct cifsFileInfo, tlist);
-		cinode = CIFS_I(d_inode(cfile->dentry));
 		if (delayed_work_pending(&cfile->deferred))
 			mod_delayed_work(deferredclose_wq, &cfile->deferred, 0);
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu>
  2021-05-09 23:33 [PATCH] Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu> wenhuizhang
@ 2021-05-11 16:32 ` Aurélien Aptel
       [not found]   ` <CAOSEQ1p80+JemJkj975ZTt5xw4XCPtOf2uBEvQs9RfW4UkDWXg@mail.gmail.com>
  2021-05-11 22:34 ` [PATCH] Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group) wenhuizhang
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 9+ messages in thread
From: Aurélien Aptel @ 2021-05-11 16:32 UTC (permalink / raw)
  To: wenhuizhang
  Cc: wenhui, Steve French, linux-cifs, samba-technical, linux-kernel

wenhuizhang <wenhui@gwmail.gwu.edu> writes:
> Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group).
>
> line 741 struct cifsInodeInfo *cinode;
> line 747 cinode = CIFS_I(d_inode(cfile->dentry));
> could be deleted.
>
> Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu>
>
> cinode on filesystem should not be deleted when files are closed, they are representations of some data fields on a physical disk, thus no further action is required.
> The virtual inode on vfs will be handled by vfs automatically, and the denotation is inode, which is different from the cinode.

This looks ok but the patch subject is wrong.
Also the signed-off tag should be the last thing in the commit msg.

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu>
       [not found]   ` <CAOSEQ1p80+JemJkj975ZTt5xw4XCPtOf2uBEvQs9RfW4UkDWXg@mail.gmail.com>
@ 2021-05-11 18:06     ` Aurélien Aptel
  0 siblings, 0 replies; 9+ messages in thread
From: Aurélien Aptel @ 2021-05-11 18:06 UTC (permalink / raw)
  To: Wenhui Zhang; +Cc: Steve French, linux-cifs, samba-technical, linux-kernel

Wenhui Zhang <wenhui@gwmail.gwu.edu> writes:
> In this case, should I send out another formatted patch push request?

Yes, fix the patch then you can generate a v2 and send it:

    git format-patch -1 -v 2
    git send-email --to=.... --in-reply-to=msgid the_fix.patch

where msgid is the Message-Id header of the email you want your v2 to be
a reply of. To reply to youself, your msg id is
20210509233327.22241-1-wenhui@gwmail.gwu.edu

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group)
  2021-05-09 23:33 [PATCH] Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu> wenhuizhang
  2021-05-11 16:32 ` Aurélien Aptel
@ 2021-05-11 22:34 ` wenhuizhang
  2021-05-12  9:38   ` Aurélien Aptel
  2021-05-13 16:53 ` [PATCH] cifs: deadstore delete in deferred files wenhuizhang
  2021-05-13 16:55 ` [PATCH] cifs: remove deadstore in cifs_close_all_deferred_files() wenhuizhang
  3 siblings, 1 reply; 9+ messages in thread
From: wenhuizhang @ 2021-05-11 22:34 UTC (permalink / raw)
  Cc: wenhuizhang, Steve French, linux-cifs, samba-technical, linux-kernel

Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group).

line 741 struct cifsInodeInfo *cinode;
line 747 cinode = CIFS_I(d_inode(cfile->dentry));
could be deleted.

cinode on filesystem should not be deleted when files are closed, they are representations of some data fields on a physical disk, thus no further action is required.
The virtual inode on vfs will be handled by vfs automatically, and the denotation is inode, which is different from the cinode.

Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu>

---
 fs/cifs/misc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
index 524dbdfb7184..801a5300f765 100644
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -738,13 +738,11 @@ void
 cifs_close_all_deferred_files(struct cifs_tcon *tcon)
 {
 	struct cifsFileInfo *cfile;
-	struct cifsInodeInfo *cinode;
 	struct list_head *tmp;
 
 	spin_lock(&tcon->open_file_lock);
 	list_for_each(tmp, &tcon->openFileList) {
 		cfile = list_entry(tmp, struct cifsFileInfo, tlist);
-		cinode = CIFS_I(d_inode(cfile->dentry));
 		if (delayed_work_pending(&cfile->deferred))
 			mod_delayed_work(deferredclose_wq, &cfile->deferred, 0);
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group)
  2021-05-11 22:34 ` [PATCH] Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group) wenhuizhang
@ 2021-05-12  9:38   ` Aurélien Aptel
  0 siblings, 0 replies; 9+ messages in thread
From: Aurélien Aptel @ 2021-05-12  9:38 UTC (permalink / raw)
  To: wenhuizhang
  Cc: wenhuizhang, Steve French, linux-cifs, samba-technical, linux-kernel

wenhuizhang <wenhui@gwmail.gwu.edu> writes:
> Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group).
>
> line 741 struct cifsInodeInfo *cinode;
> line 747 cinode = CIFS_I(d_inode(cfile->dentry));
> could be deleted.
>
> cinode on filesystem should not be deleted when files are closed, they are representations of some data fields on a physical disk, thus no further action is required.
> The virtual inode on vfs will be handled by vfs automatically, and the denotation is inode, which is different from the cinode.
>
> Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu>

That's better but:
* the subject (first line of commit msg) should be about what the patch
  actually does, usally with a prefix of the subsystem. So for example:
  cifs: remove deadstore in cifs_close_all_deferred_files()
* the body of the commit msg should be wrapped around 80 cols to avoid
  long lines unless you are quoting some output or urls

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] cifs: deadstore delete in deferred files
  2021-05-09 23:33 [PATCH] Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu> wenhuizhang
  2021-05-11 16:32 ` Aurélien Aptel
  2021-05-11 22:34 ` [PATCH] Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group) wenhuizhang
@ 2021-05-13 16:53 ` wenhuizhang
  2021-05-13 16:55 ` [PATCH] cifs: remove deadstore in cifs_close_all_deferred_files() wenhuizhang
  3 siblings, 0 replies; 9+ messages in thread
From: wenhuizhang @ 2021-05-13 16:53 UTC (permalink / raw)
  Cc: wenhuizhang, Steve French, linux-cifs, samba-technical, linux-kernel

Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group).

line 741 struct cifsInodeInfo *cinode;
line 747 cinode = CIFS_I(d_inode(cfile->dentry));
could be deleted.

cinode on filesystem should not be deleted when files are closed, they are representations of some data fields on a physical disk, thus no further action is required.
The virtual inode on vfs will be handled by vfs automatically, and the denotation is inode, which is different from the cinode.

Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu>

---
 fs/cifs/misc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
index 524dbdfb7184..801a5300f765 100644
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -738,13 +738,11 @@ void
 cifs_close_all_deferred_files(struct cifs_tcon *tcon)
 {
 	struct cifsFileInfo *cfile;
-	struct cifsInodeInfo *cinode;
 	struct list_head *tmp;
 
 	spin_lock(&tcon->open_file_lock);
 	list_for_each(tmp, &tcon->openFileList) {
 		cfile = list_entry(tmp, struct cifsFileInfo, tlist);
-		cinode = CIFS_I(d_inode(cfile->dentry));
 		if (delayed_work_pending(&cfile->deferred))
 			mod_delayed_work(deferredclose_wq, &cfile->deferred, 0);
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] cifs: remove deadstore in cifs_close_all_deferred_files()
  2021-05-09 23:33 [PATCH] Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu> wenhuizhang
                   ` (2 preceding siblings ...)
  2021-05-13 16:53 ` [PATCH] cifs: deadstore delete in deferred files wenhuizhang
@ 2021-05-13 16:55 ` wenhuizhang
  2021-05-14 10:59   ` Aurélien Aptel
  3 siblings, 1 reply; 9+ messages in thread
From: wenhuizhang @ 2021-05-13 16:55 UTC (permalink / raw)
  Cc: wenhuizhang, Steve French, linux-cifs, samba-technical, linux-kernel

Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group).

line 741 struct cifsInodeInfo *cinode;
line 747 cinode = CIFS_I(d_inode(cfile->dentry));
could be deleted.

cinode on filesystem should not be deleted when files are closed, 
they are representations of some data fields on a physical disk, 
thus no further action is required.
The virtual inode on vfs will be handled by vfs automatically, 
and the denotation is inode, which is different from the cinode.

Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu>

---
 fs/cifs/misc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
index 524dbdfb7184..801a5300f765 100644
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -738,13 +738,11 @@ void
 cifs_close_all_deferred_files(struct cifs_tcon *tcon)
 {
 	struct cifsFileInfo *cfile;
-	struct cifsInodeInfo *cinode;
 	struct list_head *tmp;
 
 	spin_lock(&tcon->open_file_lock);
 	list_for_each(tmp, &tcon->openFileList) {
 		cfile = list_entry(tmp, struct cifsFileInfo, tlist);
-		cinode = CIFS_I(d_inode(cfile->dentry));
 		if (delayed_work_pending(&cfile->deferred))
 			mod_delayed_work(deferredclose_wq, &cfile->deferred, 0);
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] cifs: remove deadstore in cifs_close_all_deferred_files()
  2021-05-13 16:55 ` [PATCH] cifs: remove deadstore in cifs_close_all_deferred_files() wenhuizhang
@ 2021-05-14 10:59   ` Aurélien Aptel
  2021-05-14 16:01     ` Steve French
  0 siblings, 1 reply; 9+ messages in thread
From: Aurélien Aptel @ 2021-05-14 10:59 UTC (permalink / raw)
  To: wenhuizhang
  Cc: wenhuizhang, Steve French, linux-cifs, samba-technical, linux-kernel


Reviewed-by: Aurelien Aptel <aaptel@suse.com>

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] cifs: remove deadstore in cifs_close_all_deferred_files()
  2021-05-14 10:59   ` Aurélien Aptel
@ 2021-05-14 16:01     ` Steve French
  0 siblings, 0 replies; 9+ messages in thread
From: Steve French @ 2021-05-14 16:01 UTC (permalink / raw)
  To: Aurélien Aptel
  Cc: wenhuizhang, Steve French, samba-technical, LKML, CIFS

merged into cifs-2.6.git for-next

On Fri, May 14, 2021 at 6:01 AM Aurélien Aptel via samba-technical
<samba-technical@lists.samba.org> wrote:
>
>
> Reviewed-by: Aurelien Aptel <aaptel@suse.com>
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
>
>


-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-05-14 16:02 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-09 23:33 [PATCH] Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu> wenhuizhang
2021-05-11 16:32 ` Aurélien Aptel
     [not found]   ` <CAOSEQ1p80+JemJkj975ZTt5xw4XCPtOf2uBEvQs9RfW4UkDWXg@mail.gmail.com>
2021-05-11 18:06     ` Aurélien Aptel
2021-05-11 22:34 ` [PATCH] Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group) wenhuizhang
2021-05-12  9:38   ` Aurélien Aptel
2021-05-13 16:53 ` [PATCH] cifs: deadstore delete in deferred files wenhuizhang
2021-05-13 16:55 ` [PATCH] cifs: remove deadstore in cifs_close_all_deferred_files() wenhuizhang
2021-05-14 10:59   ` Aurélien Aptel
2021-05-14 16:01     ` Steve French

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).