linux-next: build warning after merge of the cifs tree

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/cifs/file.c: In function 'cifs_iovec_write':
fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type
fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *'

Introduced by commit 72432ffcf555decbbae47f1be338e1d2f210aa69 ("CIFS:
Implement cifs_strict_writev (try #4)").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the cifs tree

[Suresh Jayaraman]

On 01/31/2011 08:00 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/cifs/file.c: In function 'cifs_iovec_write':
> fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type
> fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *'
> 
> Introduced by commit 72432ffcf555decbbae47f1be338e1d2f210aa69 ("CIFS:
> Implement cifs_strict_writev (try #4)").
> 

The following patch should silence that warning.

From: Suresh Jayaraman <sjayaraman@suse.de>
Subject: [PATCH] cifs: fix compiler warning about incompatible pointer type

fs/cifs/file.c: In function ‘cifs_iovec_write’:
fs/cifs/file.c:1740:9: warning: passing argument 6 of ‘CIFSSMBWrite2’ from incompatible pointer type
fs/cifs/cifsproto.h:343:12: note: expected ‘unsigned int *’ but argument is of type ‘size_t *’

Cc: Pavel Shilovsky <piastryyy@gmail.com>
Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de>
---
 fs/cifs/file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 0de17c1..2a3c5d8 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -1667,7 +1667,7 @@ static ssize_t
 cifs_iovec_write(struct file *file, const struct iovec *iov,
 		 unsigned long nr_segs, loff_t *poffset)
 {
-	size_t total_written = 0, written = 0;
+	unsigned int total_written = 0, written = 0;
 	unsigned long num_pages, npages;
 	size_t copied, len, cur_len, i;
 	struct kvec *to_send;

Re: linux-next: build warning after merge of the cifs tree

[Pavel Shilovsky]

2011/1/31 Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>:
> On 01/31/2011 08:00 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the cifs tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> fs/cifs/file.c: In function 'cifs_iovec_write':
>> fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type
>> fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *'
>>
>> Introduced by commit 72432ffcf555decbbae47f1be338e1d2f210aa69 ("CIFS:
>> Implement cifs_strict_writev (try #4)").
>>
>
> The following patch should silence that warning.
>
> From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> Subject: [PATCH] cifs: fix compiler warning about incompatible pointer type
>
> fs/cifs/file.c: In function ‘cifs_iovec_write’:
> fs/cifs/file.c:1740:9: warning: passing argument 6 of ‘CIFSSMBWrite2’ from incompatible pointer type
> fs/cifs/cifsproto.h:343:12: note: expected ‘unsigned int *’ but argument is of type ‘size_t *’
>
> Cc: Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> ---
>  fs/cifs/file.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 0de17c1..2a3c5d8 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -1667,7 +1667,7 @@ static ssize_t
>  cifs_iovec_write(struct file *file, const struct iovec *iov,
>                 unsigned long nr_segs, loff_t *poffset)
>  {
> -       size_t total_written = 0, written = 0;
> +       unsigned int total_written = 0, written = 0;
>        unsigned long num_pages, npages;
>        size_t copied, len, cur_len, i;
>        struct kvec *to_send;
>

I've just noriced another bug: that 'i' variable should be unsigned
long. I will recreate the patch with this fix.

-- 
Best regards,
Pavel Shilovsky.

[PATCH] cifs: fix compiler warning about incompatible pointer type (try #2)

[Pavel Shilovsky]

fs/cifs/file.c: In function ‘cifs_iovec_write’:
fs/cifs/file.c:1740:9: warning: passing argument 6 of ‘CIFSSMBWrite2’ from incompatible pointer type
fs/cifs/cifsproto.h:343:12: note: expected ‘unsigned int *’ but argument is of type ‘size_t *’

Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
Signed-off-by: Pavel Shilovsky <piastry-7qunaywFIewox3rIn2DAYQ@public.gmane.org>
---
 fs/cifs/file.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 0de17c1..4940bac 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -1667,9 +1667,9 @@ static ssize_t
 cifs_iovec_write(struct file *file, const struct iovec *iov,
 		 unsigned long nr_segs, loff_t *poffset)
 {
-	size_t total_written = 0, written = 0;
-	unsigned long num_pages, npages;
-	size_t copied, len, cur_len, i;
+	unsigned int written = 0;
+	unsigned long num_pages, npages, i;
+	size_t copied, len, cur_len, total_written = 0;
 	struct kvec *to_send;
 	struct page **pages;
 	struct iov_iter it;
-- 
1.7.1

[PATCH] cifs: fix compiler warning about incompatible pointer type (try #3)

[Pavel Shilovsky]

fs/cifs/file.c: In function ‘cifs_iovec_write’:
fs/cifs/file.c:1740:9: warning: passing argument 6 of ‘CIFSSMBWrite2’ from incompatible pointer type
fs/cifs/cifsproto.h:343:12: note: expected ‘unsigned int *’ but argument is of type ‘size_t *’

Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
Signed-off-by: Pavel Shilovsky <piastry-7qunaywFIewox3rIn2DAYQ@public.gmane.org>
---
 fs/cifs/file.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 0de17c1..d8338e7 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -1667,9 +1667,10 @@ static ssize_t
 cifs_iovec_write(struct file *file, const struct iovec *iov,
 		 unsigned long nr_segs, loff_t *poffset)
 {
-	size_t total_written = 0, written = 0;
-	unsigned long num_pages, npages;
-	size_t copied, len, cur_len, i;
+	unsigned int written;
+	ssize_t total_written = 0;
+	unsigned long num_pages, npages, i;
+	size_t copied, len, cur_len;
 	struct kvec *to_send;
 	struct page **pages;
 	struct iov_iter it;
@@ -1825,7 +1826,8 @@ cifs_iovec_read(struct file *file, const struct iovec *iov,
 {
 	int rc;
 	int xid;
-	unsigned int total_read, bytes_read = 0;
+	ssize_t total_read;
+	unsigned int bytes_read = 0;
 	size_t len, cur_len;
 	int iov_offset = 0;
 	struct cifs_sb_info *cifs_sb;
-- 
1.7.1

Re: [PATCH] cifs: fix compiler warning about incompatible pointer type (try #3)

[Pavel Shilovsky]

2011/1/31 Pavel Shilovsky <piastry@etersoft.ru>:
> fs/cifs/file.c: In function ‘cifs_iovec_write’:
> fs/cifs/file.c:1740:9: warning: passing argument 6 of ‘CIFSSMBWrite2’ from incompatible pointer type
> fs/cifs/cifsproto.h:343:12: note: expected ‘unsigned int *’ but argument is of type ‘size_t *’
>
> Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de>
> Signed-off-by: Pavel Shilovsky <piastry@etersoft.ru>
> ---
>  fs/cifs/file.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 0de17c1..d8338e7 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -1667,9 +1667,10 @@ static ssize_t
>  cifs_iovec_write(struct file *file, const struct iovec *iov,
>                 unsigned long nr_segs, loff_t *poffset)
>  {
> -       size_t total_written = 0, written = 0;
> -       unsigned long num_pages, npages;
> -       size_t copied, len, cur_len, i;
> +       unsigned int written;
> +       ssize_t total_written = 0;
> +       unsigned long num_pages, npages, i;
> +       size_t copied, len, cur_len;
>        struct kvec *to_send;
>        struct page **pages;
>        struct iov_iter it;
> @@ -1825,7 +1826,8 @@ cifs_iovec_read(struct file *file, const struct iovec *iov,
>  {
>        int rc;
>        int xid;
> -       unsigned int total_read, bytes_read = 0;
> +       ssize_t total_read;
> +       unsigned int bytes_read = 0;
>        size_t len, cur_len;
>        int iov_offset = 0;
>        struct cifs_sb_info *cifs_sb;
> --
> 1.7.1
>
>

Let's drop this one according to [PATCH] cifs: clean up some compiler
warnings patch.

-- 
Best regards,
Pavel Shilovsky.

Re: linux-next: build warning after merge of the cifs tree

[Jeff Layton]

On Mon, 31 Jan 2011 16:19:51 +0530
Suresh Jayaraman <sjayaraman@suse.de> wrote:

> On 01/31/2011 08:00 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the cifs tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > fs/cifs/file.c: In function 'cifs_iovec_write':
> > fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type
> > fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *'
> > 
> > Introduced by commit 72432ffcf555decbbae47f1be338e1d2f210aa69 ("CIFS:
> > Implement cifs_strict_writev (try #4)").
> > 
> 
> The following patch should silence that warning.
> 
> From: Suresh Jayaraman <sjayaraman@suse.de>
> Subject: [PATCH] cifs: fix compiler warning about incompatible pointer type
> 
> fs/cifs/file.c: In function ‘cifs_iovec_write’:
> fs/cifs/file.c:1740:9: warning: passing argument 6 of ‘CIFSSMBWrite2’ from incompatible pointer type
> fs/cifs/cifsproto.h:343:12: note: expected ‘unsigned int *’ but argument is of type ‘size_t *’
> 
> Cc: Pavel Shilovsky <piastryyy@gmail.com>
> Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de>
> ---
>  fs/cifs/file.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 0de17c1..2a3c5d8 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -1667,7 +1667,7 @@ static ssize_t
>  cifs_iovec_write(struct file *file, const struct iovec *iov,
>  		 unsigned long nr_segs, loff_t *poffset)
>  {
> -	size_t total_written = 0, written = 0;
> +	unsigned int total_written = 0, written = 0;
>  	unsigned long num_pages, npages;
>  	size_t copied, len, cur_len, i;
>  	struct kvec *to_send;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

I fixed this a few days ago along with a number of other compiler
warnings in:

    [PATCH] cifs: clean up some compiler warnings

...just waiting for Steve to merge it.

-- 
Jeff Layton <jlayton@redhat.com>

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/admin-guide/cifs/todo.rst:7: WARNING: Definition list ends without a blank line; unexpected unindent.
Documentation/admin-guide/cifs/todo.rst:20: ERROR: Unexpected indentation.
Documentation/admin-guide/cifs/todo.rst:21: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

  e7dccb219fde ("smb3: minor documentation updates")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the cifs tree

[Steve French]

fixed

On Thu, Jan 18, 2024 at 7:47 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (htmldocs) produced
> this warning:
>
> Documentation/admin-guide/cifs/todo.rst:7: WARNING: Definition list ends without a blank line; unexpected unindent.
> Documentation/admin-guide/cifs/todo.rst:20: ERROR: Unexpected indentation.
> Documentation/admin-guide/cifs/todo.rst:21: WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Introduced by commit
>
>   e7dccb219fde ("smb3: minor documentation updates")
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/cifs/connect.c: In function 'is_path_remote':
fs/cifs/connect.c:3436:14: warning: unused variable 'nodfs' [-Wunused-variable]
 3436 |         bool nodfs = cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_DFS;
      |              ^~~~~

Introduced by commit

  421ef3d56513 ("cifs: don't call cifs_dfs_query_info_nonascii_quirk() if nodfs was set")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the cifs tree

[Steve French]

Added trivial patch to cifs-2.6.git for-next to fix the warning

On Sun, May 22, 2022 at 7:57 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/cifs/connect.c: In function 'is_path_remote':
> fs/cifs/connect.c:3436:14: warning: unused variable 'nodfs' [-Wunused-variable]
>  3436 |         bool nodfs = cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_DFS;
>       |              ^~~~~
>
> Introduced by commit
>
>   421ef3d56513 ("cifs: don't call cifs_dfs_query_info_nonascii_quirk() if nodfs was set")
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/cifs/file.c:4290:13: warning: 'cifs_is_cache_enabled' defined but not used [-Wunused-function]
 4290 | static bool cifs_is_cache_enabled(struct inode *inode)
      |             ^~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  6941febc7309 ("cifs: add new helper function for fscache conversion")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/cifs/smb2ops.c: In function 'open_shroot':
fs/cifs/smb2ops.c:762:28: warning: passing argument 5 of 'smb2_parse_contexts' makes pointer from integer without a cast [-Wint-conversion]
     oparms.fid->lease_key, oplock, NULL);
                            ^~~~~~
In file included from fs/cifs/smb2ops.c:16:
fs/cifs/smb2proto.h:234:11: note: expected '__u8 *' {aka 'unsigned char *'} but argument is of type 'u8' {aka 'unsigned char'}
     __u8 *oplock, struct smb2_file_all_info *buf);
     ~~~~~~^~~~~~

Introduced by commit

  bf63aef07199 ("smb3: optimize open to not send query file internal info")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the cifs tree

[Steve French]

This typo has been fixed (earlier this afternoon) in cifs-2.6.git for-next

On Thu, Jul 18, 2019 at 6:16 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> fs/cifs/smb2ops.c: In function 'open_shroot':
> fs/cifs/smb2ops.c:762:28: warning: passing argument 5 of 'smb2_parse_contexts' makes pointer from integer without a cast [-Wint-conversion]
>      oparms.fid->lease_key, oplock, NULL);
>                             ^~~~~~
> In file included from fs/cifs/smb2ops.c:16:
> fs/cifs/smb2proto.h:234:11: note: expected '__u8 *' {aka 'unsigned char *'} but argument is of type 'u8' {aka 'unsigned char'}
>      __u8 *oplock, struct smb2_file_all_info *buf);
>      ~~~~~~^~~~~~
>
> Introduced by commit
>
>   bf63aef07199 ("smb3: optimize open to not send query file internal info")
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

Hi all,

After merging the cifs tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/seqlock.h:36:0,
                 from include/linux/time.h:6,
                 from include/linux/stat.h:19,
                 from include/linux/module.h:10,
                 from fs/cifs/smbdirect.c:16:
fs/cifs/smbdirect.c: In function 'smbd_recv_buf':
include/linux/spinlock.h:260:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
   _raw_spin_unlock_irqrestore(lock, flags); \
   ^
fs/cifs/smbdirect.c:1865:16: note: 'flags' was declared here
  unsigned long flags;
                ^

Introduced by commit

  ac69f66e54ca ("CIFS: SMBD: Implement function to receive data via RDMA receive")

OK, this is a false positive, but annoying.

I am using gcc 5.2.0.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the cifs tree

[Steve French]

I don't see this with gcc 5.4

Stephen,
Harmless to initialize flags here ... even if unneeded ... so if it
makes your life easier I don't mind initializes to 0.  Let me know.
Wonder why it doesn't generate the warning on the various other places
in the fs that do the same thing?

On Wed, Jan 3, 2018 at 4:33 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from include/linux/seqlock.h:36:0,
>                  from include/linux/time.h:6,
>                  from include/linux/stat.h:19,
>                  from include/linux/module.h:10,
>                  from fs/cifs/smbdirect.c:16:
> fs/cifs/smbdirect.c: In function 'smbd_recv_buf':
> include/linux/spinlock.h:260:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    _raw_spin_unlock_irqrestore(lock, flags); \
>    ^
> fs/cifs/smbdirect.c:1865:16: note: 'flags' was declared here
>   unsigned long flags;
>                 ^
>
> Introduced by commit
>
>   ac69f66e54ca ("CIFS: SMBD: Implement function to receive data via RDMA receive")
>
> OK, this is a false positive, but annoying.
>
> I am using gcc 5.2.0.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

Re: linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

Hi Steve,

On Wed, 3 Jan 2018 16:44:59 -0600 Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> I don't see this with gcc 5.4

Good to know.

> Harmless to initialize flags here ... even if unneeded ... so if it
> makes your life easier I don't mind initializes to 0.  Let me know.
> Wonder why it doesn't generate the warning on the various other places
> in the fs that do the same thing?

I might just take the hint to upgrade my cross compilers :-)  Thanks anyway.

In the mean time, my scripts will automatically skip reporting this
warning to me.
-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/cifs/smb2pdu.c: In function 'SMB2_read':
fs/cifs/smb2pdu.c:2677:18: warning: unused variable 'rqst' [-Wunused-variable]
  struct smb_rqst rqst = { .rq_iov = iov,
                  ^

Introduced by commit

  889143494e16 ("cifs: remove rfc1002 header from smb2 read/write requests")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the cifs tree

[Steve French]

fix for this warning merged into cifs-2.6.git for-next

On Mon, Nov 20, 2017 at 5:19 PM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/cifs/smb2pdu.c: In function 'SMB2_read':
> fs/cifs/smb2pdu.c:2677:18: warning: unused variable 'rqst' [-Wunused-variable]
>   struct smb_rqst rqst = { .rq_iov = iov,
>                   ^
>
> Introduced by commit
>
>   889143494e16 ("cifs: remove rfc1002 header from smb2 read/write requests")
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

Hi all,

After merging the cifs tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/kernel.h:13:0,
                 from include/linux/list.h:8,
                 from include/linux/wait.h:6,
                 from include/linux/fs.h:5,
                 from fs/cifs/smb2transport.c:25:
fs/cifs/smb2transport.c: In function 'generate_smb3signingkey':
fs/cifs/cifs_debug.h:55:24: warning: field width specifier '*' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
   pr_debug_ratelimited("%s: "    \
                        ^
include/linux/printk.h:285:21: note: in definition of macro 'pr_fmt'
 #define pr_fmt(fmt) fmt
                     ^
fs/cifs/cifs_debug.h:55:3: note: in expansion of macro 'pr_debug_ratelimited'
   pr_debug_ratelimited("%s: "    \
   ^
fs/cifs/smb2transport.c:352:2: note: in expansion of macro 'cifs_dbg'
  cifs_dbg(VFS, "Session Id    %*ph\n", sizeof(ses->Suid), &ses->Suid);
  ^
In file included from fs/cifs/smb2transport.c:39:0:
fs/cifs/smb2transport.c:352:16: warning: field width specifier '*' expects argument of type 'int', but argument 2 has type 'long unsigned int' [-Wformat=]
  cifs_dbg(VFS, "Session Id    %*ph\n", sizeof(ses->Suid), &ses->Suid);
                ^
fs/cifs/cifs_debug.h:58:16: note: in definition of macro 'cifs_dbg'
   cifs_vfs_err(fmt, ##__VA_ARGS__);   \
                ^
In file included from include/linux/kernel.h:13:0,
                 from include/linux/list.h:8,
                 from include/linux/wait.h:6,
                 from include/linux/fs.h:5,
                 from fs/cifs/smb2transport.c:25:
fs/cifs/smb2transport.c:352:16: warning: field width specifier '*' expects argument of type 'int', but argument 3 has type 'long unsigned int' [-Wformat=]
  cifs_dbg(VFS, "Session Id    %*ph\n", sizeof(ses->Suid), &ses->Suid);
                ^
include/linux/printk.h:285:21: note: in definition of macro 'pr_fmt'
 #define pr_fmt(fmt) fmt
                     ^
fs/cifs/cifs_debug.h:60:3: note: in expansion of macro 'pr_debug_ratelimited'
   pr_debug_ratelimited(fmt, ##__VA_ARGS__);  \
   ^
fs/cifs/smb2transport.c:352:2: note: in expansion of macro 'cifs_dbg'
  cifs_dbg(VFS, "Session Id    %*ph\n", sizeof(ses->Suid), &ses->Suid);
  ^

Introduced by commit

  ba4f2a8b205f ("CIFS: add CONFIG_CIFS_DEBUG_KEYS to dump encryption keys")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the cifs tree

[Steve French]

I just merged an updated version of this patch to remove the warning
to cifs-2.6.git for-next

On Sun, Jun 25, 2017 at 7:07 PM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from include/linux/kernel.h:13:0,
>                  from include/linux/list.h:8,
>                  from include/linux/wait.h:6,
>                  from include/linux/fs.h:5,
>                  from fs/cifs/smb2transport.c:25:
> fs/cifs/smb2transport.c: In function 'generate_smb3signingkey':
> fs/cifs/cifs_debug.h:55:24: warning: field width specifier '*' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
>    pr_debug_ratelimited("%s: "    \
>                         ^
> include/linux/printk.h:285:21: note: in definition of macro 'pr_fmt'
>  #define pr_fmt(fmt) fmt
>                      ^
> fs/cifs/cifs_debug.h:55:3: note: in expansion of macro 'pr_debug_ratelimited'
>    pr_debug_ratelimited("%s: "    \
>    ^
> fs/cifs/smb2transport.c:352:2: note: in expansion of macro 'cifs_dbg'
>   cifs_dbg(VFS, "Session Id    %*ph\n", sizeof(ses->Suid), &ses->Suid);
>   ^
> In file included from fs/cifs/smb2transport.c:39:0:
> fs/cifs/smb2transport.c:352:16: warning: field width specifier '*' expects argument of type 'int', but argument 2 has type 'long unsigned int' [-Wformat=]
>   cifs_dbg(VFS, "Session Id    %*ph\n", sizeof(ses->Suid), &ses->Suid);
>                 ^
> fs/cifs/cifs_debug.h:58:16: note: in definition of macro 'cifs_dbg'
>    cifs_vfs_err(fmt, ##__VA_ARGS__);   \
>                 ^
> In file included from include/linux/kernel.h:13:0,
>                  from include/linux/list.h:8,
>                  from include/linux/wait.h:6,
>                  from include/linux/fs.h:5,
>                  from fs/cifs/smb2transport.c:25:
> fs/cifs/smb2transport.c:352:16: warning: field width specifier '*' expects argument of type 'int', but argument 3 has type 'long unsigned int' [-Wformat=]
>   cifs_dbg(VFS, "Session Id    %*ph\n", sizeof(ses->Suid), &ses->Suid);
>                 ^
> include/linux/printk.h:285:21: note: in definition of macro 'pr_fmt'
>  #define pr_fmt(fmt) fmt
>                      ^
> fs/cifs/cifs_debug.h:60:3: note: in expansion of macro 'pr_debug_ratelimited'
>    pr_debug_ratelimited(fmt, ##__VA_ARGS__);  \
>    ^
> fs/cifs/smb2transport.c:352:2: note: in expansion of macro 'cifs_dbg'
>   cifs_dbg(VFS, "Session Id    %*ph\n", sizeof(ses->Suid), &ses->Suid);
>   ^
>
> Introduced by commit
>
>   ba4f2a8b205f ("CIFS: add CONFIG_CIFS_DEBUG_KEYS to dump encryption keys")
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/cifs/link.c: In function 'symlink_hash':
fs/cifs/link.c:58: warning: 'rc' may be used uninitialized in this function

and, indeed, it may be ...

Introduced by commit ee2c9258501f83d3ed0fd09ce5df1cec53312cf0 ("cifs:
More crypto cleanup (try #2)").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the cifs tree

[Steve French]

Noticed this Friday but had a pending merge request (upstream) in so
was holding off.  I now have merged the fix for this crypto cleanup
warning.

On Sun, Jan 30, 2011 at 8:27 PM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/cifs/link.c: In function 'symlink_hash':
> fs/cifs/link.c:58: warning: 'rc' may be used uninitialized in this function
>
> and, indeed, it may be ...
>
> Introduced by commit ee2c9258501f83d3ed0fd09ce5df1cec53312cf0 ("cifs:
> More crypto cleanup (try #2)").
> --
> Cheers,
> Stephen Rothwell                    sfr-3FnU+UHB4dPYtjvyW6yDsg@public.gmane.org.org.au
> http://www.canb.auug.org.au/~sfr/
>



-- 
Thanks,

Steve

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/cifs/smbencrypt.c: In function 'mdfour':
fs/cifs/smbencrypt.c:61: warning: 'rc' may be used uninitialized in this function

and, indeed, it may be ...

Introduced by commit ee2c9258501f83d3ed0fd09ce5df1cec53312cf0 ("cifs:
More crypto cleanup (try #2)").

-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/cifs/cifssmb.c: In function 'CIFSSMBEcho':
fs/cifs/cifssmb.c:740: warning: large integer implicitly truncated to unsigned type

Introduced by commit 766fdbb57fdb1e53bc34c431103e95383d7f13ba ("cifs: add
ability to send an echo request").

-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the cifs tree

[Jeff Layton]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

On Fri, 21 Jan 2011 12:05:24 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/cifs/cifssmb.c: In function 'CIFSSMBEcho':
> fs/cifs/cifssmb.c:740: warning: large integer implicitly truncated to unsigned type
> 
> Introduced by commit 766fdbb57fdb1e53bc34c431103e95383d7f13ba ("cifs: add
> ability to send an echo request").
> 

Oh duh -- <forehead slap>...

        smb->hdr.WordCount = cpu_to_le16(1);

...and WordCount is u8. I'll send Steve a fix tomorrow...

-- 
Jeff Layton <jlayton@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi all,

After merging the irqflags tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/cifs/sess.c: In function 'CIFS_SessSetup':
fs/cifs/sess.c:595: warning: unused variable 'blob_len'

Introduced by commit 15f6bdfb9914b0c41848f874719911ba053be931 ("cifs
NTLMv2/NTLMSSP ntlmv2 within ntlmssp autentication code").
CONFIG_CIFS_UPCALL is not set in this build.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

Hi Steve,

On Fri, 24 Sep 2010 13:55:31 +1000 Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
>
> After merging the irqflags tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/cifs/sess.c: In function 'CIFS_SessSetup':
> fs/cifs/sess.c:595: warning: unused variable 'blob_len'
> 
> Introduced by commit 15f6bdfb9914b0c41848f874719911ba053be931 ("cifs
> NTLMv2/NTLMSSP ntlmv2 within ntlmssp autentication code").
> CONFIG_CIFS_UPCALL is not set in this build.

I am still getting this ...

-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the cifs tree

[Jeff Layton]

On Tue, 19 Oct 2010 16:21:20 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Steve,
> 
> On Fri, 24 Sep 2010 13:55:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the irqflags tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > fs/cifs/sess.c: In function 'CIFS_SessSetup':
> > fs/cifs/sess.c:595: warning: unused variable 'blob_len'
> > 
> > Introduced by commit 15f6bdfb9914b0c41848f874719911ba053be931 ("cifs
> > NTLMv2/NTLMSSP ntlmv2 within ntlmssp autentication code").
> > CONFIG_CIFS_UPCALL is not set in this build.
> 
> I am still getting this ...
> 

Yep. Looks clearly broken. blob_len is also declared twice in that
function which is just plain wrong. What probably makes the most sense
is to make it a u16 and get rid of the second declaration lower in the
function. But, there's another semi-related problem here too...

blob_len gets assigned the return value of build_ntlmssp_auth_blob.
That function however doesn't have any mechanism to pass back an
error, even though it calls setup_ntlmv2_rsp and that function can
return one.

The whole house of cards needs a bit of rework I think...

Shirish, since you're already doing work in this area, can you fix that
too?

Thanks,
-- 
Jeff Layton <jlayton@samba.org>

Re: linux-next: build warning after merge of the cifs tree

[Shirish Pargaonkar]

On Tue, Oct 19, 2010 at 8:13 AM, Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:
> On Tue, 19 Oct 2010 16:21:20 +1100
> Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
>
>> Hi Steve,
>>
>> On Fri, 24 Sep 2010 13:55:31 +1000 Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
>> >
>> > After merging the irqflags tree, today's linux-next build (powerpc
>> > ppc64_defconfig) produced this warning:
>> >
>> > fs/cifs/sess.c: In function 'CIFS_SessSetup':
>> > fs/cifs/sess.c:595: warning: unused variable 'blob_len'
>> >
>> > Introduced by commit 15f6bdfb9914b0c41848f874719911ba053be931 ("cifs
>> > NTLMv2/NTLMSSP ntlmv2 within ntlmssp autentication code").
>> > CONFIG_CIFS_UPCALL is not set in this build.
>>
>> I am still getting this ...
>>
>
> Yep. Looks clearly broken. blob_len is also declared twice in that
> function which is just plain wrong. What probably makes the most sense
> is to make it a u16 and get rid of the second declaration lower in the
> function. But, there's another semi-related problem here too...
>
> blob_len gets assigned the return value of build_ntlmssp_auth_blob.
> That function however doesn't have any mechanism to pass back an
> error, even though it calls setup_ntlmv2_rsp and that function can
> return one.
>
> The whole house of cards needs a bit of rework I think...
>
> Shirish, since you're already doing work in this area, can you fix that
> too?
>
> Thanks,
> --
> Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
>

Looking into it.

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/cifs/dir.c: In function 'cifs_new_fileinfo':
fs/cifs/dir.c:140: warning: unused variable 'cifs_sb'

Introduced by commit 9a6124e7e18fa30d8693055e6a4526afb4c3fabc ("cifs:
have cifs_new_fileinfo take a tcon arg").

-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the cifs tree

[Jeff Layton]

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On Fri, 24 Sep 2010 13:48:41 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/cifs/dir.c: In function 'cifs_new_fileinfo':
> fs/cifs/dir.c:140: warning: unused variable 'cifs_sb'
> 
> Introduced by commit 9a6124e7e18fa30d8693055e6a4526afb4c3fabc ("cifs:
> have cifs_new_fileinfo take a tcon arg").
> 

That's fixed in the next patch in the multiuser mount series. It
probably should have been part of the patch above.

-- 
Jeff Layton <jlayton@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

linux-next: build warning after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/cifs/sess.c: In function 'CIFS_SessSetup':
fs/cifs/sess.c:623: warning: unused variable 'ntlmsspblob'

Introduced by commit 9fbc590860e75785bdaf8b83e48fabfe4d4f7d58 ("[CIFS]
Fix ntlmv2 auth with ntlmssp").

-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the cifs tree

[Steve French]

On Wed, Aug 25, 2010 at 8:02 PM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/cifs/sess.c: In function 'CIFS_SessSetup':
> fs/cifs/sess.c:623: warning: unused variable 'ntlmsspblob'
>
> Introduced by commit 9fbc590860e75785bdaf8b83e48fabfe4d4f7d58 ("[CIFS]
> Fix ntlmv2 auth with ntlmssp").

Shirish's patch doesn't use that local variable when experimental is
off - I will talk to him about simply moving the local variable to
eliminate the unused variable warning.


-- 
Thanks,

Steve