linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Baokun Li <libaokun1@huawei.com>
Cc: Steve French <sfrench@samba.org>,
	CIFS <linux-cifs@vger.kernel.org>,
	samba-technical <samba-technical@lists.samba.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>,
	Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] cifs: convert list_for_each to entry variant in cifs_debug.c
Date: Thu, 17 Jun 2021 23:18:35 -0500	[thread overview]
Message-ID: <CAH2r5ms4c37ykXetxy6CRL1WXWUZB59rFzm7ckG=0d-bYmnt1Q@mail.gmail.com> (raw)
In-Reply-To: <20210617113640.4141487-1-libaokun1@huawei.com>

tentatively merged into cifs-2.6.git for-next

On Thu, Jun 17, 2021 at 6:40 AM Baokun Li <libaokun1@huawei.com> wrote:
>
> convert list_for_each() to list_for_each_entry() where
> applicable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
>  fs/cifs/cifs_debug.c | 24 +++++++-----------------
>  1 file changed, 7 insertions(+), 17 deletions(-)
>
> diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
> index 68e8e5b27841..8857ac7e7a14 100644
> --- a/fs/cifs/cifs_debug.c
> +++ b/fs/cifs/cifs_debug.c
> @@ -50,7 +50,6 @@ void cifs_dump_detail(void *buf, struct TCP_Server_Info *server)
>  void cifs_dump_mids(struct TCP_Server_Info *server)
>  {
>  #ifdef CONFIG_CIFS_DEBUG2
> -       struct list_head *tmp;
>         struct mid_q_entry *mid_entry;
>
>         if (server == NULL)
> @@ -58,8 +57,7 @@ void cifs_dump_mids(struct TCP_Server_Info *server)
>
>         cifs_dbg(VFS, "Dump pending requests:\n");
>         spin_lock(&GlobalMid_Lock);
> -       list_for_each(tmp, &server->pending_mid_q) {
> -               mid_entry = list_entry(tmp, struct mid_q_entry, qhead);
> +       list_for_each_entry(mid_entry, &server->pending_mid_q, qhead) {
>                 cifs_dbg(VFS, "State: %d Cmd: %d Pid: %d Cbdata: %p Mid %llu\n",
>                          mid_entry->mid_state,
>                          le16_to_cpu(mid_entry->command),
> @@ -168,7 +166,7 @@ cifs_dump_iface(struct seq_file *m, struct cifs_server_iface *iface)
>
>  static int cifs_debug_files_proc_show(struct seq_file *m, void *v)
>  {
> -       struct list_head *stmp, *tmp, *tmp1, *tmp2;
> +       struct list_head *tmp, *tmp1, *tmp2;
>         struct TCP_Server_Info *server;
>         struct cifs_ses *ses;
>         struct cifs_tcon *tcon;
> @@ -183,9 +181,7 @@ static int cifs_debug_files_proc_show(struct seq_file *m, void *v)
>         seq_printf(m, " <filename>\n");
>  #endif /* CIFS_DEBUG2 */
>         spin_lock(&cifs_tcp_ses_lock);
> -       list_for_each(stmp, &cifs_tcp_ses_list) {
> -               server = list_entry(stmp, struct TCP_Server_Info,
> -                                   tcp_ses_list);
> +       list_for_each_entry(server, &cifs_tcp_ses_list, tcp_ses_list) {
>                 list_for_each(tmp, &server->smb_ses_list) {
>                         ses = list_entry(tmp, struct cifs_ses, smb_ses_list);
>                         list_for_each(tmp1, &ses->tcon_list) {
> @@ -220,7 +216,7 @@ static int cifs_debug_files_proc_show(struct seq_file *m, void *v)
>
>  static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
>  {
> -       struct list_head *tmp1, *tmp2, *tmp3;
> +       struct list_head *tmp2, *tmp3;
>         struct mid_q_entry *mid_entry;
>         struct TCP_Server_Info *server;
>         struct cifs_ses *ses;
> @@ -278,11 +274,7 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
>
>         c = 0;
>         spin_lock(&cifs_tcp_ses_lock);
> -       list_for_each(tmp1, &cifs_tcp_ses_list) {
> -               server = list_entry(tmp1, struct TCP_Server_Info,
> -                                   tcp_ses_list);
> -
> -               /* channel info will be printed as a part of sessions below */
> +       list_for_each_entry(server, &cifs_tcp_ses_list, tcp_ses_list) {
>                 if (server->is_channel)
>                         continue;
>
> @@ -563,7 +555,7 @@ static int cifs_stats_proc_show(struct seq_file *m, void *v)
>  #ifdef CONFIG_CIFS_STATS2
>         int j;
>  #endif /* STATS2 */
> -       struct list_head *tmp1, *tmp2, *tmp3;
> +       struct list_head *tmp2, *tmp3;
>         struct TCP_Server_Info *server;
>         struct cifs_ses *ses;
>         struct cifs_tcon *tcon;
> @@ -594,9 +586,7 @@ static int cifs_stats_proc_show(struct seq_file *m, void *v)
>
>         i = 0;
>         spin_lock(&cifs_tcp_ses_lock);
> -       list_for_each(tmp1, &cifs_tcp_ses_list) {
> -               server = list_entry(tmp1, struct TCP_Server_Info,
> -                                   tcp_ses_list);
> +       list_for_each_entry(server, &cifs_tcp_ses_list, tcp_ses_list) {
>                 seq_printf(m, "\nMax requests in flight: %d", server->max_in_flight);
>  #ifdef CONFIG_CIFS_STATS2
>                 seq_puts(m, "\nTotal time spent processing by command. Time ");
>


-- 
Thanks,

Steve

      reply	other threads:[~2021-06-18  4:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 11:36 Baokun Li
2021-06-18  4:18 ` Steve French [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH2r5ms4c37ykXetxy6CRL1WXWUZB59rFzm7ckG=0d-bYmnt1Q@mail.gmail.com' \
    --to=smfrench@gmail.com \
    --cc=hulkci@huawei.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=libaokun1@huawei.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    --subject='Re: [PATCH -next] cifs: convert list_for_each to entry variant in cifs_debug.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).