linux-next: Fixes tag needs some work in the cifs tree

linux-next: Fixes tag needs some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

Hi all,

In commit

  158c6b1e3dff ("cifs: fix memory leak in smb2_copychunk_range")

Fixes tag

  Fixes: 9bf0c9cd431440a831e60c0a0fd0bc4f0e083e7f

has these problem(s):

  - missing subject

Pleas just use:

  git log -1 --format='Fixes: %h ("%s")' <commit>

So

Fixes: 9bf0c9cd4314 ("CIFS: Fix SMB2/SMB3 Copy offload support (refcopy) for large files")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the cifs tree

[Steve French]

Patch description ("Fixes: ...") updated as requested.


On Wed, May 19, 2021 at 4:53 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   158c6b1e3dff ("cifs: fix memory leak in smb2_copychunk_range")
>
> Fixes tag
>
>   Fixes: 9bf0c9cd431440a831e60c0a0fd0bc4f0e083e7f
>
> has these problem(s):
>
>   - missing subject
>
> Pleas just use:
>
>   git log -1 --format='Fixes: %h ("%s")' <commit>
>
> So
>
> Fixes: 9bf0c9cd4314 ("CIFS: Fix SMB2/SMB3 Copy offload support (refcopy) for large files")
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

Re: linux-next: Fixes tag needs some work in the cifs tree

[Steve French]

Fixed. And updated now in cifs-2.6.git for-next

On Thu, Feb 23, 2023 at 3:27 PM David Howells <dhowells@redhat.com> wrote:
>
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > In commit
> >
> >   d7830041d59a ("cifs: Add some missing xas_retry() calls")
> >
> > Fixes tag
> >
> >   Fixes: 5f0955c98375 ("cifs: Add some helper functions")
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: b8713c4dbfa3 ("cifs: Add some helper functions")
>
> Sorry, yes, I was on my branch and not the one with Steve's applied version of
> the patches.
>
> David
>


-- 
Thanks,

Steve

Re: linux-next: Fixes tag needs some work in the cifs tree

[David Howells]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> In commit
> 
>   d7830041d59a ("cifs: Add some missing xas_retry() calls")
> 
> Fixes tag
> 
>   Fixes: 5f0955c98375 ("cifs: Add some helper functions")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: b8713c4dbfa3 ("cifs: Add some helper functions")

Sorry, yes, I was on my branch and not the one with Steve's applied version of
the patches.

David

linux-next: Fixes tag needs some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

Hi all,

In commit

  d7830041d59a ("cifs: Add some missing xas_retry() calls")

Fixes tag

  Fixes: 5f0955c98375 ("cifs: Add some helper functions")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: b8713c4dbfa3 ("cifs: Add some helper functions")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the cifs tree

[Steve French]

updated Fixes tag for that commit in cifs-2.6.git for-next

On Tue, Nov 15, 2022 at 2:41 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   9898f0456aa3 ("cifs: Fix wrong return value checking when GETFLAGS")
>
> Fixes tag
>
>   Fixes: 64a5cfa6db9 ("Allow setting per-file compression via SMB2/3")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Fixes tag needs some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hi all,

In commit

  9898f0456aa3 ("cifs: Fix wrong return value checking when GETFLAGS")

Fixes tag

  Fixes: 64a5cfa6db9 ("Allow setting per-file compression via SMB2/3")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the cifs tree

[Steve French]

fixed

On Sat, Oct 15, 2022 at 3:57 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   ddf95e7d5a81 ("cifs: fix double-fault crash during ntlmssp")
>
> Fixes tag
>
>   Fixes: d867d4ae29c7 ("cifs: replace kfree() with kfree_sensitive() for sensitive data")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: a4e430c8c8ba ("cifs: replace kfree() with kfree_sensitive() for sensitive data")
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Fixes tag needs some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi all,

In commit

  ddf95e7d5a81 ("cifs: fix double-fault crash during ntlmssp")

Fixes tag

  Fixes: d867d4ae29c7 ("cifs: replace kfree() with kfree_sensitive() for sensitive data")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: a4e430c8c8ba ("cifs: replace kfree() with kfree_sensitive() for sensitive data")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the cifs tree

[Steve French]

fixed

On Wed, Oct 5, 2022 at 6:30 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   395381a6c0f7 ("cifs: fix uninitialised var in smb2_compound_op()")
>
> Fixes tag
>
>   Fixes: 5079f2691f73 ("cifs: improve symlink handling for smb2+")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: d689449ef101 ("cifs: improve symlink handling for smb2+")
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Fixes tag needs some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

Hi all,

In commit

  395381a6c0f7 ("cifs: fix uninitialised var in smb2_compound_op()")

Fixes tag

  Fixes: 5079f2691f73 ("cifs: improve symlink handling for smb2+")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: d689449ef101 ("cifs: improve symlink handling for smb2+")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the cifs tree

[Steve French]

sorry about the cut-n-paste error

fixed

On Tue, Aug 30, 2022 at 4:42 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   ebcc8ccc13e0 ("smb3: use filemap_write_and_wait_range instead of filemap_write_and_wait")
>
> Fixes tag
>
>   Fixes: c3a72bb21320 ("Reviewed-by: David Howells <dhowells@redhat.com>")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'
>
> So,
>
> Fixes: c3a72bb21320 ("smb3: Move the flush out of smb2_copychunk_range() into its callers")
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Fixes tag needs some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

Hi all,

In commit

  ebcc8ccc13e0 ("smb3: use filemap_write_and_wait_range instead of filemap_write_and_wait")

Fixes tag

  Fixes: c3a72bb21320 ("Reviewed-by: David Howells <dhowells@redhat.com>")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

So,

Fixes: c3a72bb21320 ("smb3: Move the flush out of smb2_copychunk_range() into its callers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the cifs tree

[Steve French]

typo corrected and updated cifs-2.6.git for-next

On Wed, Aug 24, 2022 at 1:38 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   b044b4dd6048 ("smb3: fix temporary data corruption in insert range")
>
> Fixes tag
>
>   Fixes: 7fe6fe95b9360 ("cifs: FALLOC_FL_INSERT_RANGE support")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Fixes tag needs some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

Hi all,

In commit

  b044b4dd6048 ("smb3: fix temporary data corruption in insert range")

Fixes tag

  Fixes: 7fe6fe95b9360 ("cifs: FALLOC_FL_INSERT_RANGE support")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

In commit

  37c1ad516f2c ("cifs: fix race condition with delayed threads")

Fixes tag

  Fixes: 37d488b3d38c ("cifs: change iface_list from array to sorted linked list")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: aa45dadd34e4 ("cifs: change iface_list from array to sorted linked list")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the cifs tree

[Murphy Zhou]

On Fri, May 24, 2019 at 10:14 PM Steve French <smfrench@gmail.com> wrote:
>
> fixed and repushed to cifs-2.6.git for-next

Thanks!

[resend including mail lists]

>
> On Thu, May 23, 2019 at 11:27 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> >   f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free")
> >
> > Fixes tag
> >
> >   Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl")
> >
> > has these problem(s):
> >
> >   - SHA1 should be at least 12 digits long
> >     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> >     or later) just making sure it is not set (or set to "auto").
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>
>
> --
> Thanks,
>
> Steve

Re: linux-next: Fixes tag needs some work in the cifs tree

[Steve French]

fixed and repushed to cifs-2.6.git for-next

On Thu, May 23, 2019 at 11:27 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free")
>
> Fixes tag
>
>   Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Fixes tag needs some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

In commit

  f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free")

Fixes tag

  Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]