* linux-next: Fixes tag needs some work in the cifs tree
@ 2021-05-19 21:53 Stephen Rothwell
2021-05-20 0:21 ` Steve French
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2021-05-19 21:53 UTC (permalink / raw)
To: Steve French, CIFS
Cc: Ronnie Sahlberg, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
Hi all,
In commit
158c6b1e3dff ("cifs: fix memory leak in smb2_copychunk_range")
Fixes tag
Fixes: 9bf0c9cd431440a831e60c0a0fd0bc4f0e083e7f
has these problem(s):
- missing subject
Pleas just use:
git log -1 --format='Fixes: %h ("%s")' <commit>
So
Fixes: 9bf0c9cd4314 ("CIFS: Fix SMB2/SMB3 Copy offload support (refcopy) for large files")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the cifs tree
2021-05-19 21:53 linux-next: Fixes tag needs some work in the cifs tree Stephen Rothwell
@ 2021-05-20 0:21 ` Steve French
0 siblings, 0 replies; 6+ messages in thread
From: Steve French @ 2021-05-20 0:21 UTC (permalink / raw)
To: Stephen Rothwell
Cc: CIFS, Ronnie Sahlberg, Linux Kernel Mailing List,
Linux Next Mailing List
Patch description ("Fixes: ...") updated as requested.
On Wed, May 19, 2021 at 4:53 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
> 158c6b1e3dff ("cifs: fix memory leak in smb2_copychunk_range")
>
> Fixes tag
>
> Fixes: 9bf0c9cd431440a831e60c0a0fd0bc4f0e083e7f
>
> has these problem(s):
>
> - missing subject
>
> Pleas just use:
>
> git log -1 --format='Fixes: %h ("%s")' <commit>
>
> So
>
> Fixes: 9bf0c9cd4314 ("CIFS: Fix SMB2/SMB3 Copy offload support (refcopy) for large files")
>
> --
> Cheers,
> Stephen Rothwell
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Fixes tag needs some work in the cifs tree
@ 2022-07-05 22:06 Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2022-07-05 22:06 UTC (permalink / raw)
To: Steve French, CIFS
Cc: Shyam Prasad N, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Hi all,
In commit
37c1ad516f2c ("cifs: fix race condition with delayed threads")
Fixes tag
Fixes: 37d488b3d38c ("cifs: change iface_list from array to sorted linked list")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: aa45dadd34e4 ("cifs: change iface_list from array to sorted linked list")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the cifs tree
2019-05-24 14:14 ` Steve French
@ 2019-05-29 3:24 ` Murphy Zhou
0 siblings, 0 replies; 6+ messages in thread
From: Murphy Zhou @ 2019-05-29 3:24 UTC (permalink / raw)
To: Steve French
Cc: Stephen Rothwell, CIFS, Linux Next Mailing List,
Linux Kernel Mailing List
On Fri, May 24, 2019 at 10:14 PM Steve French <smfrench@gmail.com> wrote:
>
> fixed and repushed to cifs-2.6.git for-next
Thanks!
[resend including mail lists]
>
> On Thu, May 23, 2019 at 11:27 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> > f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free")
> >
> > Fixes tag
> >
> > Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl")
> >
> > has these problem(s):
> >
> > - SHA1 should be at least 12 digits long
> > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > or later) just making sure it is not set (or set to "auto").
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>
>
> --
> Thanks,
>
> Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the cifs tree
2019-05-24 4:27 Stephen Rothwell
@ 2019-05-24 14:14 ` Steve French
2019-05-29 3:24 ` Murphy Zhou
0 siblings, 1 reply; 6+ messages in thread
From: Steve French @ 2019-05-24 14:14 UTC (permalink / raw)
To: Stephen Rothwell
Cc: CIFS, Linux Next Mailing List, Linux Kernel Mailing List, Murphy Zhou
fixed and repushed to cifs-2.6.git for-next
On Thu, May 23, 2019 at 11:27 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
> f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free")
>
> Fixes tag
>
> Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>
> --
> Cheers,
> Stephen Rothwell
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Fixes tag needs some work in the cifs tree
@ 2019-05-24 4:27 Stephen Rothwell
2019-05-24 14:14 ` Steve French
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-05-24 4:27 UTC (permalink / raw)
To: Steve French, CIFS
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Murphy Zhou
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
Hi all,
In commit
f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free")
Fixes tag
Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-05 22:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 21:53 linux-next: Fixes tag needs some work in the cifs tree Stephen Rothwell
2021-05-20 0:21 ` Steve French
-- strict thread matches above, loose matches on Subject: below --
2022-07-05 22:06 Stephen Rothwell
2019-05-24 4:27 Stephen Rothwell
2019-05-24 14:14 ` Steve French
2019-05-29 3:24 ` Murphy Zhou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).