linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Matthias Maennich <maennich@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	CIFS <linux-cifs@vger.kernel.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Jessica Yu <jeyu@kernel.org>
Subject: Re: nsdeps not working on modules in 5.4-rc1
Date: Thu, 3 Oct 2019 10:14:53 -0500	[thread overview]
Message-ID: <CAH2r5msF5DF2ac+-V0xRR-8RYeQdwpsS1iBLHM6iKTB+aEVc5Q@mail.gmail.com> (raw)
In-Reply-To: <20191003104356.GA77584@google.com>

On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
>
> Hi Steve!
>
> On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> >And running the build differently, from the root of the git tree
> >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
> >
> >e.g. "make  M=fs/cifs modules nsdeps"
> >
> >...
> >  LD [M]  fs/cifs/cifs.o
> >  Building modules, stage 2.
> >  MODPOST 1 modules
> >WARNING: module cifs uses symbol sigprocmask from namespace
> >_fs/cifs/cache.o), but does not import it.
> >...
> >WARNING: module cifs uses symbol posix_test_lock from namespace
> >cifs/cache.o), but does not import it.
> >  CC [M]  fs/cifs/cifs.mod.o
> >  LD [M]  fs/cifs/cifs.ko
> >  Building modules, stage 2.
> >  MODPOST 1 modules
> >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> >make: *** [Makefile:1710: nsdeps] Error 2
>
> Thanks for reporting this. It appears to me you hit a bug that was
> recently discovered: when building with `make M=some/subdirectory`,
> modpost is misbehaving. Can you try whether this patch series solves
> your problems:
> https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
> In particular patch 2/6 out of the series.
>
> Cheers,
> Matthias


Applying just patch 2 and doing "make" from the root of the git tree
(5.4-rc1), at the tail end of the build I got

...
Kernel: arch/x86/boot/bzImage is ready  (#87)
  Building modules, stage 2.
  MODPOST 5340 modules
free(): invalid pointer
Aborted (core dumped)
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 134
make: *** [Makefile:1303: modules] Error 2

With patch 2 and doing make M=fs/cifs nsdeps from the root of the git tree I get

$ make M=fs/cifs nsdeps
  Building modules, stage 2.
  MODPOST 1 modules
  Building modules, stage 2.
  MODPOST 1 modules
./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
make: *** [Makefile:1710: nsdeps] Error 2


-- 
Thanks,

Steve

  reply	other threads:[~2019-10-03 15:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAH2r5mv49T9gwwoJxKJfkgdi6xbf+hDALUiAJHghGikgUNParw@mail.gmail.com>
2019-10-02 23:54 ` nsdeps not working on modules in 5.4-rc1 Steve French
2019-10-03 10:43   ` Matthias Maennich
2019-10-03 15:14     ` Steve French [this message]
2019-10-03 15:23       ` Masahiro Yamada
2019-10-03 16:06         ` Steve French
2019-10-04  3:40           ` Masahiro Yamada
2019-10-04  4:27             ` Steve French
2019-10-04  4:50               ` Masahiro Yamada
2019-10-04  5:01                 ` Steve French
2019-10-04 10:40                   ` Matthias Maennich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH2r5msF5DF2ac+-V0xRR-8RYeQdwpsS1iBLHM6iKTB+aEVc5Q@mail.gmail.com \
    --to=smfrench@gmail.com \
    --cc=jeyu@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maennich@google.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).