linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [CIFS][PATCH] fix unneeded null check
@ 2021-06-19 17:08 Steve French
  0 siblings, 0 replies; only message in thread
From: Steve French @ 2021-06-19 17:08 UTC (permalink / raw)
  To: CIFS

[-- Attachment #1: Type: text/plain, Size: 132 bytes --]

tcon can not be null in SMB2_tcon function so the check
is not relevant and removing it makes Coverity happy.



-- 
Thanks,

Steve

[-- Attachment #2: 0001-cifs-fix-unneeded-null-check.patch --]
[-- Type: text/x-patch, Size: 1160 bytes --]

From d2d6e8657d7eaed14cff869aec902ceb2320a668 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Sat, 19 Jun 2021 12:01:37 -0500
Subject: [PATCH] cifs: fix unneeded null check

tcon can not be null in SMB2_tcon function so the check
is not relevant and removing it makes Coverity happy.

Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
Addresses-Coverity: 13250131 ("Dereference before null check")
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/smb2pdu.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 07c38eec3929..454586d4c0fb 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -1793,10 +1793,8 @@ SMB2_tcon(const unsigned int xid, struct cifs_ses *ses, const char *tree,
 	rsp = (struct smb2_tree_connect_rsp *)rsp_iov.iov_base;
 	trace_smb3_tcon(xid, tcon->tid, ses->Suid, tree, rc);
 	if (rc != 0) {
-		if (tcon) {
-			cifs_stats_fail_inc(tcon, SMB2_TREE_CONNECT_HE);
-			tcon->need_reconnect = true;
-		}
+		cifs_stats_fail_inc(tcon, SMB2_TREE_CONNECT_HE);
+		tcon->need_reconnect = true;
 		goto tcon_error_exit;
 	}
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-19 17:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-19 17:08 [CIFS][PATCH] fix unneeded null check Steve French

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).