Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
* setattr and writing out dirty pages
@ 2019-07-16 21:16 Steve French
  0 siblings, 0 replies; only message in thread
From: Steve French @ 2019-07-16 21:16 UTC (permalink / raw)
  To: CIFS

We always flush data out of the local cache on any set attribute change

(see line 2434 of fs/cifs/inode.c)
       rc = filemap_write_and_wait(inode->i_mapping);


which seems too aggressive since it only needs to be done on ATTR_SIZE
and ATTR_MTIME changes.

With Ronnie's recent patch we also do an smb3 flush request when last
write time changes (to work around the problem where the timestamps
(set e.g. by "cp -p") can be reset to current time on close otherwise.

-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 21:16 setattr and writing out dirty pages Steve French

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org linux-cifs@archiver.kernel.org
	public-inbox-index linux-cifs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox