From: Steve French <smfrench@gmail.com>
To: L Walsh <cifs@tlinx.org>
Cc: CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [CIFS][PATCH] Add SMB2? Change Notify
Date: Mon, 10 Feb 2020 08:30:02 -0600 [thread overview]
Message-ID: <CAH2r5mst9FjdPrBQdjt1HGkf73VoNzDUxPSEQNZwyi=9W9XGhA@mail.gmail.com> (raw)
In-Reply-To: <5E413F22.3070101@tlinx.org>
On Mon, Feb 10, 2020 at 5:31 AM L Walsh <cifs@tlinx.org> wrote:
>
> On 2020/02/06 04:29, Steve French wrote:
> > A commonly used SMB3 feature is change notification, allowing an
> > app to be notified about changes to a directory. The SMB3
> > Notify request blocks until the server detects a change to that
> > directory or its contents that matches the completion flags
> > that were passed in and the "watch_tree" flag (which indicates
> > whether subdirectories under this directory should be also
> > included). See MS-SMB2 2.2.35 for additional detail.
> >
> ----
> How does the SMB3 feature "change notification" differ from
> the SMB2 feature described in MS-SMB2 2.2.35?
>
> Isn't it more typical to describe features by the spec version
> that they were first publish under -- especially since the doc
> describing the feature is under the SMB2 documents?
>
> By calling it a SMB3 feature, does that mean you are removing
> it from SMB2?
That is a good question. I should have made more clear that although
many servers support Change Notify prior to SMB3 dialect, we chose
to implement it in SMB3 (late 2012 and later dialect) to minimize testing
risks and since we want to encourage users to use SMB3 or later (or
at least SMB2.1 or later since security is significantly better for later
dialects than for SMB1 and even SMB2)
Change Notify is available in all dialects (SMB2, SMB2.1, SMB3, SMB3.1.1)
for many servers but for the client we just implemented it for SMB3 and later.
If you have a server that you want to support that requires
SMB2 or SMB2.1 mounts, I wouldn't mind a patch to add notify support
for those older dialects but I would like to encourage use of SMB3 or later (or
at least SMB2.1 or later) where possible.
Steve
next prev parent reply other threads:[~2020-02-10 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 12:29 [CIFS][PATCH] Add SMB3 Change Notify Steve French
2020-02-10 11:31 ` [CIFS][PATCH] Add SMB2? " L Walsh
2020-02-10 14:30 ` Steve French [this message]
2020-02-12 23:32 ` [CIFS][PATCH] Add SMB3/Win10-only " L Walsh
2020-02-13 4:43 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5mst9FjdPrBQdjt1HGkf73VoNzDUxPSEQNZwyi=9W9XGhA@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=cifs@tlinx.org \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).