From: Steve French <smfrench@gmail.com>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: Namjae Jeon <namjae.jeon@samsung.com>,
Leif Sahlberg <lsahlber@redhat.com>,
linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: only write 64kb at a time when fallocating a small region of a file
Date: Thu, 22 Jul 2021 11:44:41 -0500 [thread overview]
Message-ID: <CAH2r5mt0JdioMoVZ4zOpe7cM=_tWif2VdbscAR6Osh1hJO_wfA@mail.gmail.com> (raw)
In-Reply-To: <CAN05THTv3o8yDuGLJE5M+YXhdW6ChnnUyznVF_a_3uLQcE=5Tw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2321 bytes --]
Removed the deletion from the patch, and added Reported-by: Namjae ...
and pushed to cifs-2.6.git for-next
On Thu, Jul 22, 2021 at 2:19 AM ronnie sahlberg
<ronniesahlberg@gmail.com> wrote:
>
> Yes, ofcourse.
>
> Steve, can you revert that deletion in the patch?
>
> On Thu, Jul 22, 2021 at 4:55 PM Namjae Jeon <namjae.jeon@samsung.com> wrote:
> >
> > > This code is actually bogus and does the opposite of what the comment says.
> > > If out_data_len is 0 then that means that the entire region is unallocated and then we should not
> > > bail out but proceed and allocate the hole.
> >
> > > generic/071 works against a windows server for me.
> >
> >
> > > If it fails with this code removed it might mean that generic/071 never worked with cifs.ko correctly.
> >
> > generic/071 create preallocated extent by calling fallocate with keep size flags.
> > It means the file size should not be increased.
> > But if (out_buf_len == 0) check is removed, 1MB write is performed using SMB2_write loop().
> > It means the file size becomes 1MB.
> >
> > And then, generic/071 call again fallocate(0, 512K) which mean file size should be 512K.
> > but SMB2_set_eof() in cifs is not called due to the code below(->i_size is bigger than off + len),
> > So 071 test failed as file size remains 1MB.
> >
> > /*
> > * Extending the file
> > */
> > if ((keep_size == false) && i_size_read(inode) < off + len) {
> > rc = inode_newsize_ok(inode, off + len);
> > if (rc)
> > goto out;
> >
> > if ((cifsi->cifsAttrs & FILE_ATTRIBUTE_SPARSE_FILE) == 0)
> > smb2_set_sparse(xid, tcon, cfile, inode, false);
> >
> > eof = cpu_to_le64(off + len);
> > rc = SMB2_set_eof(xid, tcon, cfile->fid.persistent_fid,
> > cfile->fid.volatile_fid, cfile->pid, &eof);
> > if (rc == 0) {
> > cifsi->server_eof = off + len;
> > cifs_setsize(inode, off + len);
> > cifs_truncate_page(inode->i_mapping, inode->i_size);
> > truncate_setsize(inode, off + len);
> > }
> > goto out;
> > }
> >
--
Thanks,
Steve
[-- Attachment #2: 0001-cifs-only-write-64kb-at-a-time-when-fallocating-a-sm.patch --]
[-- Type: text/x-patch, Size: 2028 bytes --]
From 2485bd7557a7edb4520b4072af464f0a08c8efe0 Mon Sep 17 00:00:00 2001
From: Ronnie Sahlberg <lsahlber@redhat.com>
Date: Thu, 22 Jul 2021 14:53:32 +1000
Subject: [PATCH 1/2] cifs: only write 64kb at a time when fallocating a small
region of a file
We only allow sending single credit writes through the SMB2_write() synchronous
api so split this into smaller chunks.
Fixes: 966a3cb7c7db ("cifs: improve fallocate emulation")
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Reported-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---
fs/cifs/smb2ops.c | 26 +++++++++++++++++++-------
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index ba3c58e1f725..5cefb5972396 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -3617,7 +3617,7 @@ static int smb3_simple_fallocate_write_range(unsigned int xid,
char *buf)
{
struct cifs_io_parms io_parms = {0};
- int nbytes;
+ int rc, nbytes;
struct kvec iov[2];
io_parms.netfid = cfile->fid.netfid;
@@ -3625,13 +3625,25 @@ static int smb3_simple_fallocate_write_range(unsigned int xid,
io_parms.tcon = tcon;
io_parms.persistent_fid = cfile->fid.persistent_fid;
io_parms.volatile_fid = cfile->fid.volatile_fid;
- io_parms.offset = off;
- io_parms.length = len;
- /* iov[0] is reserved for smb header */
- iov[1].iov_base = buf;
- iov[1].iov_len = io_parms.length;
- return SMB2_write(xid, &io_parms, &nbytes, iov, 1);
+ while (len) {
+ io_parms.offset = off;
+ io_parms.length = len;
+ if (io_parms.length > SMB2_MAX_BUFFER_SIZE)
+ io_parms.length = SMB2_MAX_BUFFER_SIZE;
+ /* iov[0] is reserved for smb header */
+ iov[1].iov_base = buf;
+ iov[1].iov_len = io_parms.length;
+ rc = SMB2_write(xid, &io_parms, &nbytes, iov, 1);
+ if (rc)
+ break;
+ if (nbytes > len)
+ return -EINVAL;
+ buf += nbytes;
+ off += nbytes;
+ len -= nbytes;
+ }
+ return rc;
}
static int smb3_simple_fallocate_range(unsigned int xid,
--
2.30.2
next prev parent reply other threads:[~2021-07-22 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210721015429epcas1p4654c2b9348101aa7967bfe60d1d8da71@epcas1p4.samsung.com>
[not found] ` <014c01d77dd3$57add320$07097960$@samsung.com>
2021-07-21 7:21 ` [PATCH] cifs: only write 64kb at a time when fallocating a small region of a file Namjae Jeon
[not found] ` <CAGvGhF55Tq-sLUtKBn+QX6kWrL9dDzKkXFKdQ==gz3s=RkySKQ@mail.gmail.com>
2021-07-22 6:54 ` Namjae Jeon
2021-07-22 7:17 ` ronnie sahlberg
2021-07-22 7:22 ` Namjae Jeon
2021-07-22 16:44 ` Steve French [this message]
2021-07-22 4:53 Ronnie Sahlberg
-- strict thread matches above, loose matches on Subject: below --
2021-07-21 0:50 Ronnie Sahlberg
2021-07-21 0:49 Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5mt0JdioMoVZ4zOpe7cM=_tWif2VdbscAR6Osh1hJO_wfA@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=namjae.jeon@samsung.com \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).