linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] cifs: Remove unused inline function is_sysvol_or_netlogon()
@ 2021-05-29 11:48 YueHaibing
  2021-05-31 14:47 ` Paulo Alcantara
  0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2021-05-29 11:48 UTC (permalink / raw)
  To: sfrench; +Cc: linux-cifs, samba-technical, linux-kernel, YueHaibing

is_sysvol_or_netlogon() is never used, so can remove it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 fs/cifs/dfs_cache.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
index b1fa30fefe1f..03c81c39a507 100644
--- a/fs/cifs/dfs_cache.c
+++ b/fs/cifs/dfs_cache.c
@@ -319,17 +319,6 @@ static inline unsigned int cache_entry_hash(const void *data, int size)
 	return h & (CACHE_HTABLE_SIZE - 1);
 }
 
-/* Check whether second path component of @path is SYSVOL or NETLOGON */
-static inline bool is_sysvol_or_netlogon(const char *path)
-{
-	const char *s;
-	char sep = path[0];
-
-	s = strchr(path + 1, sep) + 1;
-	return !strncasecmp(s, "sysvol", strlen("sysvol")) ||
-		!strncasecmp(s, "netlogon", strlen("netlogon"));
-}
-
 /* Return target hint of a DFS cache entry */
 static inline char *get_tgt_name(const struct cache_entry *ce)
 {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] cifs: Remove unused inline function is_sysvol_or_netlogon()
  2021-05-29 11:48 [PATCH -next] cifs: Remove unused inline function is_sysvol_or_netlogon() YueHaibing
@ 2021-05-31 14:47 ` Paulo Alcantara
  2021-06-05 20:44   ` Steve French
  0 siblings, 1 reply; 3+ messages in thread
From: Paulo Alcantara @ 2021-05-31 14:47 UTC (permalink / raw)
  To: YueHaibing, sfrench; +Cc: linux-cifs, samba-technical, linux-kernel, YueHaibing

YueHaibing <yuehaibing@huawei.com> writes:

> is_sysvol_or_netlogon() is never used, so can remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  fs/cifs/dfs_cache.c | 11 -----------
>  1 file changed, 11 deletions(-)

Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] cifs: Remove unused inline function is_sysvol_or_netlogon()
  2021-05-31 14:47 ` Paulo Alcantara
@ 2021-06-05 20:44   ` Steve French
  0 siblings, 0 replies; 3+ messages in thread
From: Steve French @ 2021-06-05 20:44 UTC (permalink / raw)
  To: Paulo Alcantara; +Cc: YueHaibing, Steve French, CIFS, samba-technical, LKML

merged into cifs-2.6.git for-next

On Mon, May 31, 2021 at 9:50 AM Paulo Alcantara <pc@cjr.nz> wrote:
>
> YueHaibing <yuehaibing@huawei.com> writes:
>
> > is_sysvol_or_netlogon() is never used, so can remove it.
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >  fs/cifs/dfs_cache.c | 11 -----------
> >  1 file changed, 11 deletions(-)
>
> Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>



-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-05 20:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-29 11:48 [PATCH -next] cifs: Remove unused inline function is_sysvol_or_netlogon() YueHaibing
2021-05-31 14:47 ` Paulo Alcantara
2021-06-05 20:44   ` Steve French

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).