From: Steve French <firstname.lastname@example.org> To: Ralph Boehme <email@example.com> Cc: Namjae Jeon <firstname.lastname@example.org>, CIFS <email@example.com>, Ronnie Sahlberg <firstname.lastname@example.org> Subject: Re: [PATCH v2 1/4] ksmbd: add request buffer validation in smb2_set_info Date: Mon, 20 Sep 2021 11:20:24 -0500 [thread overview] Message-ID: <CAH2r5mtHCpy9n6LXDU+V2uJAEQqh4J80gRzinxbpiVs7HTh81g@mail.gmail.com> (raw) In-Reply-To: <email@example.com> On Mon, Sep 20, 2021 at 11:11 AM Ralph Boehme <firstname.lastname@example.org> wrote: > > Am 20.09.21 um 17:10 schrieb Steve French: > > On Mon, Sep 20, 2021 at 10:03 AM Ralph Boehme <email@example.com> wrote: > >> > >> Am 20.09.21 um 16:45 schrieb Ralph Boehme: > >>> Am 19.09.21 um 04:13 schrieb Namjae Jeon: > >>>> Use LOOKUP_NO_SYMLINKS flags for default lookup to prohibit the > >>>> middle of symlink component lookup. > >>> > >>> maybe this patch should be squashed with the "ksmbd: remove follow > >>> symlinks support" patch? > >> > >> also, I noticed that the patches are already included in ksmbd-for-next. > >> Did I miss Steve's ack on the ML? > >> > >> I wonder why the patches are already included in ksmbd-for-next without > >> a proper review, I just started to look at the patches and wanted to > >> raise several issues. > > > > I included them at Namjae's request in for-next to allow the automated > > tests to run on them (e.g. the Intel test robot etc.) - those > > automated bots can be useful ... but I had done some review of all of > > them, and detailed review of most, and had run the automated tests > > (buildbot) on them (which passed, even after adding more subtests), > > and the smbtorture tests were also automatically run (it is triggered > > in Namjae's github setup). > > > > Of the 8 patches in for-next, these 3 are the remaining ones that I am > > looking at in more detail now: > > > > 24f0f4fc5f76 ksmbd: use LOOKUP_NO_SYMLINKS flags for default lookup > > 1ec1e6928354 ksmbd: add buffer validation for SMB2_CREATE_CONTEXT > > e2cd5c814442 ksmbd: add validation in smb2_ioctl > > ok, thanks for explaining. > > To be honest, I'm still trying to make sense of the patch workflow. > Hopefully I get there eventually. > > How can I detect if a patch is already reviewed and queued for upstrea > merge, so it's "too late" for me to do a review? It is not too late to do review of any of these 8. Given the importance of security, the more reviews the better. Earliest we would send them (the larger set of 8) upstream would be in a few days. I typically like to have them sit in for-next for 48 hours (although in some cases make exceptions, e.g. for important bug fixes I will shorten this if later in the week so they make it in time for the next rc) -- Thanks, Steve
next prev parent reply other threads:[~2021-09-20 16:21 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-19 2:13 Namjae Jeon 2021-09-19 2:13 ` [PATCH] ksmbd: use LOOKUP_NO_SYMLINKS flags for default lookup Namjae Jeon 2021-09-19 2:13 ` [PATCH v2 2/4] ksmbd: add validation in smb2_ioctl Namjae Jeon 2021-09-21 8:08 ` Ralph Boehme 2021-09-21 11:15 ` Namjae Jeon 2021-09-19 2:13 ` [PATCH v2 3/4] ksmbd: add validation for FILE_FULL_EA_INFORMATION of smb2_get_info Namjae Jeon 2021-09-21 8:09 ` Ralph Boehme 2021-09-19 2:13 ` [PATCH v2 4/4] ksmbd: add buffer validation for SMB2_CREATE_CONTEXT Namjae Jeon 2021-09-21 8:32 ` Ralph Boehme 2021-09-22 0:26 ` Namjae Jeon 2021-09-20 14:45 ` [PATCH v2 1/4] ksmbd: add request buffer validation in smb2_set_info Ralph Boehme 2021-09-20 15:03 ` Ralph Boehme 2021-09-20 15:10 ` Steve French 2021-09-20 16:11 ` Ralph Boehme 2021-09-20 16:20 ` Steve French [this message] 2021-09-20 16:30 ` Ralph Boehme 2021-09-20 15:38 ` Ralph Boehme 2021-09-20 16:18 ` Namjae Jeon 2021-09-21 14:23 ` Tom Talpey 2021-09-22 2:31 ` Namjae Jeon 2021-09-22 3:40 ` Namjae Jeon 2021-09-22 18:39 ` Tom Talpey
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAH2r5mtHCpy9n6LXDU+V2uJAEQqh4J80gRzinxbpiVs7HTh81g@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2 1/4] ksmbd: add request buffer validation in smb2_set_info' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).