From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 751D3C35247 for ; Thu, 6 Feb 2020 22:48:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BCF321927 for ; Thu, 6 Feb 2020 22:48:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HecFiJFR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727367AbgBFWsG (ORCPT ); Thu, 6 Feb 2020 17:48:06 -0500 Received: from mail-il1-f194.google.com ([209.85.166.194]:43980 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727379AbgBFWsF (ORCPT ); Thu, 6 Feb 2020 17:48:05 -0500 Received: by mail-il1-f194.google.com with SMTP id o13so80948ilg.10 for ; Thu, 06 Feb 2020 14:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Me96jU09hHf5xkQ+eGjbRR2J/Hkt0Ae0G1Fj89bcOEw=; b=HecFiJFRrFnnogXrz1PBIGIYEIIDLJFue9gPgZE4uhBs7srJoNDeAjt5GSy5Isa7WE L0+F5I9BQXJOfeIiEzXIC/gJzHigrJO0ngF3zAwH7++lxjsLJvdTNRQ6XjF2TDoBjjtg Wts+sivLnhjQ4zck3wTIVjvkSkJtdI0mzMJoLzgTD4w7j1yHtNtAAj9qowrJ/Iw2fIoS fOqlqsyOuNC+P4l0PNLYcvNmBLsuoWIgMXGza7KnQ8uBtrM9/songccqhQbqpv6+X7HU VqXEvDY/4P3aOahG/hIkeciwHJnNoPHWE7BFVaQOHJVVPtDdqQ3T2kXMxvdNIsMjC5Nh PdRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Me96jU09hHf5xkQ+eGjbRR2J/Hkt0Ae0G1Fj89bcOEw=; b=twXzNdcFzoseG1kH6ykMT8Cx0Ulb72/NMzWS0xdIOHeYezUlPikb/A/ozUguDBAcx5 8lGdWNufGMrXAukvo9sQTAbRoQ5xe3AQVsRTSgt4umcZZNR+pPVWpgRvzMLz4S5J/t91 yZXUIY8fAIJgW2nc1zMntOOKAy3WexokDl6OQKl922lQpyeVYiMrVa+gd1WOlZIC9Dej c+k6FTm0w5yuqIyYFtO0Q9xTv335XZS5pw1GW9kOAKOnOJtfD70xdrDdRhH0ArjnQMBZ Xj3OaSETW5I7DEFshxUKoEjGzB6hKfeUsniQfKTPWh0sr4UPa5SHJSbFgU+aRi4IDoU1 3GlA== X-Gm-Message-State: APjAAAVOsTbyrN6BQNnOW3zi68kiHZ65tosvcokFGkp/jkqkYNrAJKnW 3uJRZeri0LQpJg5k01DocTOs332OfVQVRZwWqpA= X-Google-Smtp-Source: APXvYqx6O3nZ/j4MKIKdpl9NWkKvZmtbUU/uM7OcH+/ocYV9CIDvzULAITL+H5EDurxJDxEfpLC+L/2G3dPx6OgUv2w= X-Received: by 2002:a92:cb8c:: with SMTP id z12mr6047360ilo.5.1581029284836; Thu, 06 Feb 2020 14:48:04 -0800 (PST) MIME-Version: 1.0 References: <202002070617.AbeYy9qc%lkp@intel.com> In-Reply-To: <202002070617.AbeYy9qc%lkp@intel.com> From: Steve French Date: Thu, 6 Feb 2020 16:47:53 -0600 Message-ID: Subject: Re: [cifs:for-next 10/11] fs/cifs/smb2pdu.c:1985:38: error: macro "memcmp" passed 18 arguments, but takes just 3 To: kbuild test robot Cc: CIFS , =?UTF-8?Q?Aur=C3=A9lien_Aptel?= Content-Type: text/plain; charset="UTF-8" Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org It compiled and tested ok. Is this warning a limitation of the kbuild robot? On Thu, Feb 6, 2020 at 4:26 PM kbuild test robot wrote: > > tree: git://git.samba.org/sfrench/cifs-2.6.git for-next > head: 58b322cfd219fd570d4fcc2e2eb8b5d945389d46 > commit: 3d9d8c48232a668ada5f680f70c8b3d366629ab6 [10/11] smb3: print warning once if posix context returned on open > config: m68k-multi_defconfig (attached as .config) > compiler: m68k-linux-gcc (GCC) 7.5.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 3d9d8c48232a668ada5f680f70c8b3d366629ab6 > # save the attached .config to linux build tree > GCC_VERSION=7.5.0 make.cross ARCH=m68k > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>): > > fs/cifs/smb2pdu.c: In function 'smb2_parse_contexts': > >> fs/cifs/smb2pdu.c:1985:38: error: macro "memcmp" passed 18 arguments, but takes just 3 > 0xDE, 0x96, 0x8B, 0xCD, 0x7C}, 16) == 0) > ^ > >> fs/cifs/smb2pdu.c:1983:8: error: 'memcmp' undeclared (first use in this function); did you mean 'memchr'? > if (memcmp(name, (char []) {0x93, 0xAD, 0x25, 0x50, > ^~~~~~ > memchr > fs/cifs/smb2pdu.c:1983:8: note: each undeclared identifier is reported only once for each function it appears in > > vim +/memcmp +1985 fs/cifs/smb2pdu.c > > 1951 > 1952 void > 1953 smb2_parse_contexts(struct TCP_Server_Info *server, > 1954 struct smb2_create_rsp *rsp, > 1955 unsigned int *epoch, char *lease_key, __u8 *oplock, > 1956 struct smb2_file_all_info *buf) > 1957 { > 1958 char *data_offset; > 1959 struct create_context *cc; > 1960 unsigned int next; > 1961 unsigned int remaining; > 1962 char *name; > 1963 > 1964 *oplock = 0; > 1965 data_offset = (char *)rsp + le32_to_cpu(rsp->CreateContextsOffset); > 1966 remaining = le32_to_cpu(rsp->CreateContextsLength); > 1967 cc = (struct create_context *)data_offset; > 1968 > 1969 /* Initialize inode number to 0 in case no valid data in qfid context */ > 1970 if (buf) > 1971 buf->IndexNumber = 0; > 1972 > 1973 while (remaining >= sizeof(struct create_context)) { > 1974 name = le16_to_cpu(cc->NameOffset) + (char *)cc; > 1975 if (le16_to_cpu(cc->NameLength) == 4 && > 1976 strncmp(name, SMB2_CREATE_REQUEST_LEASE, 4) == 0) > 1977 *oplock = server->ops->parse_lease_buf(cc, epoch, > 1978 lease_key); > 1979 else if (buf && (le16_to_cpu(cc->NameLength) == 4) && > 1980 strncmp(name, SMB2_CREATE_QUERY_ON_DISK_ID, 4) == 0) > 1981 parse_query_id_ctxt(cc, buf); > 1982 else if ((le16_to_cpu(cc->NameLength) == 16)) { > > 1983 if (memcmp(name, (char []) {0x93, 0xAD, 0x25, 0x50, > 1984 0x9C, 0xB4, 0x11, 0xE7, 0xB4, 0x23, 0x83, > > 1985 0xDE, 0x96, 0x8B, 0xCD, 0x7C}, 16) == 0) > 1986 parse_posix_ctxt(cc, NULL); > 1987 } > 1988 /* else { > 1989 cifs_dbg(FYI, "Context not matched with len %d\n", > 1990 le16_to_cpu(cc->NameLength)); > 1991 cifs_dump_mem("Cctxt name: ", name, 4); > 1992 } */ > 1993 > 1994 next = le32_to_cpu(cc->Next); > 1995 if (!next) > 1996 break; > 1997 remaining -= next; > 1998 cc = (struct create_context *)((char *)cc + next); > 1999 } > 2000 > 2001 if (rsp->OplockLevel != SMB2_OPLOCK_LEVEL_LEASE) > 2002 *oplock = rsp->OplockLevel; > 2003 > 2004 return; > 2005 } > 2006 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Thanks, Steve