From: Steve French <smfrench@gmail.com>
To: Baokun Li <libaokun1@huawei.com>
Cc: Steve French <sfrench@samba.org>,
CIFS <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
LKML <linux-kernel@vger.kernel.org>,
Wei Yongjun <weiyongjun1@huawei.com>,
YueHaibing <yuehaibing@huawei.com>,
yangjihong1@huawei.com, yukuai3@huawei.com
Subject: Re: [PATCH -next] cifs: fix doc warnings in cifs_dfs_ref.c
Date: Sun, 13 Jun 2021 18:35:30 -0500 [thread overview]
Message-ID: <CAH2r5mtOfwzNqTmuPhwejk2JBm6YFbF8LgPzyNsKwnrT0V4P2g@mail.gmail.com> (raw)
In-Reply-To: <20210610114817.3524037-1-libaokun1@huawei.com>
merged into cifs-2.6.git for-next
On Thu, Jun 10, 2021 at 6:39 AM Baokun Li <libaokun1@huawei.com> wrote:
>
> Add description for `cifs_compose_mount_options` to fix the W=1 warnings:
>
> fs/cifs/cifs_dfs_ref.c:139: warning: Function parameter or
> member 'devname' not described in 'cifs_compose_mount_options'
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> fs/cifs/cifs_dfs_ref.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/cifs_dfs_ref.c b/fs/cifs/cifs_dfs_ref.c
> index c87c37cf2914..ec57cdb1590f 100644
> --- a/fs/cifs/cifs_dfs_ref.c
> +++ b/fs/cifs/cifs_dfs_ref.c
> @@ -125,7 +125,7 @@ cifs_build_devname(char *nodename, const char *prepath)
> * @sb_mountdata: parent/root DFS mount options (template)
> * @fullpath: full path in UNC format
> * @ref: optional server's referral
> - *
> + * @devname: return the built cifs device name if passed pointer not NULL
> * creates mount options for submount based on template options sb_mountdata
> * and replacing unc,ip,prefixpath options with ones we've got form ref_unc.
> *
> --
> 2.31.1
>
--
Thanks,
Steve
prev parent reply other threads:[~2021-06-13 23:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 11:48 [PATCH -next] cifs: fix doc warnings in cifs_dfs_ref.c Baokun Li
2021-06-13 23:35 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5mtOfwzNqTmuPhwejk2JBm6YFbF8LgPzyNsKwnrT0V4P2g@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=libaokun1@huawei.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).