linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Ronnie Sahlberg <lsahlber@redhat.com>
Cc: linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: cifs: only compile with DES when building with SMB1 support
Date: Fri, 13 Aug 2021 15:12:37 -0500	[thread overview]
Message-ID: <CAH2r5mtdF6mik_E8yq9xO_G-5_kD81oy14W3BzFOWBtVOv=0uQ@mail.gmail.com> (raw)
In-Reply-To: <20210813195644.937810-1-lsahlber@redhat.com>

Goal of these patches makes sense.  Also will make it easier to build
without SMB1 in the future when required.

On Fri, Aug 13, 2021 at 2:57 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
>
> Steve, list
>
> These three patches moves smb1 and all functions that depend on DES
> into smb1ops.c and will optionally compile smb1ops.c iff SMB1 support
> is enabled (CONFIG_CIFS_ALLOW_INSECURE_LEGACY)
>
> Additionally, make CONFIG_CIFS_ALLOW_INSECURE_LEGACY depend on
> CONFIG_LIB_DES so that if the kernel is built without DES support
> we automatically disable the smb1 protocol.
>
>
> This allows to build a cifs module on a kernel where DES has been disabled.
>
>
>


-- 
Thanks,

Steve

  parent reply	other threads:[~2021-08-13 20:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 19:56 Ronnie Sahlberg
2021-08-13 19:56 ` [PATCH 1/3] cifs: only compile in smb1ops.c if we configure CIFS_ALLOW_INSECURE_LEGACY Ronnie Sahlberg
2021-08-13 19:56 ` [PATCH 2/3] cifs: move calc_lanman_hash to smb1ops.c Ronnie Sahlberg
2021-08-14  2:08   ` kernel test robot
2021-08-14 19:45   ` kernel test robot
2021-08-13 19:56 ` [PATCH 3/3] cifs: move functions that depend on DES to smp1ops.c Ronnie Sahlberg
2021-08-13 20:12 ` Steve French [this message]
2021-08-13 20:13 ` cifs: only compile with DES when building with SMB1 support Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH2r5mtdF6mik_E8yq9xO_G-5_kD81oy14W3BzFOWBtVOv=0uQ@mail.gmail.com' \
    --to=smfrench@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=lsahlber@redhat.com \
    --subject='Re: cifs: only compile with DES when building with SMB1 support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).