linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][CIFS] Fix uninitialized variable in SMB1 POSIX query info error path
@ 2021-06-19 20:58 Steve French
  0 siblings, 0 replies; only message in thread
From: Steve French @ 2021-06-19 20:58 UTC (permalink / raw)
  To: CIFS

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

Fix SMB1 error path in cifs_get_file_info_unix.
We were trying to fill in uninitialized file attributes in the error case.

Addresses-Coverity: 139689 ("Uninitialized variables")


-- 
Thanks,

Steve

[-- Attachment #2: 0001-cifs-fix-SMB1-error-path-in-cifs_get_file_info_unix.patch --]
[-- Type: text/x-patch, Size: 922 bytes --]

From 209cef243f4548ded9349d5c699a73a2e48abd46 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Sat, 19 Jun 2021 15:53:18 -0500
Subject: [PATCH] cifs: fix SMB1 error path in cifs_get_file_info_unix

We were trying to fill in uninitialized file attributes in the error case.

Addresses-Coverity: 139689 ("Uninitialized variables")
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/inode.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 1dfa57982522..f60f068d33e8 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -367,9 +367,12 @@ cifs_get_file_info_unix(struct file *filp)
 	} else if (rc == -EREMOTE) {
 		cifs_create_dfs_fattr(&fattr, inode->i_sb);
 		rc = 0;
-	}
+	} else
+		goto cifs_gfiunix_out;
 
 	rc = cifs_fattr_to_inode(inode, &fattr);
+
+cifs_gfiunix_out:
 	free_xid(xid);
 	return rc;
 }
-- 
2.30.2


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-19 20:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-19 20:58 [PATCH][CIFS] Fix uninitialized variable in SMB1 POSIX query info error path Steve French

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).