From: Steve French <smfrench@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Steve French <sfrench@samba.org>,
Pavel Shilovsky <pshilov@microsoft.com>,
CIFS <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] smbfs_client: fix a sign extension bug
Date: Tue, 21 Sep 2021 20:52:13 -0500 [thread overview]
Message-ID: <CAH2r5muJ3zXHszfGUiPoqziVqQi2rRVX=NBtzqhJR0+X66GjSA@mail.gmail.com> (raw)
In-Reply-To: <20210921203335.GB16529@kili>
merged into cifs-2.6.git for-next
On Tue, Sep 21, 2021 at 4:13 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The problem is the mismatched types between "ctx->total_len" which is
> an unsigned int, "rc" which is an int, and "ctx->rc" which is a
> ssize_t. The code does:
>
> ctx->rc = (rc == 0) ? ctx->total_len : rc;
>
> We want "ctx->rc" to store the negative "rc" error code. But what
> happens is that "rc" is type promoted to a high unsigned int and
> 'ctx->rc" will store the high positive value instead of a negative
> value.
>
> The fix is to change "rc" from an int to a ssize_t.
>
> Fixes: c610c4b619e5 ("CIFS: Add asynchronous write support through kernel AIO")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/smbfs_client/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smbfs_client/file.c b/fs/smbfs_client/file.c
> index 4d10c9343890..7db9ddb3381f 100644
> --- a/fs/smbfs_client/file.c
> +++ b/fs/smbfs_client/file.c
> @@ -3111,7 +3111,7 @@ static void collect_uncached_write_data(struct cifs_aio_ctx *ctx)
> struct cifs_tcon *tcon;
> struct cifs_sb_info *cifs_sb;
> struct dentry *dentry = ctx->cfile->dentry;
> - int rc;
> + ssize_t rc;
>
> tcon = tlink_tcon(ctx->cfile->tlink);
> cifs_sb = CIFS_SB(dentry->d_sb);
> --
> 2.20.1
>
--
Thanks,
Steve
prev parent reply other threads:[~2021-09-22 1:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 20:33 [PATCH] smbfs_client: fix a sign extension bug Dan Carpenter
2021-09-22 1:52 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5muJ3zXHszfGUiPoqziVqQi2rRVX=NBtzqhJR0+X66GjSA@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pshilov@microsoft.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).