linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Shyam Prasad N <nspmangalore@gmail.com>
Cc: David Howells <dhowells@redhat.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: enable fscache usage even for files opened as rw
Date: Sun, 15 Aug 2021 22:38:29 -0500	[thread overview]
Message-ID: <CAH2r5muLbLWExEwmwT29KKQ=25kpm-qFnLLb8MqdQxRFPf79gA@mail.gmail.com> (raw)
In-Reply-To: <CANT5p=r5tE5VkQBG62K94fATeW4uGW7Q6_KcHj+5HsiKWoAD8g@mail.gmail.com>

Thoughts about the checkpatch warnings?

$ scripts/checkpatch.pl
~/Downloads/096eaae1544b9bc2b1df48613027bd46c629d406.patch
WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code
rather than BUG() or BUG_ON()
#156: FILE: fs/cifs/fscache.c:318:
+ BUG_ON(!cifsi->fscache);

WARNING: function definition argument 'struct inode *' should also
have an identifier name
#191: FILE: fs/cifs/fscache.h:58:
+extern void cifs_fscache_update_inode_cookie(struct inode *);

WARNING: function definition argument 'struct inode *' should also
have an identifier name
#196: FILE: fs/cifs/fscache.h:63:
+extern void __cifs_fscache_wait_on_page_write(struct inode *, struct page *);

WARNING: function definition argument 'struct page *' should also have
an identifier name
#196: FILE: fs/cifs/fscache.h:63:
+extern void __cifs_fscache_wait_on_page_write(struct inode *, struct page *);

On Tue, Aug 10, 2021 at 5:44 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> Hi Steve,
>
> The following patch enables fscache even for scenarios where files are
> opened in rw mode. Our current implementation only enables fscache
> when the file is opened O_RDONLY.
>
> https://github.com/sprasad-microsoft/smb3-kernel-client/pull/5
>
> Note that this patch can safely be backported. It still does not use
> netfs helper library.
> I'll be sending another patch with the netfs helper integration soon.
>
> --
> Regards,
> Shyam



-- 
Thanks,

Steve

      reply	other threads:[~2021-08-16  3:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 10:43 Shyam Prasad N
2021-08-16  3:38 ` Steve French [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH2r5muLbLWExEwmwT29KKQ=25kpm-qFnLLb8MqdQxRFPf79gA@mail.gmail.com' \
    --to=smfrench@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=nspmangalore@gmail.com \
    --subject='Re: [PATCH] cifs: enable fscache usage even for files opened as rw' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).