[PATCH] cifs: enable fscache usage even for files opened as rw

[PATCH] cifs: enable fscache usage even for files opened as rw

[Shyam Prasad N]

Hi Steve,

The following patch enables fscache even for scenarios where files are
opened in rw mode. Our current implementation only enables fscache
when the file is opened O_RDONLY.

https://github.com/sprasad-microsoft/smb3-kernel-client/pull/5

Note that this patch can safely be backported. It still does not use
netfs helper library.
I'll be sending another patch with the netfs helper integration soon.

-- 
Regards,
Shyam

Re: [PATCH] cifs: enable fscache usage even for files opened as rw

[Steve French]

Thoughts about the checkpatch warnings?

$ scripts/checkpatch.pl
~/Downloads/096eaae1544b9bc2b1df48613027bd46c629d406.patch
WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code
rather than BUG() or BUG_ON()
#156: FILE: fs/cifs/fscache.c:318:
+ BUG_ON(!cifsi->fscache);

WARNING: function definition argument 'struct inode *' should also
have an identifier name
#191: FILE: fs/cifs/fscache.h:58:
+extern void cifs_fscache_update_inode_cookie(struct inode *);

WARNING: function definition argument 'struct inode *' should also
have an identifier name
#196: FILE: fs/cifs/fscache.h:63:
+extern void __cifs_fscache_wait_on_page_write(struct inode *, struct page *);

WARNING: function definition argument 'struct page *' should also have
an identifier name
#196: FILE: fs/cifs/fscache.h:63:
+extern void __cifs_fscache_wait_on_page_write(struct inode *, struct page *);

On Tue, Aug 10, 2021 at 5:44 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> Hi Steve,
>
> The following patch enables fscache even for scenarios where files are
> opened in rw mode. Our current implementation only enables fscache
> when the file is opened O_RDONLY.
>
> https://github.com/sprasad-microsoft/smb3-kernel-client/pull/5
>
> Note that this patch can safely be backported. It still does not use
> netfs helper library.
> I'll be sending another patch with the netfs helper integration soon.
>
> --
> Regards,
> Shyam



-- 
Thanks,

Steve