linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Ronnie Sahlberg <lsahlber@redhat.com>
Cc: linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH 0/3] cifs: create a common smb2pdu.h for client and server
Date: Thu, 2 Sep 2021 19:00:15 -0500	[thread overview]
Message-ID: <CAH2r5muXpRLNFPisye2NVHa1_G3U6BacZz75P9=kDmZH1Z9n7Q@mail.gmail.com> (raw)
In-Reply-To: <20210902233716.1923306-1-lsahlber@redhat.com>

The smbfsctl.h should also be easy to move ... but the obvious
question is whether "common" headers belong in "fs/cifs_common" or in
include/linux ...
(as e.g. nfs does with common headers between server and client)

On Thu, Sep 2, 2021 at 6:37 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
>
> Steve,
>
> Here is an initial set of patches that starts moving SMB2 PDU definitions
> from the client/server into a shared smb2pd.h file.
>
> It moves the command opcode values into cifs_common,
> it renames cifs smb2_sync_hdr to smb2_hdr to harmonize with ksmbd naming
> and it moves the tree connect and disconnect PDU definitions to the shared
> file.
>
>
>


-- 
Thanks,

Steve

  parent reply	other threads:[~2021-09-03  0:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 23:37 Ronnie Sahlberg
2021-09-02 23:37 ` [PATCH 1/3] cifs: create smb2pdu.h to be shared between cifs " Ronnie Sahlberg
2021-09-02 23:37 ` [PATCH 2/3] cifs: rename smb2_sync_hdr to smb2_hdr to harmonize naming with ksmbd Ronnie Sahlberg
2021-09-02 23:37 ` [PATCH 3/3] cifs: move smb2 tree_[dis]connect definitions to the shared cifs_common Ronnie Sahlberg
2021-09-03  0:00 ` Steve French [this message]
2021-09-03  3:01   ` [PATCH 0/3] cifs: create a common smb2pdu.h for client and server ronnie sahlberg
2021-09-03 16:53     ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH2r5muXpRLNFPisye2NVHa1_G3U6BacZz75P9=kDmZH1Z9n7Q@mail.gmail.com' \
    --to=smfrench@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=lsahlber@redhat.com \
    --subject='Re: [PATCH 0/3] cifs: create a common smb2pdu.h for client and server' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).