From: Steve French <firstname.lastname@example.org> To: Linus Torvalds <email@example.com> Cc: LKML <firstname.lastname@example.org>, CIFS <email@example.com>, ronnie sahlberg <firstname.lastname@example.org> Subject: Re: [GIT PULL] cifs/smb3 client fixes Date: Tue, 14 Sep 2021 16:21:36 -0500 [thread overview] Message-ID: <CAH2r5much4q6bETPPCbqmhb+ksrX=5RXu_fcNVNk8dHiqN+g2Q@mail.gmail.com> (raw) In-Reply-To: <CAH2r5mt72NYan9q8MR5H8cNkYzT4jn1ZM1f3jp5V-fDs2cyB-A@mail.gmail.com> On Tue, Aug 31, 2021 at 1:06 PM Steve French <email@example.com> wrote: > On Tue, Aug 31, 2021 at 12:43 PM Linus Torvalds > <firstname.lastname@example.org> wrote: > > > > On Tue, Aug 31, 2021 at 10:09 AM Steve French <email@example.com> wrote: <snip> > > I'm ok with directory renames, git handles it all well enough that the > > pain should be fairly minimal. > > > > I'd ask for that to be done during a fairly calm cycle, though, when > > there isn't a lot pending, so that any rename conflicts will be > > minimized. <snip> > > > Do you have any objections to me renaming the client's source > > > directory to "fs/smb3" (or fs/smb) and fs/smb3_common ...? > > > > So no objections to the rename per se, but can we please use a more > > specific name that is *not* tainted by history? > > > > I'll throw out two suggestions, but they are just that: (a) "smbfs" or > > (b) "smb-client". Due to git history for fs/smbfs directory (from many, many years ago) rename to "fs/smbfs" could be more confusing. So alternative suggestion which I implemented was rename the source directory from fs/cifs to "fs/smbfs_client." I will send a P/R for that since it is fairly quiet right now. If you would prefer that we wait for a future release that is fine too, but seems like low risk now and might reduce future confusion in the future (to rename the source directory).
next prev parent reply other threads:[~2021-09-14 21:22 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-30 5:48 Steve French 2021-08-31 16:39 ` Linus Torvalds 2021-08-31 17:08 ` Steve French 2021-08-31 17:43 ` Linus Torvalds 2021-08-31 18:06 ` Steve French 2021-09-14 21:21 ` Steve French [this message] 2021-09-13 16:19 ` Fwd: " Steve French 2021-08-31 16:41 ` pr-tracker-bot 2021-09-18 19:54 Steve French 2021-09-20 23:32 ` pr-tracker-bot 2021-09-24 23:23 Steve French 2021-09-25 19:06 ` pr-tracker-bot 2021-11-06 13:49 Steve French 2021-11-06 23:50 ` pr-tracker-bot 2021-12-10 20:41 Steve French 2021-12-11 1:38 ` pr-tracker-bot 2022-02-04 6:08 Steve French 2022-02-04 17:58 ` pr-tracker-bot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAH2r5much4q6bETPPCbqmhb+ksrX=5RXu_fcNVNk8dHiqN+g2Q@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [GIT PULL] cifs/smb3 client fixes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).