From: Steve French <smfrench@gmail.com>
To: "Aurélien Aptel" <aaptel@suse.com>
Cc: Paulo Alcantara <pc@cjr.nz>, CIFS <linux-cifs@vger.kernel.org>,
Pavel Shilovsky <piastryyy@gmail.com>
Subject: Re: [PATCH cifs-utils] mount.cifs: handle multiple ip addresses per hostname
Date: Tue, 11 May 2021 13:06:48 -0500 [thread overview]
Message-ID: <CAH2r5muebXV1_DMPG3d39xsP8JoW4U=2655vYCUqFbDihsbnLg@mail.gmail.com> (raw)
In-Reply-To: <8735uttb7s.fsf@suse.com>
On Tue, May 11, 2021 at 12:46 PM Aurélien Aptel <aaptel@suse.com> wrote:
>
>
> I would put in the commit msg that this requires recent kernel.
>
> We should probably merge kernel code first so we can reference it here
> in the commit msg, and say in the man page when did the kernel change.
>
> There can be cases where cifs-utils is more recent than kernel and
> mount.cifs will pass all the ip instead of trying them before passing
> the good one to the kernel but since it's an old kernel it won't try
> them all. We could add an option to enable new behavior or check the
> kernel version from within mount.cifs.. thoughts?
We could at least warn on older cifs.ko (which would be unlikely to
work unless someone backported features but didn't backport the
updated version #) by checking for the version number (2.32? 2.33?)
"cat /proc/fs/cifs/DebugData | grep Version" shows the version number
easily info (there are other ways to retrieve it as well)
--
Thanks,
Steve
next prev parent reply other threads:[~2021-05-11 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 16:39 [PATCH cifs-utils] mount.cifs: handle multiple ip addresses per hostname Paulo Alcantara
2021-05-11 17:46 ` Aurélien Aptel
2021-05-11 18:06 ` Steve French [this message]
2021-05-11 18:20 ` Paulo Alcantara
2021-07-08 23:00 ` Pavel Shilovsky
2021-07-09 14:50 ` Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5muebXV1_DMPG3d39xsP8JoW4U=2655vYCUqFbDihsbnLg@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@cjr.nz \
--cc=piastryyy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).