From: Steve French <smfrench@gmail.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Aurélien Aptel" <aaptel@suse.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Steve French" <sfrench@samba.org>,
CIFS <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] cifs: cifspdu.h: Replace one-element array with flexible-array member
Date: Thu, 8 Apr 2021 23:23:06 -0500 [thread overview]
Message-ID: <CAH2r5muf-y5XDyickz9mEw7kTVSjKvK+4AspSPsySbY9ucix8w@mail.gmail.com> (raw)
In-Reply-To: <4def044f-4529-9e73-6d01-1a9751f6b09a@embeddedor.com>
merged into cifs-2.6.git for-next
On Fri, Mar 26, 2021 at 12:02 PM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
>
>
> On 3/26/21 10:54, Aurélien Aptel wrote:
> > "Gustavo A. R. Silva" <gustavoars@kernel.org> writes:
> >> There is a regular need in the kernel to provide a way to declare having
> >> a dynamically sized set of trailing elements in a structure. Kernel code
> >> should always use “flexible array members”[1] for these cases. The older
> >> style of one-element or zero-length arrays should no longer be used[2].
> >
> > I've checked the usages of the struct, looks OK (we don't allocate it
> > directly, we use memory from the small/big buff pools).
>
> Awesome. :)
>
> > Reviewed-by: Aurelien Aptel <aaptel@suse.com>
>
> Thank you, Aurelien.
> --
> Gustavo
--
Thanks,
Steve
next prev parent reply other threads:[~2021-04-09 4:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 1:11 [PATCH][next] cifs: cifspdu.h: Replace one-element array with flexible-array member Gustavo A. R. Silva
2021-03-26 15:54 ` Aurélien Aptel
2021-03-26 15:13 ` Gustavo A. R. Silva
2021-04-09 4:23 ` Steve French [this message]
2021-04-09 7:06 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5muf-y5XDyickz9mEw7kTVSjKvK+4AspSPsySbY9ucix8w@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=aaptel@suse.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).