linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: "Aurélien Aptel" <aaptel@suse.com>
Cc: Shyam Prasad N <nspmangalore@gmail.com>,
	CIFS <linux-cifs@vger.kernel.org>
Subject: Re: 2 error cases in sid_to_id are ignored
Date: Tue, 22 Jun 2021 14:05:41 -0500	[thread overview]
Message-ID: <CAH2r5muhe-2GNe0MgVvKy=X+wCxN5E2_tXT8wN8AKXCjanwqgg@mail.gmail.com> (raw)
In-Reply-To: <87r1guqk2d.fsf@suse.com>

Should we make the error noisier?

Perhaps we could add a dynamic trace point for failed id mappings so
we could debug these if problems with the upcall, malformed ids/SIDs
etc?

On Tue, Jun 22, 2021 at 5:18 AM Aurélien Aptel <aaptel@suse.com> wrote:
>
> Steve French <smfrench@gmail.com> writes:
> > Any thoughts on whether it would be better to return the errors, or
> > continue the current strategy of simply using the default uid/gid for
> > the mount and returning 0 (and removing the two places above where we
> > set rc to non zero values, since rc will be overwritten with 0)?
>
> My opinion: I think best-effort would be better, so returning things as
> default uid/gid (or possibly root).
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
>


-- 
Thanks,

Steve

  reply	other threads:[~2021-06-22 19:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 20:57 Steve French
2021-06-22 10:18 ` Aurélien Aptel
2021-06-22 19:05   ` Steve French [this message]
2021-06-22 19:16     ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH2r5muhe-2GNe0MgVvKy=X+wCxN5E2_tXT8wN8AKXCjanwqgg@mail.gmail.com' \
    --to=smfrench@gmail.com \
    --cc=aaptel@suse.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=nspmangalore@gmail.com \
    --subject='Re: 2 error cases in sid_to_id are ignored' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).