From: Steve French <smfrench@gmail.com>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Steve French <sfrench@samba.org>,
CIFS <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
LKML <linux-kernel@vger.kernel.org>,
kael_w@yeah.net
Subject: Re: [PATCH] fs: cifs: Remove repeated struct declaration
Date: Thu, 8 Apr 2021 22:53:06 -0500 [thread overview]
Message-ID: <CAH2r5muuziT__TfpFWgeQkXRLkE0ZmekAXLBVwxwOAmCAFrh2w@mail.gmail.com> (raw)
In-Reply-To: <20210409024639.1092204-1-wanjiabing@vivo.com>
merged into cifs-2.6.git for-next
On Thu, Apr 8, 2021 at 9:47 PM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> struct cifs_writedata is declared twice.
> One is declared at 209th line.
> And struct cifs_writedata is defined blew.
> The declaration hear is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> fs/cifs/cifsglob.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index ec824ab8c5ca..5ec60745034e 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -1316,8 +1316,6 @@ struct cifs_readdata {
> struct page **pages;
> };
>
> -struct cifs_writedata;
> -
> /* asynchronous write support */
> struct cifs_writedata {
> struct kref refcount;
> --
> 2.25.1
>
--
Thanks,
Steve
prev parent reply other threads:[~2021-04-09 3:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 2:46 [PATCH] fs: cifs: Remove repeated struct declaration Wan Jiabing
2021-04-09 3:53 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5muuziT__TfpFWgeQkXRLkE0ZmekAXLBVwxwOAmCAFrh2w@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=kael_w@yeah.net \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).