* [PATCH] cifs: Fix return value in __update_cache_entry
@ 2020-01-17 2:21 YueHaibing
2020-01-17 7:53 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-01-17 2:21 UTC (permalink / raw)
To: stfrench, pc; +Cc: linux-cifs, samba-technical, linux-kernel, YueHaibing
copy_ref_data() may return error, it should be
returned to upstream caller.
Fixes: 03535b72873b ("cifs: Avoid doing network I/O while holding cache lock")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/cifs/dfs_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
index 5617efe..03cfaa1 100644
--- a/fs/cifs/dfs_cache.c
+++ b/fs/cifs/dfs_cache.c
@@ -593,7 +593,7 @@ static int __update_cache_entry(const char *path,
kfree(th);
- return 0;
+ return rc;
}
static int get_dfs_referral(const unsigned int xid, struct cifs_ses *ses,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] cifs: Fix return value in __update_cache_entry
2020-01-17 2:21 [PATCH] cifs: Fix return value in __update_cache_entry YueHaibing
@ 2020-01-17 7:53 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2020-01-17 7:53 UTC (permalink / raw)
To: YueHaibing; +Cc: Steve French, Paulo Alcantara, CIFS, samba-technical, LKML
merged into cifs-2.6.git for-next
On Thu, Jan 16, 2020 at 9:58 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> copy_ref_data() may return error, it should be
> returned to upstream caller.
>
> Fixes: 03535b72873b ("cifs: Avoid doing network I/O while holding cache lock")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/cifs/dfs_cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
> index 5617efe..03cfaa1 100644
> --- a/fs/cifs/dfs_cache.c
> +++ b/fs/cifs/dfs_cache.c
> @@ -593,7 +593,7 @@ static int __update_cache_entry(const char *path,
>
> kfree(th);
>
> - return 0;
> + return rc;
> }
>
> static int get_dfs_referral(const unsigned int xid, struct cifs_ses *ses,
> --
> 2.7.4
>
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-17 7:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 2:21 [PATCH] cifs: Fix return value in __update_cache_entry YueHaibing
2020-01-17 7:53 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).