linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Ronnie Sahlberg <lsahlber@redhat.com>
Cc: linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: use the correct max-length for dentry_path_raw()
Date: Mon, 9 Aug 2021 23:21:29 -0500	[thread overview]
Message-ID: <CAH2r5mv5WvNSjwG41vtSUhfSDdgUHu45OSdkv8rg4_nQ1T4TBA@mail.gmail.com> (raw)
In-Reply-To: <20210810023609.710993-1-lsahlber@redhat.com>

tentatively merged into cifs-2.6.git for-next pending testing

http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/765

On Mon, Aug 9, 2021 at 9:36 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
>
> RHBZ: 1972502
>
> PATH_MAX is 4096 but PAGE_SIZE can be >4096 on some architectures
> such as ppc and would thus write beyond the end of the actual object.
>
> CC: Stable <stable@vger.kernel.org>
> Suggested-by: Brian foster <bfoster@redhat.com>
> Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> ---
>  fs/cifs/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
> index 79402ca0ddfa..5f8a302ffcb2 100644
> --- a/fs/cifs/dir.c
> +++ b/fs/cifs/dir.c
> @@ -100,7 +100,7 @@ build_path_from_dentry_optional_prefix(struct dentry *direntry, void *page,
>         if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_USE_PREFIX_PATH)
>                 pplen = cifs_sb->prepath ? strlen(cifs_sb->prepath) + 1 : 0;
>
> -       s = dentry_path_raw(direntry, page, PAGE_SIZE);
> +       s = dentry_path_raw(direntry, page, PATH_MAX);
>         if (IS_ERR(s))
>                 return s;
>         if (!s[1])      // for root we want "", not "/"
> --
> 2.30.2
>


-- 
Thanks,

Steve

  reply	other threads:[~2021-08-10  4:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  2:36 Ronnie Sahlberg
2021-08-10  4:21 ` Steve French [this message]
2021-08-10  6:33 Ronnie Sahlberg
2021-08-10 14:44 ` Paulo Alcantara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH2r5mv5WvNSjwG41vtSUhfSDdgUHu45OSdkv8rg4_nQ1T4TBA@mail.gmail.com \
    --to=smfrench@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=lsahlber@redhat.com \
    --subject='Re: [PATCH] cifs: use the correct max-length for dentry_path_raw()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).