Re: Multichannel patches

[Steve French <smfrench@gmail.com>]

tentatively merged pending review and testing (after minor updates to
formatting in one patch)

buildbot run in progress on these 5 (and also includes Aurelien's small patch)

http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/665

On Fri, Jun 4, 2021 at 4:13 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> Thanks for the reviews.
>
> While rebasing older changes, I missed a single line during the
> channel add code, which had caused a regression.
> Fixed it and merged with the correct patch here:
> https://github.com/sprasad-microsoft/smb-kernel-client/pull/5
>
> I've also integrated Aurelien's comments into these patches.
> Also, I've a couple of minor patches here to fix fscache warnings for
> multichannel and to integrate new changes into DebugData.
> @Steve French Please use these new patches.
>
> @Paulo Alcantara That would be great if you can help testing my
> changes. Please test with these new changes.
> > The super is only used for providing cifs_sb_info::origin_fullpath as key to find the corresponding failover targets in referral cache.
> I'm wondering what would happen if there are multiple tcons to the
> same origin_fullpath (possibly in different sessions)?
> Also, doesn't failover targets apply to each channel under a session?
> Shouldn't we switch targets on reconnect of secondary channels too?
>
> On Wed, Jun 2, 2021 at 10:15 PM Paulo Alcantara <pc@cjr.nz> wrote:
> >
> > Shyam Prasad N <nspmangalore@gmail.com> writes:
> >
> > > P.S. There is a logic in cifs_reconnect to switch between the targets
> > > for the server. I don't think these changes will break the DFS
> > > scenario. The code will likely take effect only for when the primary
> > > channel reconnects (as DFS server entries are cached with super block
> > > as the key). Perhaps more changes will be needed there to also switch
> > > between the targets for individual channels (maybe use superblock +
> > > channel num as the key for caching entries?). Folks with better
> > > knowledge than me with this code may want to check on this?
> >
> > I don't think your changes would break it as well.  The super is only
> > used for providing cifs_sb_info::origin_fullpath as key to find the
> > corresponding failover targets in referral cache.
> >
> > I can help you testing your changes with some DFS+multichannel failover
> > scenarios.
>
>
>
> --
> Regards,
> Shyam



-- 
Thanks,

Steve