From: Steve French <smfrench@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: cifs_md4 convert to SPDX identifier
Date: Wed, 25 Aug 2021 15:53:38 -0500 [thread overview]
Message-ID: <CAH2r5mvDcO8aHfw8Do4jS=DDpsCE6P+SNjCguKDMuusBeA898w@mail.gmail.com> (raw)
In-Reply-To: <YSXgH2KobLW0JEjP@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
Removed the file name from the top of header comments as suggested.
On Wed, Aug 25, 2021 at 1:16 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Tue, Aug 24, 2021 at 12:15:05PM -0500, Steve French wrote:
> > - * fs/smb2/smb2maperror.c
> > + * fs/cifs/smb2maperror.c
>
>
> > /*
> > + * fs/cifs_common/cifs_md4.c
> > + *
>
> This is a good reminder on why putting the file name into the top of
> file comment is stupid. Just don't do it.
>
--
Thanks,
Steve
[-- Attachment #2: 0001-cifs-cifs_md4-convert-to-SPDX-identifier.patch --]
[-- Type: text/x-patch, Size: 1525 bytes --]
From 38f4910b8b26d3a940167f207bddfcc589310c8a Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Tue, 24 Aug 2021 12:07:46 -0500
Subject: [PATCH] cifs: cifs_md4 convert to SPDX identifier
Add SPDX license identifier and replace license boilerplate
for cifs_md4.c
Signed-off-by: Steve French <stfrench@microsoft.com>
---
fs/cifs/smb2maperror.c | 1 -
fs/cifs_common/cifs_md4.c | 6 +-----
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/fs/cifs/smb2maperror.c b/fs/cifs/smb2maperror.c
index cea39bcecbab..181514b8770d 100644
--- a/fs/cifs/smb2maperror.c
+++ b/fs/cifs/smb2maperror.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: LGPL-2.1
/*
- * fs/smb2/smb2maperror.c
*
* Functions which do error mapping of SMB2 status codes to POSIX errors
*
diff --git a/fs/cifs_common/cifs_md4.c b/fs/cifs_common/cifs_md4.c
index dbf9113b8600..50f78cfc6ce9 100644
--- a/fs/cifs_common/cifs_md4.c
+++ b/fs/cifs_common/cifs_md4.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* Cryptographic API.
*
@@ -14,11 +15,6 @@
* Copyright (c) 2002 David S. Miller (davem@redhat.com)
* Copyright (c) 2002 James Morris <jmorris@intercode.com.au>
*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
*/
#include <linux/init.h>
#include <linux/kernel.h>
--
2.30.2
prev parent reply other threads:[~2021-08-25 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 17:15 [PATCH] cifs: cifs_md4 convert to SPDX identifier Steve French
2021-08-25 6:15 ` Christoph Hellwig
2021-08-25 20:53 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5mvDcO8aHfw8Do4jS=DDpsCE6P+SNjCguKDMuusBeA898w@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=hch@infradead.org \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).