linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Shyam Prasad N <nspmangalore@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>
Subject: Re: bug in dumping server name in tracepoints
Date: Fri, 21 May 2021 13:37:47 -0500	[thread overview]
Message-ID: <CAH2r5mvDjfzsXyXH5Lj5qwZBW=AGgTVOfehn_vGXiF-hO8dX_A@mail.gmail.com> (raw)
In-Reply-To: <CANT5p=qtC9YXOSQimeU2DcjpR=ES0x_pp6Eb2CUm7y87CH0u3w@mail.gmail.com>

On Fri, May 21, 2021 at 2:52 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> Can you please verify with this patch?
>
> We missed using the variable length string macros in several
> tracepoints. Fixed them in this change.
>
> There's probably more useful macros that we can use to print
> others like flags etc. But I'll submit seperate patches for
> those at a future date.
>
> https://github.com/sprasad-microsoft/smb-kernel-client/commit/ce6399dd4f13cacc4ffdc41e07cde5cc88175f71.patch
> https://github.com/sprasad-microsoft/smb-kernel-client/pull/2
>
> Regards,
> Shyam

Yes - it works now

# trace-cmd show
# tracer: nop
#
# entries-in-buffer/entries-written: 1/1   #P:12
#
#                                _-----=> irqs-off
#                               / _----=> need-resched
#                              | / _---=> hardirq/softirq
#                              || / _--=> preempt-depth
#                              ||| /     delay
#           TASK-PID     CPU#  ||||   TIMESTAMP  FUNCTION
#              | |         |   ||||      |         |
           cifsd-226090  [000] .... 386914.150292: smb3_reconnect:
conn_id=0x1 server=localhost current_mid=26


> On Thu, May 20, 2021 at 11:41 PM Steve French <smfrench@gmail.com> wrote:
> >
> > Looks like we have a bug in how we dump server name in some
> > tracepoints e.g. see below:
> >
> > smfrench@smfrench-ThinkPad-P52:~/cifs-2.6$ sudo trace-cmd show
> > # tracer: nop
> > #
> > # entries-in-buffer/entries-written: 1/1   #P:12
> > #
> > #                                _-----=> irqs-off
> > #                               / _----=> need-resched
> > #                              | / _---=> hardirq/softirq
> > #                              || / _--=> preempt-depth
> > #                              ||| /     delay
> > #           TASK-PID     CPU#  ||||   TIMESTAMP  FUNCTION
> > #              | |         |   ||||      |         |
> >            cifsd-82671   [006] .... 298870.051187: smb3_reconnect:
> > conn_id=0x2 server=(0xffff950d5f6f6c00:localhost)[UNSAFE-MEMORY]
> > current_mid=3105
> >
> >
> > --
> > Thanks,
> >
> > Steve
>
>
>
> --
> Regards,
> Shyam



-- 
Thanks,

Steve

  reply	other threads:[~2021-05-21 18:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 18:11 bug in dumping server name in tracepoints Steve French
2021-05-21  7:52 ` Shyam Prasad N
2021-05-21 18:37   ` Steve French [this message]
2021-05-21 23:44     ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH2r5mvDjfzsXyXH5Lj5qwZBW=AGgTVOfehn_vGXiF-hO8dX_A@mail.gmail.com' \
    --to=smfrench@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=nspmangalore@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).