* [PATCH] fs/cifs: Assign boolean values to a bool variable
@ 2021-01-14 9:09 Jiapeng Zhong
2021-01-17 2:08 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Zhong @ 2021-01-14 9:09 UTC (permalink / raw)
To: sfrench; +Cc: linux-cifs, samba-technical, linux-kernel, Jiapeng Zhong
Fix the following coccicheck warnings:
./fs/cifs/connect.c:3386:2-21: WARNING: Assignment of 0/1 to
bool variable.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
---
fs/cifs/connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index b9df855..8fbb5ea 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2195,7 +2195,7 @@ static int match_tcon(struct cifs_tcon *tcon, struct smb3_fs_context *ctx)
if (ses->server->capabilities & SMB2_GLOBAL_CAP_DIRECTORY_LEASING)
tcon->nohandlecache = ctx->nohandlecache;
else
- tcon->nohandlecache = 1;
+ tcon->nohandlecache = true;
tcon->nodelete = ctx->nodelete;
tcon->local_lease = ctx->local_lease;
INIT_LIST_HEAD(&tcon->pending_opens);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/cifs: Assign boolean values to a bool variable
2021-01-14 9:09 [PATCH] fs/cifs: Assign boolean values to a bool variable Jiapeng Zhong
@ 2021-01-17 2:08 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2021-01-17 2:08 UTC (permalink / raw)
To: Jiapeng Zhong; +Cc: Steve French, CIFS, samba-technical, LKML
merged into cifs-2.6.git for-next
On Thu, Jan 14, 2021 at 3:11 AM Jiapeng Zhong
<abaci-bugfix@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./fs/cifs/connect.c:3386:2-21: WARNING: Assignment of 0/1 to
> bool variable.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
> fs/cifs/connect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index b9df855..8fbb5ea 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2195,7 +2195,7 @@ static int match_tcon(struct cifs_tcon *tcon, struct smb3_fs_context *ctx)
> if (ses->server->capabilities & SMB2_GLOBAL_CAP_DIRECTORY_LEASING)
> tcon->nohandlecache = ctx->nohandlecache;
> else
> - tcon->nohandlecache = 1;
> + tcon->nohandlecache = true;
> tcon->nodelete = ctx->nodelete;
> tcon->local_lease = ctx->local_lease;
> INIT_LIST_HEAD(&tcon->pending_opens);
> --
> 1.8.3.1
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-17 2:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-14 9:09 [PATCH] fs/cifs: Assign boolean values to a bool variable Jiapeng Zhong
2021-01-17 2:08 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).