linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: CIFS <linux-cifs@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>, Paulo Alcantara <pc@cjr.nz>
Cc: samba-technical <samba-technical@lists.samba.org>
Subject: Re: [PATCH] oid_registry: Add OIDs for missing Spnego auth mechanisms to Macs
Date: Fri, 20 Aug 2021 22:49:04 -0500	[thread overview]
Message-ID: <CAH2r5mvVHHgNcg1=YM25e7rK+LnXcvq0iTLW6Jf1BiP1XqoQDw@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mvxX6BqLvgWO18QE+rQsAZoAzopvu5S3fyy45a+Y-w_MQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]

Fixed a typo in the patch (missing ',').  Updated patch attached.


On Fri, Aug 20, 2021 at 6:18 PM Steve French <smfrench@gmail.com> wrote:
>
>  In testing mounts to Macs, noticed that the OIDS for some
>  GSSAPI/SPNEGO auth mechanisms sent by the server were not
>  recognized and were missing from the header.
>
>  Signed-off-by: Steve French <stfrench@microsoft.com>
>
> diff --git a/include/linux/oid_registry.h b/include/linux/oid_registry.h
> index 3d8db1f6a5db..2728842721bc 100644
> --- a/include/linux/oid_registry.h
> +++ b/include/linux/oid_registry.h
> @@ -70,6 +70,9 @@ enum OID {
>
>         OID_spnego,                     /* 1.3.6.1.5.5.2 */
>
> +       OID_IAKerb,                     /* 1.3.6.1.5.2.5 */
> +       OID_PKU2U                       /* 1.3.5.1.5.2.7 */
> +       OID_Scram,                      /* 1.3.6.1.5.5.14 */
>         OID_certAuthInfoAccess,         /* 1.3.6.1.5.5.7.1.1 */
>         OID_sha1,                       /* 1.3.14.3.2.26 */
>         OID_id_ansip384r1,              /* 1.3.132.0.34 */
> @@ -104,6 +107,10 @@ enum OID {
>         OID_authorityKeyIdentifier,     /* 2.5.29.35 */
>         OID_extKeyUsage,                /* 2.5.29.37 */
>
> +       /* Heimdal mechanisms */
> +       OID_NetlogonMechanism,          /* 1.2.752.43.14.2 */
> +       OID_appleLocalKdcSupported,     /* 1.2.752.43.14.3 */
> +
>         /* EC-RDSA */
>         OID_gostCPSignA,                /* 1.2.643.2.2.35.1 */
>         OID_gostCPSignB,                /* 1.2.643.2.2.35.2 */
>
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve

[-- Attachment #2: 0001-oid_registry-Add-OIDs-for-missing-Spnego-auth-mechan.patch --]
[-- Type: text/x-patch, Size: 1425 bytes --]

From 9d5ae34aa9cfaa03d205f4a7a268d5ee9b33c57e Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Fri, 20 Aug 2021 18:10:36 -0500
Subject: [PATCH] oid_registry: Add OIDs for missing Spnego auth mechanisms to
 Macs

In testing mounts to Macs, noticed that the OIDS for some
GSSAPI/SPNEGO auth mechanisms sent by the server were not
recognized and were missing from the header.

Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 include/linux/oid_registry.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/linux/oid_registry.h b/include/linux/oid_registry.h
index 3d8db1f6a5db..0f4a8903922a 100644
--- a/include/linux/oid_registry.h
+++ b/include/linux/oid_registry.h
@@ -70,6 +70,9 @@ enum OID {
 
 	OID_spnego,			/* 1.3.6.1.5.5.2 */
 
+	OID_IAKerb,			/* 1.3.6.1.5.2.5 */
+	OID_PKU2U,			/* 1.3.5.1.5.2.7 */
+	OID_Scram,			/* 1.3.6.1.5.5.14 */
 	OID_certAuthInfoAccess,		/* 1.3.6.1.5.5.7.1.1 */
 	OID_sha1,			/* 1.3.14.3.2.26 */
 	OID_id_ansip384r1,		/* 1.3.132.0.34 */
@@ -104,6 +107,10 @@ enum OID {
 	OID_authorityKeyIdentifier,	/* 2.5.29.35 */
 	OID_extKeyUsage,		/* 2.5.29.37 */
 
+	/* Heimdal mechanisms */
+	OID_NetlogonMechanism,		/* 1.2.752.43.14.2 */
+	OID_appleLocalKdcSupported,	/* 1.2.752.43.14.3 */
+
 	/* EC-RDSA */
 	OID_gostCPSignA,		/* 1.2.643.2.2.35.1 */
 	OID_gostCPSignB,		/* 1.2.643.2.2.35.2 */
-- 
2.30.2


      reply	other threads:[~2021-08-21  3:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 23:18 [PATCH] oid_registry: Add OIDs for missing Spnego auth mechanisms to Macs Steve French
2021-08-21  3:49 ` Steve French [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH2r5mvVHHgNcg1=YM25e7rK+LnXcvq0iTLW6Jf1BiP1XqoQDw@mail.gmail.com' \
    --to=smfrench@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pc@cjr.nz \
    --cc=samba-technical@lists.samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).