[GIT PULL] CIFS Fixes

[GIT PULL] CIFS Fixes

[Steve French]

Please pull the following changes since commit
bbd91626f71c1582301044f5942751eeb4ca98ba:

  Merge tag '5.14-rc-smb3-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2021-06-29 20:18:16 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.14-rc-smb3-fixes-part2

for you to fetch changes up to 4d069f6022e938bc51667da637f2483a37a77e19:

  cifs: update internal version number (2021-07-09 13:03:36 -0500)

----------------------------------------------------------------
13 cifs/smb3 fixes. Most are to address minor issues pointed out by
Coverity. Also includes a packet signing enhancement and a mount
improvement.

There is an important set of multichannel fixes still being tested
which is not included yet.

Regression test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/711
----------------------------------------------------------------
Paulo Alcantara (1):
      cifs: prevent NULL deref in cifs_compose_mount_options()

Ronnie Sahlberg (1):
      cifs: use helpers when parsing uid/gid mount options and validate them

Steve French (11):
      cifs: make locking consistent around the server session status
      cifs: clarify SMB1 code for UnixCreateHardLink
      CIFS: Clarify SMB1 code for UnixCreateSymLink
      CIFS: Clarify SMB1 code for UnixSetPathInfo
      smb3: fix typo in header file
      CIFS: Clarify SMB1 code for SetFileSize
      CIFS: Clarify SMB1 code for delete
      CIFS: Clarify SMB1 code for rename open file
      CIFS: Clarify SMB1 code for POSIX Lock
      SMB3.1.1: Add support for negotiating signing algorithm
      cifs: update internal version number

 fs/cifs/cifs_dfs_ref.c |  3 ++
 fs/cifs/cifsfs.c       |  4 +++
 fs/cifs/cifsfs.h       |  2 +-
 fs/cifs/cifsglob.h     |  6 +++-
 fs/cifs/cifspdu.h      |  1 +
 fs/cifs/cifssmb.c      | 24 ++++++++------
 fs/cifs/connect.c      |  5 +++
 fs/cifs/fs_context.c   | 24 +++++++++++---
 fs/cifs/fs_context.h   |  1 +
 fs/cifs/smb2pdu.c      | 85 ++++++++++++++++++++++++++++++++++++++++++++------
 fs/cifs/smb2pdu.h      |  7 +++--
 fs/cifs/transport.c    |  2 ++
 12 files changed, 135 insertions(+), 29 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] CIFS Fixes

[pr-tracker-bot]

The pull request you sent on Sat, 10 Jul 2021 12:22:09 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.14-rc-smb3-fixes-part2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/1e16624d7b4376797ede36e3c955375cf0f23298

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] cifs fixes

[pr-tracker-bot]

The pull request you sent on Tue, 9 Mar 2021 20:49:00 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-rc2-smb3

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d0df9aabefda4d0a64730087f939f53f91e29ee6

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] cifs fixes

[Steve French]

Please pull the following changes since commit
a38fd8748464831584a19438cbb3082b5a2dab15:

  Linux 5.12-rc2 (2021-03-05 17:33:41 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-rc2-smb3

for you to fetch changes up to 04ad69c342fc4de5bd23be9ef15ea7574fb1a87e:

  cifs: do not send close in compound create+close requests
(2021-03-08 21:23:22 -0600)

----------------------------------------------------------------
6 cifs/smb3 fixes, 3 for stable, including some important mulitchannel
crediting fixes, and fix for statfs error handling

Regression test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/524
----------------------------------------------------------------
Aurelien Aptel (2):
      cifs: fix credit accounting for extra channel
      cifs: ask for more credit on async read/write code paths

Paulo Alcantara (4):
      cifs: print MIDs in decimal notation
      cifs: change noisy error message to FYI
      cifs: return proper error code in statfs(2)
      cifs: do not send close in compound create+close requests

 fs/cifs/cifs_debug.c |  2 +-
 fs/cifs/cifsfs.c     |  2 +-
 fs/cifs/cifsglob.h   | 19 ++++++++++---------
 fs/cifs/connect.c    | 14 +++++++-------
 fs/cifs/sess.c       |  1 +
 fs/cifs/smb2inode.c  |  1 +
 fs/cifs/smb2misc.c   | 10 +++++-----
 fs/cifs/smb2ops.c    | 10 +++++-----
 fs/cifs/smb2pdu.c    |  6 ++----
 fs/cifs/smb2proto.h  |  3 +--
 fs/cifs/transport.c  |  4 ++--
 11 files changed, 36 insertions(+), 36 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] cifs fixes

[Stefan Metzmacher]

[-- Attachment #1.1: Type: text/plain, Size: 1243 bytes --]

Hi Linus,

>> Do you know about the Zen3 status, I was thinking to replace the system
>> by this one with AMD Ryzen 9 5950X:
> 
> I have heard nothing but good things about Zen3 so far (apart from
> apparently people complaining about availability), but it's only been
> out a few months, so obviously coverage is somewhat limited.
> 
> I wish AMD hadn't decimated their Linux team (several years ago), and
> they definitely had some embarrassing issues early on with Zen (apart
> from the Zen 1 stability issues, they've screwed up rdrand at least
> three times, iirc). But I've yet to hear of any Zen 3 issues, and I
> suspect I'll upgrade when Threadripper comes out (I've become quite
> spoiled by the build speeds of my Threadripper 3970X - the only thing
> I miss is the better 'perf' support from Intel PEBS).
> 
> Note that I'm not necessarily the person who would hear about any
> issues first, though, so take the above with a pinch of salt.

Thanks for the hints! While we're waiting for the Ryzen 9 5950X machine
to get ready, I upgraded the Ryzen Threadripper 2950X to a 5.10 kernel
and we didn't had a freeze yet again.

Do you think 5.10 would be good for the Ryzen 9 5950X too?

Thanks!
metze




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [GIT PULL] cifs fixes

[pr-tracker-bot]

The pull request you sent on Fri, 12 Feb 2021 12:15:57 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7989807dc0c95c4b787698eba10905a5baac42e8

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] cifs fixes

[Linus Torvalds]

On Fri, Feb 12, 2021 at 5:08 PM Stefan Metzmacher <metze@samba.org> wrote:
>
> > Zen 2 seems to have fixed things (knock wood - it's certainly working
> > for me), But many people obviously never saw any issues with Zen 1
> > either.
>
> Do you know about the Zen3 status, I was thinking to replace the system
> by this one with AMD Ryzen 9 5950X:

I have heard nothing but good things about Zen3 so far (apart from
apparently people complaining about availability), but it's only been
out a few months, so obviously coverage is somewhat limited.

I wish AMD hadn't decimated their Linux team (several years ago), and
they definitely had some embarrassing issues early on with Zen (apart
from the Zen 1 stability issues, they've screwed up rdrand at least
three times, iirc). But I've yet to hear of any Zen 3 issues, and I
suspect I'll upgrade when Threadripper comes out (I've become quite
spoiled by the build speeds of my Threadripper 3970X - the only thing
I miss is the better 'perf' support from Intel PEBS).

Note that I'm not necessarily the person who would hear about any
issues first, though, so take the above with a pinch of salt.

       Linus

Re: [GIT PULL] cifs fixes

[Stefan Metzmacher]

[-- Attachment #1.1: Type: text/plain, Size: 1398 bytes --]

Hi Linus,

>> The machine is running a 'AMD Ryzen Threadripper 2950X 16-Core Processor'
>> and is freezing without any trace every view days.
> 
> I don't think the first-gen Zen issues ever really got solved. There
> were multiple ones, with random segfaults for the early ones (but
> afaik those were fixed by an RMA process with AMD), but the "it
> randomly locks up" ones never had a satisfactory resolution afaik.
> 
> There were lots of random workarounds, but judging by your email:
> 
>> We played with various boot parameters (currently we're using
>> 'mem_encrypt=off rcu_nocbs=0-31 processor.max_cstate=1 idle=nomwait nomodeset consoleblank=0',
> 
> I suspect you've seen all the bugzilla threads on this issue (kernel
> bugzilla 196683 is probably the main one, but it was discussed
> elsewhere too).

I just found that one, I'll have a closer look at the details in the next days.

> I assume you've updated to latest BIOS and looked at various BIOS
> power management settings too?

No, but I'll have a look at that.

> Zen 2 seems to have fixed things (knock wood - it's certainly working
> for me), But many people obviously never saw any issues with Zen 1
> either.

Do you know about the Zen3 status, I was thinking to replace the system
by this one with AMD Ryzen 9 5950X:
https://www.hetzner.com/dedicated-rootserver/ax101

Thanks!
metze



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [GIT PULL] cifs fixes

[Linus Torvalds]

On Fri, Feb 12, 2021 at 4:26 PM Stefan Metzmacher <metze@samba.org> wrote:
>
> The machine is running a 'AMD Ryzen Threadripper 2950X 16-Core Processor'
> and is freezing without any trace every view days.

I don't think the first-gen Zen issues ever really got solved. There
were multiple ones, with random segfaults for the early ones (but
afaik those were fixed by an RMA process with AMD), but the "it
randomly locks up" ones never had a satisfactory resolution afaik.

There were lots of random workarounds, but judging by your email:

> We played with various boot parameters (currently we're using
> 'mem_encrypt=off rcu_nocbs=0-31 processor.max_cstate=1 idle=nomwait nomodeset consoleblank=0',

I suspect you've seen all the bugzilla threads on this issue (kernel
bugzilla 196683 is probably the main one, but it was discussed
elsewhere too).

I assume you've updated to latest BIOS and looked at various BIOS
power management settings too?

Zen 2 seems to have fixed things (knock wood - it's certainly working
for me), But many people obviously never saw any issues with Zen 1
either.

           Linus

Re: [GIT PULL] cifs fixes

[Stefan Metzmacher]

[-- Attachment #1.1: Type: text/plain, Size: 1039 bytes --]

Am 12.02.21 um 21:39 schrieb Steve French:
> Metze/Bjorn,
> Linus is right - samba.org is down for me (I also verified with JRA).
> Any ETA on when it gets back up?
> 
> On Fri, Feb 12, 2021 at 2:05 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> On Fri, Feb 12, 2021 at 10:16 AM Steve French <smfrench@gmail.com> wrote:
>>>
>>>   git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3
>>
>> It looks like git.samba.org is feeling very sick and is not answering.
>> Not git, not ping (but maybe icmp ping is blocked).
>>
>> Please give it a kick, or provide some other hosting mirror?


It's online again.

The machine is running a 'AMD Ryzen Threadripper 2950X 16-Core Processor'
and is freezing without any trace every view days.

We played with various boot parameters (currently we're using
'mem_encrypt=off rcu_nocbs=0-31 processor.max_cstate=1 idle=nomwait nomodeset consoleblank=0',
with the ubuntu 20.04 5.8 kernel, we also tried 5.4 before), but nothing seems to help.

metze



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [GIT PULL] cifs fixes

[Steve French]

The branch also was mirrored to github so could be pulled from there
if you prefer - see below (presumably the admins for samba.org, who
live in Germany, are not online - and so I am not sure when samba.org
servers will be restarted).

The following changes since commit 92bf22614b21a2706f4993b278017e437f7785b3:

  Linux 5.11-rc7 (2021-02-07 13:57:38 -0800)

are available in the Git repository at:

  git://github.com/smfrench/smb3-kernel.git tags/5.11-rc7-smb3-github

for you to fetch changes up to a738c93fb1c17e386a09304b517b1c6b2a6a5a8b:

  cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting
cifs_sb->prepath. (2021-02-11 11:08:32 -0600)

----------------------------------------------------------------
4 small smb3 fixes to the new mount API

----------------------------------------------------------------
Ronnie Sahlberg (3):
      cifs: fix dfs-links
      cifs: do not disable noperm if multiuser mount option is not provided
      cifs: In the new mount api we get the full devname as source=

Shyam Prasad N (1):
      cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

 fs/cifs/cifsfs.c     |  2 +-
 fs/cifs/connect.c    |  9 +++++++++
 fs/cifs/fs_context.c | 20 +++++++++++++++++---
 fs/cifs/fs_context.h |  1 +
 4 files changed, 28 insertions(+), 4 deletions(-)


On Fri, Feb 12, 2021 at 2:05 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Fri, Feb 12, 2021 at 10:16 AM Steve French <smfrench@gmail.com> wrote:
> >
> >   git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3
>
> It looks like git.samba.org is feeling very sick and is not answering.
> Not git, not ping (but maybe icmp ping is blocked).
>
> Please give it a kick, or provide some other hosting mirror?
>
>            Linus



--
Thanks,

Steve

Re: [GIT PULL] cifs fixes

[Steve French]

Metze/Bjorn,
Linus is right - samba.org is down for me (I also verified with JRA).
Any ETA on when it gets back up?

On Fri, Feb 12, 2021 at 2:05 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Fri, Feb 12, 2021 at 10:16 AM Steve French <smfrench@gmail.com> wrote:
> >
> >   git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3
>
> It looks like git.samba.org is feeling very sick and is not answering.
> Not git, not ping (but maybe icmp ping is blocked).
>
> Please give it a kick, or provide some other hosting mirror?
>
>            Linus



-- 
Thanks,

Steve

Re: [GIT PULL] cifs fixes

[Linus Torvalds]

On Fri, Feb 12, 2021 at 10:16 AM Steve French <smfrench@gmail.com> wrote:
>
>   git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3

It looks like git.samba.org is feeling very sick and is not answering.
Not git, not ping (but maybe icmp ping is blocked).

Please give it a kick, or provide some other hosting mirror?

           Linus

[GIT PULL] cifs fixes

[Steve French]

Please pull the following changes since commit
92bf22614b21a2706f4993b278017e437f7785b3:

  Linux 5.11-rc7 (2021-02-07 13:57:38 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3

for you to fetch changes up to a738c93fb1c17e386a09304b517b1c6b2a6a5a8b:

  cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting
cifs_sb->prepath. (2021-02-11 11:08:32 -0600)

----------------------------------------------------------------
4 small cifs fixes for the implementation of the new mount API (including
a particularly important one for DFS links) that were found in
additional testing
this week of additional DFS scenarios, and a user testing of an apache container
problem.

Regression test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/501
----------------------------------------------------------------
Ronnie Sahlberg (3):
      cifs: fix dfs-links
      cifs: do not disable noperm if multiuser mount option is not provided
      cifs: In the new mount api we get the full devname as source=

Shyam Prasad N (1):
      cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

 fs/cifs/cifsfs.c     |  2 +-
 fs/cifs/connect.c    |  9 +++++++++
 fs/cifs/fs_context.c | 20 +++++++++++++++++---
 fs/cifs/fs_context.h |  1 +
 4 files changed, 28 insertions(+), 4 deletions(-)


--
Thanks,

Steve

Re: [GIT PULL] cifs fixes

[pr-tracker-bot]

The pull request you sent on Sat, 6 Feb 2021 12:28:31 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc6-smb3

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/825b5991a46ef28a05a4646c8fe1ae5cef7c7828

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] cifs fixes

[Steve French]

Please pull the following changes since commit
1048ba83fb1c00cd24172e23e8263972f6b5d9ac:

  Linux 5.11-rc6 (2021-01-31 13:50:09 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc6-smb3

for you to fetch changes up to 21b200d091826a83aafc95d847139b2b0582f6d1:

  cifs: report error instead of invalid when revalidating a dentry
fails (2021-02-05 13:17:48 -0600)

----------------------------------------------------------------
3 small smb3 bug fixes for stable

Test results: http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/491
----------------------------------------------------------------
Aurelien Aptel (1):
      cifs: report error instead of invalid when revalidating a dentry fails

Gustavo A. R. Silva (1):
      smb3: Fix out-of-bounds bug in SMB2_negotiate()

Pavel Shilovsky (1):
      smb3: fix crediting for compounding when only one request in flight

 fs/cifs/dir.c       | 22 ++++++++++++++++++++--
 fs/cifs/smb2pdu.h   |  2 +-
 fs/cifs/transport.c | 18 +++++++++++++++---
 3 files changed, 36 insertions(+), 6 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] CIFS Fixes

[pr-tracker-bot]

The pull request you sent on Sat, 16 May 2020 21:45:57 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.7-rc5-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/5a9ffb954a3933d7867f4341684a23e008d6839b

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

[GIT PULL] CIFS Fixes

[Steve French]

Please pull the following changes since commit
dc56c5acd8505e1e7f776d62650f3850ad2ce8e7:

  Merge tag 'platform-drivers-x86-v5.7-2' of
git://git.infradead.org/linux-platform-drivers-x86 (2020-05-05
16:29:03 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.7-rc5-smb3-fixes

for you to fetch changes up to a48137996063d22ffba77e077425f49873856ca5:

  cifs: fix leaked reference on requeued write (2020-05-14 17:47:01 -0500)

----------------------------------------------------------------
three small cifs/smb3 fixes, two trivial fixes and one open refcount
leak fix marked for stable

Regression Test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/347
----------------------------------------------------------------
Adam McCoy (1):
      cifs: fix leaked reference on requeued write

Geert Uytterhoeven (1):
      CIFS: Spelling s/EACCESS/EACCES/

Steve French (1):
      cifs: Fix null pointer check in cifs_read

 fs/cifs/cifssmb.c | 2 +-
 fs/cifs/file.c    | 2 +-
 fs/cifs/inode.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)


-- 
Thanks,

Steve

[GIT PULL] CIFS Fixes

[Steve French]

A set of small cifs fixes fixing a memory leak, kernel oops, and
infinite loop (and some spotted by Coverity)

The following changes since commit 90a5a895cc8b284ac522757a01de15e36710c2b9:

  Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
(2015-03-23 10:16:13 -0700)

are available in the git repository at:


  git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to 4c5930e8056127e9a89bb7836bfa34318a89ab14:

  Fix warning (2015-04-01 00:01:47 -0500)

----------------------------------------------------------------
David Disseldorp (1):
      cifs: fix use-after-free bug in find_writable_file

Sachin Prabhu (1):
      cifs: smb2_clone_range() - exit on unhandled error

Steve French (8):
      Fix warning on uninitialized buftype
      Don't ignore errors on encrypting password in SMBTcon
      Fix dereference before null check warning
      Fix coverity warning
      Fix warning on impossible comparison
      CIFS: session servername can't be null
      Fix another dereference before null check warning
      Fix warning

Taesoo Kim (1):
      cifs: potential memory leaks when parsing mnt opts

 fs/cifs/cifsencrypt.c |  6 +++++-
 fs/cifs/connect.c     | 13 +++++++++++--
 fs/cifs/file.c        |  1 +
 fs/cifs/inode.c       |  2 ++
 fs/cifs/smb2misc.c    |  2 +-
 fs/cifs/smb2ops.c     |  3 ++-
 fs/cifs/smb2pdu.c     | 17 ++++++++++-------
 7 files changed, 32 insertions(+), 12 deletions(-)

-- 
Thanks,

Steve

[GIT PULL] CIFS Fixes

[Steve French]

Three small cifs fixes.  One fixes a hang under stress, and the other two are
security related.

The following changes since commit ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc:

  Linux 3.19-rc5 (2015-01-18 18:02:20 +1200)

are available in the git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to 7a1ceba071709d11271ebd921310b5a18404dd33:

  cifs: fix MUST SecurityFlags filtering (2015-01-26 19:38:26 -0600)

----------------------------------------------------------------
Giel van Schijndel (1):
      cifs: use memzero_explicit to clear stack buffer

Niklas Cassel (1):
      cifs: fix MUST SecurityFlags filtering

Sachin Prabhu (1):
      Complete oplock break jobs before closing file handle

 fs/cifs/cifs_debug.c | 6 ++++--
 fs/cifs/file.c       | 6 +++++-
 fs/cifs/smbencrypt.c | 2 +-
 3 files changed, 10 insertions(+), 4 deletions(-)

-- 
Thanks,

Steve

[GIT PULL] CIFS Fixes

[Steve French]

A set of three minor cifs fixes.

Please pull the following changes since commit
9ea18f8cab5f1c36cdd0f09717e35ceb48c36a87:

  Merge branch 'for-3.19/drivers' of git://git.kernel.dk/linux-block
(2014-12-13 14:22:26 -0800)

are available in the git repository at:


  git://git.samba.org/sfrench/cifs-2.6.git for-linus

for you to fetch changes up to 9e6d722f3d91c94f2a303d67ddd8fb1ca4c0d375:

  cifs: make new inode cache when file type is different (2014-12-22
14:16:21 -0600)

----------------------------------------------------------------
Kevin Cernekee (1):
      Fix signed/unsigned pointer warning

Nakajima Akira (1):
      cifs: make new inode cache when file type is different

Sachin Prabhu (1):
      Convert MessageID in smb2_hdr to LE

 fs/cifs/cifsglob.h      |  6 +++---
 fs/cifs/netmisc.c       | 12 +++++++-----
 fs/cifs/readdir.c       | 10 +++++++---
 fs/cifs/smb2misc.c      | 12 +++++++-----
 fs/cifs/smb2ops.c       |  3 ++-
 fs/cifs/smb2pdu.h       |  2 +-
 fs/cifs/smb2transport.c |  2 +-
 7 files changed, 28 insertions(+), 19 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] CIFS Fixes

[Steve French]

On Wed, Dec 10, 2014 at 5:40 PM, Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
> On Tue, Dec 9, 2014 at 7:18 AM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> Mostly cifs cleanup but also a few cifs fixes.
>
> Hmm. The diffstat is truncated:
>
>>  MAINTAINERS          |  3 +-
>>  fs/cifs/cifs_debug.c | 77 ++++++++++++++++++++++------------------------------
>>  fs/cifs/cifs_debug.h |  7 ++---
>>  fs/cifs/cifsfs.h     |  2 +-
>>  fs/cifs/connect.c    | 51 ++++++++++++----------------------
>>  fs/cifs/misc.c       | 32 ++--------------------
>>  fs/cifs/readdir.c    |  4 ---
>>  fs/cifs/sess.c       |  5 ++++
>>  fs/cifs/smb2ops.c    | 63 +++++++++++++++++++++++++++++++++++++++++-
>>  fs/cifs/smb2pdu.c    |  3 +-
>
> that is missing the last three lines that somehow got truncated
> (smb2pdu.h, transport.c and the files/lines changed summary line).
>
> My shortlog matches, so I'm taking it, but please be more careful.
>
>                    Linus

Looks like I made a cut-and-paste error.  Last two lines were

 fs/cifs/transport.c  |  4 +--
 12 files changed, 147 insertions(+), 123 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] CIFS Fixes

[Linus Torvalds]

On Tue, Dec 9, 2014 at 7:18 AM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Mostly cifs cleanup but also a few cifs fixes.

Hmm. The diffstat is truncated:

>  MAINTAINERS          |  3 +-
>  fs/cifs/cifs_debug.c | 77 ++++++++++++++++++++++------------------------------
>  fs/cifs/cifs_debug.h |  7 ++---
>  fs/cifs/cifsfs.h     |  2 +-
>  fs/cifs/connect.c    | 51 ++++++++++++----------------------
>  fs/cifs/misc.c       | 32 ++--------------------
>  fs/cifs/readdir.c    |  4 ---
>  fs/cifs/sess.c       |  5 ++++
>  fs/cifs/smb2ops.c    | 63 +++++++++++++++++++++++++++++++++++++++++-
>  fs/cifs/smb2pdu.c    |  3 +-

that is missing the last three lines that somehow got truncated
(smb2pdu.h, transport.c and the files/lines changed summary line).

My shortlog matches, so I'm taking it, but please be more careful.

                   Linus

[GIT PULL] CIFS Fixes

[Steve French]

Mostly cifs cleanup but also a few cifs fixes.   Please pull the
following changes since commit
b2776bf7149bddd1f4161f14f79520f17fc1d71d:

  Linux 3.18 (2014-12-07 14:21:05 -0800)

are available in the git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git for-linus

for you to fetch changes up to 15d987063348c93adb3e7c7378226abea03608e2:

  cifs: remove unneeded condition check (2014-12-07 23:43:10 -0600)

----------------------------------------------------------------
Andy Shevchenko (3):
      cifs: call strtobool instead of custom implementation
      cifs: convert to print_hex_dump() instead of custom implementation
      cifs: convert printk(LEVEL...) to pr_<level>

Kevin Cernekee (1):
      Update MAINTAINERS entry

Namjae Jeon (1):
      cifs: remove unneeded condition check

Sachin Prabhu (1):
      Set UID in sess_auth_rawntlmssp_authenticate too

Steve French (4):
      Add support for original fallocate
      Add missing defines for ACL query support
      decode_negTokenInit had wrong calling sequence
      Update modinfo cifs version for cifs.ko

 MAINTAINERS          |  3 +-
 fs/cifs/cifs_debug.c | 77 ++++++++++++++++++++++------------------------------
 fs/cifs/cifs_debug.h |  7 ++---
 fs/cifs/cifsfs.h     |  2 +-
 fs/cifs/connect.c    | 51 ++++++++++++----------------------
 fs/cifs/misc.c       | 32 ++--------------------
 fs/cifs/readdir.c    |  4 ---
 fs/cifs/sess.c       |  5 ++++
 fs/cifs/smb2ops.c    | 63 +++++++++++++++++++++++++++++++++++++++++-
 fs/cifs/smb2pdu.c    |  3 +-

-- 
Thanks,

Steve

[GIT PULL] CIFS Fixes

[Steve French]

Most important fixes in this set include three SMB3 fixes for stable
(including fix for possible kernel oops), and a workaround to allow
writes to Mac servers (only cifs dialect, not more current SMB2.1,
worked to Mac servers).   Also fallocate support added, and lease fix
from Jeff.

please pull the following changes since commit
c8d6637d0497d62093dbba0694c7b3a80b79bfe1:

  Merge tag 'modules-next-for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux (2014-08-10
21:31:58 -0700)

are available in the git repository at:


  git://git.samba.org/sfrench/cifs-2.6.git for-linus

for you to fetch changes up to 30175628bf7f521e9ee31ac98fa6d6fe7441a556:

  [SMB3] Enable fallocate -z support for SMB3 mounts (2014-08-17 18:16:40 -0500)

----------------------------------------------------------------
Jeff Layton (1):
      cifs: handle lease F_UNLCK requests properly

Pavel Shilovsky (2):
      CIFS: Fix SMB2 readdir error handling
      CIFS: Fix wrong directory attributes after rename

Steve French (8):
      Add missing definitions for CIFS File System Attributes
      Add sparse file support to SMB2/SMB3 mounts
      Cleanup sparse file support by creating worker function for it
      [CIFS] Workaround MacOS server problem with SMB2.1 write      response
      [CIFS] Possible null ptr deref in SMB2_tcon
      Incorrect error returned on setting file compressed on SMB2
      enable fallocate punch hole ("fallocate -p") for SMB3
      [SMB3] Enable fallocate -z support for SMB3 mounts

Vincent Stehlé (1):
      cifs: remove unused function cifs_oplock_break_wait

 fs/cifs/cifsfs.c       |  24 ++++++-
 fs/cifs/cifsglob.h     |   5 ++
 fs/cifs/cifspdu.h      |  23 +++++++
 fs/cifs/file.c         |   2 +-
 fs/cifs/inode.c        |   6 ++
 fs/cifs/misc.c         |   7 --
 fs/cifs/readdir.c      |   2 +-
 fs/cifs/smb1ops.c      |   7 ++
 fs/cifs/smb2maperror.c |   4 +-
 fs/cifs/smb2misc.c     |  17 ++++-
 fs/cifs/smb2ops.c      | 170 +++++++++++++++++++++++++++++++++++++++++++++++++
 fs/cifs/smb2pdu.c      |  16 +++--
 fs/cifs/smb2pdu.h      |   6 ++
 fs/cifs/smbfsctl.h     |   2 +-
 14 files changed, 269 insertions(+), 22 deletions(-)

-- 
Thanks,

Steve