linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	CIFS <linux-cifs@vger.kernel.org>
Subject: Re: Compile warning with current kernel and netfs
Date: Tue, 11 May 2021 14:41:05 -0500	[thread overview]
Message-ID: <CAH2r5mvkFBkVv7ur_VietcR7xCaRTFboD7+KdZ=MvkW6QC-KTw@mail.gmail.com> (raw)
In-Reply-To: <2509400.1620738202@warthog.procyon.org.uk>

On Tue, May 11, 2021 at 8:03 AM David Howells <dhowells@redhat.com> wrote:
>
> Steve French <smfrench@gmail.com> wrote:
>
> >   CC [M]  /home/smfrench/cifs-2.6/fs/cifs/fscache.o
> >   CHECK   /home/smfrench/cifs-2.6/fs/cifs/fscache.c
> > /home/smfrench/cifs-2.6/fs/cifs/fscache.c: note: in included file
> > (through include/linux/fscache.h,
> > /home/smfrench/cifs-2.6/fs/cifs/fscache.h):
> > ./include/linux/netfs.h:93:15: error: don't know how to apply mode to
> > unsigned int enum netfs_read_source
>
> Yeah - that's a bit the checker doesn't know how to support.  It's meant to
> make enum netfs_read_source-type struct members take less space.  I think gcc
> and clang are both fine with it.

Looks like sparse has been recently updated to fix this.  I pulled
from their git tree and rebuilt sparse to:

$ sparse --version
v0.6.3-341-g8af24329

and it works - no warnings  (other than the "Skipping BTF generation
one - which is unrelated, see https://lkml.org/lkml/2020/11/16/1452)

make: Entering directory '/usr/src/linux-headers-5.13.0-051300rc1-generic'
  CC [M]  /home/smfrench/cifs-2.6/fs/cifs/fscache.o
  CHECK   /home/smfrench/cifs-2.6/fs/cifs/fscache.c
  CC [M]  /home/smfrench/cifs-2.6/fs/cifs/cache.o
  CHECK   /home/smfrench/cifs-2.6/fs/cifs/cache.c
  LD [M]  /home/smfrench/cifs-2.6/fs/cifs/cifs.o
  MODPOST /home/smfrench/cifs-2.6/fs/cifs/Module.symvers
  LD [M]  /home/smfrench/cifs-2.6/fs/cifs/cifs.ko
  BTF [M] /home/smfrench/cifs-2.6/fs/cifs/cifs.ko

-- 
Thanks,

Steve

      reply	other threads:[~2021-05-11 19:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  2:01 Compile warning with current kernel and netfs Steve French
2021-05-11  2:07 ` Matthew Wilcox
2021-05-11  3:28   ` Steve French
2021-05-11  3:30 ` Steve French
2021-05-11 13:03 ` David Howells
2021-05-11 19:41   ` Steve French [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH2r5mvkFBkVv7ur_VietcR7xCaRTFboD7+KdZ=MvkW6QC-KTw@mail.gmail.com' \
    --to=smfrench@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).