From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F85DC34056 for ; Wed, 19 Feb 2020 19:07:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 348C820801 for ; Wed, 19 Feb 2020 19:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582139269; bh=K+l4PwzbcGcfT9N6LvjaNpSxXm+P598rAuw+Hp3l4js=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=KfxwhN7B6wft2y+N89owoDwQqR7dBFXxDMn+Mq27Iw2ULN4DChThZQkj5pQj8M6ak Do9H2f1LVizUnozpQAjbqsQNbhfKuoA3zTV9604UbKSGQ9YyJMM935asu4oFybVW/7 d3CCILdeprZ6zlAwZceuUQQQDDXs+MIEXWGLcD/0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726735AbgBSTHt (ORCPT ); Wed, 19 Feb 2020 14:07:49 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:40280 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726613AbgBSTHs (ORCPT ); Wed, 19 Feb 2020 14:07:48 -0500 Received: by mail-lf1-f68.google.com with SMTP id c23so994323lfi.7 for ; Wed, 19 Feb 2020 11:07:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PW7lNRLaUwWMkxjmDviGmCx98DZMFUxSA3+XY1xBUHc=; b=Hx1j/CCXthRsFcYUkCqUCZKHuALKrv53PhNO0/eSPdI55ETBuvMT4Bzt7Qa//aT+Xq pbz3LbAT0K7mf2O2wl4T+6nDRq33OiFGxtJRkEnoPAzmD/q8ILz+w8fB+i5OEbDM4aTv V5D7jcX/IJAfFXSwG3AgccJqFA6k9pBx+DkqY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PW7lNRLaUwWMkxjmDviGmCx98DZMFUxSA3+XY1xBUHc=; b=D/ca+XBae4DueBZ0AF6spQpd93L69pQPzP8UemKGzoR7pge3x94PW9EA/k1nNKNZtw IcL13LUU1VX61Knp+NhSJyXZt3yHg21RyaexUi08EsCFtbXNN1wtzSGkBfReXYHEWLaN c8s+XEahDSct9V5Lf6gDSNCQt6x9M5xZjiKrRU169sLjpcyY/BBQ2nsc1Q/FWHf7Hagl yA90j5x2LQRZb4QYVIf3GftGG8jNqGkrPBINtz2KLmCv0yxmQdEdk4t6UOUjmBe6+w50 E3PRxEDaD76MIWtvBDzLEIr2s8qP64x1Deo4fXa2hlDSsNWoFKiEHNVdY1qygUfr+Fxn yKRQ== X-Gm-Message-State: APjAAAXuxXqyeSwYLOAI1VIrV2JWMoyMlqSP73WuLG0FtPmVolemjyLI kn8kSMJ9dJrrv3GyYM7qLcCZN2AWNtY= X-Google-Smtp-Source: APXvYqxxhX0QBxaeGSJQISkovRAt4DEhXeRFq0105JVoNa1Tp2dY1PYo/gE2DhxyOmN1qz83MhjoFA== X-Received: by 2002:a19:4cc6:: with SMTP id z189mr13754462lfa.171.1582139266231; Wed, 19 Feb 2020 11:07:46 -0800 (PST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id t27sm330186ljd.26.2020.02.19.11.07.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2020 11:07:45 -0800 (PST) Received: by mail-lf1-f45.google.com with SMTP id c23so994251lfi.7 for ; Wed, 19 Feb 2020 11:07:44 -0800 (PST) X-Received: by 2002:a05:6512:687:: with SMTP id t7mr14685091lfe.30.1582139264476; Wed, 19 Feb 2020 11:07:44 -0800 (PST) MIME-Version: 1.0 References: <158212290024.224464.862376690360037918.stgit@warthog.procyon.org.uk> <227117.1582124888@warthog.procyon.org.uk> <241568.1582134931@warthog.procyon.org.uk> In-Reply-To: From: Linus Torvalds Date: Wed, 19 Feb 2020 11:07:28 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH] vfs: syscalls: Add create_automount() and remove_automount() To: David Howells Cc: Geert Uytterhoeven , Al Viro , coda@cs.cmu.edu, linux-afs@lists.infradead.org, CIFS , "open list:NFS, SUNRPC, AND..." , linux-btrfs , Linux FS Devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Wed, Feb 19, 2020 at 10:55 AM Linus Torvalds wrote: > > Why don't you just use mkdir with S_ISVTX set, or something like that? Actually, since this is apparently a different filetype, the _logical_ thing to do is to use "mknod()". Yes, yes, it will require a new case (and maybe a per-filesystem callback or a flag or something) in "may_mknod()" and "do_mknodat()" to let those new kinds through, but it sounds like mknod() is actually what you're doing. You presumably need a new type _anyway_ for stat() and/or the filldir d_type field. Or do you always want to make it look exactly like a directory to all user space? Linus