linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namjae Jeon <linkinjeon@kernel.org>
To: Marios Makassikis <mmakassikis@freebox.fr>
Cc: linux-cifs@vger.kernel.org
Subject: Re: [PATCH] ksmbd: do not call kvmalloc() with __GFP_NORETRY | __GFP_NO_WARN
Date: Sat, 25 Mar 2023 17:35:44 +0900	[thread overview]
Message-ID: <CAKYAXd-Uffg4b=-tWVE+a8xyDUVv13V2VqyNDhsUzQAVD02x3Q@mail.gmail.com> (raw)
In-Reply-To: <20230316134043.1824345-1-mmakassikis@freebox.fr>

2023-03-16 22:40 GMT+09:00, Marios Makassikis <mmakassikis@freebox.fr>:
> Commit 83dcedd5540 ("ksmbd: fix infinite loop in
> ksmbd_conn_handler_loop()"),
> changes GFP modifiers passed to kvmalloc(). However, the latter calls
> kvmalloc_node() which does not support __GFP_NORETRY.
>
> Signed-off-by: Marios Makassikis <mmakassikis@freebox.fr>
This patch fix generic/551 test. I will directly update the patch description.

Acked-by: Namjae Jeon <linkinjeon@kernel.org>

Thanks.

> ---
>  fs/ksmbd/connection.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/ksmbd/connection.c b/fs/ksmbd/connection.c
> index 5b10b03800c1..54e077597f4e 100644
> --- a/fs/ksmbd/connection.c
> +++ b/fs/ksmbd/connection.c
> @@ -329,10 +329,7 @@ int ksmbd_conn_handler_loop(void *p)
>
>  		/* 4 for rfc1002 length field */
>  		size = pdu_size + 4;
> -		conn->request_buf = kvmalloc(size,
> -					     GFP_KERNEL |
> -					     __GFP_NOWARN |
> -					     __GFP_NORETRY);
> +		conn->request_buf = kvmalloc(size, GFP_KERNEL);
>  		if (!conn->request_buf)
>  			break;
>
> --
> 2.34.1
>
>

      reply	other threads:[~2023-03-25  8:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 13:40 [PATCH] ksmbd: do not call kvmalloc() with __GFP_NORETRY | __GFP_NO_WARN Marios Makassikis
2023-03-25  8:35 ` Namjae Jeon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKYAXd-Uffg4b=-tWVE+a8xyDUVv13V2VqyNDhsUzQAVD02x3Q@mail.gmail.com' \
    --to=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=mmakassikis@freebox.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).