From: Namjae Jeon <linkinjeon@kernel.org> To: Christian Brauner <brauner@kernel.org> Cc: Steve French <stfrench@microsoft.com>, Christoph Hellwig <hch@infradead.org>, Namjae Jeon <namjae.jeon@samsung.com>, linux-cifs@vger.kernel.org, Hyunchul Lee <hyc.lee@gmail.com>, Sergey Senozhatsky <senozhatsky@chromium.org>, Christian Brauner <christian.brauner@ubuntu.com> Subject: Re: [PATCH 06/11] ksmbd: fix subauth 0 handling in sid_to_id() Date: Tue, 24 Aug 2021 17:13:01 +0900 [thread overview] Message-ID: <CAKYAXd86gaPoYJJHW6STdHhN282p5JFdr-xWwdvgv4HobFOBUg@mail.gmail.com> (raw) In-Reply-To: <20210823151357.471691-7-brauner@kernel.org> 2021-08-24 0:13 GMT+09:00, Christian Brauner <brauner@kernel.org>: > From: Christian Brauner <christian.brauner@ubuntu.com> > > It's not obvious why subauth 0 would be excluded from translation. This > would lead to wrong results whenever a non-identity idmapping is used. > > Cc: Steve French <stfrench@microsoft.com> > Cc: Christoph Hellwig <hch@infradead.org> > Cc: Namjae Jeon <namjae.jeon@samsung.com> > Cc: Hyunchul Lee <hyc.lee@gmail.com> > Cc: Sergey Senozhatsky <senozhatsky@chromium.org> > Cc: linux-cifs@vger.kernel.org > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> > --- > fs/ksmbd/smbacl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ksmbd/smbacl.c b/fs/ksmbd/smbacl.c > index 3307ca776eb1..0d269b28f163 100644 > --- a/fs/ksmbd/smbacl.c > +++ b/fs/ksmbd/smbacl.c > @@ -274,7 +274,7 @@ static int sid_to_id(struct user_namespace *user_ns, > uid_t id; > > id = le32_to_cpu(psid->sub_auth[psid->num_subauth - 1]); > - if (id > 0) { > + if (id >= 0) { > uid = make_kuid(user_ns, id); > if (uid_valid(uid) && kuid_has_mapping(user_ns, uid)) { > fattr->cf_uid = uid; > @@ -286,9 +286,9 @@ static int sid_to_id(struct user_namespace *user_ns, > gid_t id; > > id = le32_to_cpu(psid->sub_auth[psid->num_subauth - 1]); > - if (id > 0) { > gid = make_kgid(user_ns, id); > if (gid_valid(gid) && kgid_has_mapping(user_ns, gid)) { > + if (id >= 0) { Checkpatch.pl give warning messages like the following : WARNING: suspect code indent for conditional statements (24, 16) #110: FILE: fs/ksmbd/smbacl.c:290: if (gid_valid(gid) && kgid_has_mapping(user_ns, gid)) { + if (id >= 0) { WARNING: suspect code indent for conditional statements (16, 32) #111: FILE: fs/ksmbd/smbacl.c:291: + if (id >= 0) { fattr->cf_gid = gid; With 7th patch, it shouldn't be a problem, but this patch itself seems to have a problem. I will directly update it like this if you don't mind : id = le32_to_cpu(psid->sub_auth[psid->num_subauth - 1]); - if (id > 0) { + if (id >= 0) { gid = make_kgid(user_ns, id); if (gid_valid(gid) && kgid_has_mapping(user_ns, gid)) { fattr->cf_gid = gid; rc = 0; } Thanks! fattr->cf_gid = gid; > rc = 0; > } > -- > 2.30.2 > >
next prev parent reply other threads:[~2021-08-24 8:13 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20210823030840epcas1p24b226d445a683012925efd81a72ecb6d@epcas1p2.samsung.com> 2021-08-23 2:58 ` [PATCH v8 00/13] ksmbd: introduce new SMB3 kernel server Namjae Jeon [not found] ` <CGME20210823030841epcas1p1a811d4a6aec75c09581a9b0fb575d23e@epcas1p1.samsung.com> 2021-08-23 2:58 ` [PATCH v8 01/13] ksmbd: add document Namjae Jeon [not found] ` <CGME20210823030842epcas1p27cdeb782776f6659826110cd9a3524d4@epcas1p2.samsung.com> 2021-08-23 2:58 ` [PATCH v8 02/13] ksmbd: add server handler Namjae Jeon [not found] ` <CGME20210823030843epcas1p4502dad130066a74f08745c849b981112@epcas1p4.samsung.com> 2021-08-23 2:58 ` [PATCH v8 03/13] ksmbd: add tcp transport layer Namjae Jeon [not found] ` <CGME20210823030844epcas1p2a9dc2c02d32df86e9eb3c2af975c7d81@epcas1p2.samsung.com> 2021-08-23 2:58 ` [PATCH v8 04/13] ksmbd: add ipc " Namjae Jeon [not found] ` <CGME20210823030845epcas1p3ff50078868ed215c43898356c9248d24@epcas1p3.samsung.com> 2021-08-23 2:58 ` [PATCH v8 05/13] ksmbd: add rdma " Namjae Jeon [not found] ` <CGME20210823030845epcas1p2c72588cd470ca46463fd46b42b7b9603@epcas1p2.samsung.com> 2021-08-23 2:58 ` [PATCH v8 06/13] ksmbd: add a utility code that tracks (and caches) sessions data Namjae Jeon [not found] ` <CGME20210823030846epcas1p35bd3c665d8afd6205c617840e709afc7@epcas1p3.samsung.com> 2021-08-23 2:58 ` [PATCH v8 07/13] ksmbd: add authentication Namjae Jeon [not found] ` <CGME20210823030849epcas1p39035b8f9ec5cdc87dc7beca86590932c@epcas1p3.samsung.com> 2021-08-23 2:58 ` [PATCH v8 10/13] ksmbd: add oplock/lease cache mechanism Namjae Jeon [not found] ` <CGME20210823030850epcas1p1eea7803d1ca2e854a0199f4c83cd8190@epcas1p1.samsung.com> 2021-08-23 2:58 ` [PATCH v8 11/13] ksmbd: add file operations Namjae Jeon [not found] ` <CGME20210823030851epcas1p2d141386b64cd9039121a9f6a5074a362@epcas1p2.samsung.com> 2021-08-23 2:58 ` [PATCH v8 12/13] ksmbd: add Kconfig and Makefile Namjae Jeon [not found] ` <CGME20210823030851epcas1p3df6319948e331e2e0225adba4e81e660@epcas1p3.samsung.com> 2021-08-23 2:58 ` [PATCH v8 13/13] MAINTAINERS: add ksmbd kernel server Namjae Jeon 2021-08-23 15:13 ` [PATCH 00/11] ksmbd: various fixes Christian Brauner 2021-08-23 15:13 ` [PATCH 01/11] ksmbd: fix lookup on idmapped mounts Christian Brauner 2021-08-23 15:13 ` [PATCH 02/11] ksmbd: fix translation in smb2_populate_readdir_entry() Christian Brauner 2021-08-23 15:13 ` [PATCH 03/11] ksmbd: fix translation in create_posix_rsp_buf() Christian Brauner 2021-08-23 15:13 ` [PATCH 04/11] smb2pdu: fix translation in ksmbd_acls_fattr() Christian Brauner 2021-08-23 15:13 ` [PATCH 05/11] ksmbd: fix translation in acl entries Christian Brauner 2021-08-23 15:13 ` [PATCH 06/11] ksmbd: fix subauth 0 handling in sid_to_id() Christian Brauner 2021-08-24 8:13 ` Namjae Jeon [this message] 2021-08-24 11:37 ` Christian Brauner 2021-08-23 15:13 ` [PATCH 07/11] ksmbd: fix translation " Christian Brauner 2021-08-23 15:13 ` [PATCH 08/11] ndr: fix translation in ndr_encode_posix_acl() Christian Brauner 2021-08-23 15:13 ` [PATCH 09/11] ksmbd: ensure error is surfaced in set_file_basic_info() Christian Brauner 2021-08-23 15:13 ` [PATCH 10/11] ksmbd: remove setattr preparations " Christian Brauner 2021-09-01 12:47 ` Namjae Jeon 2021-09-02 13:43 ` Christian Brauner 2021-10-01 18:51 ` Marios Makassikis 2021-10-02 0:41 ` Namjae Jeon 2021-10-02 19:29 ` Marios Makassikis 2021-10-03 0:12 ` Namjae Jeon 2021-08-23 15:13 ` [PATCH 11/11] ksmbd: defer notify_change() call Christian Brauner 2021-08-24 8:20 ` Namjae Jeon 2021-08-24 11:36 ` Christian Brauner 2021-09-01 12:53 ` Namjae Jeon 2021-09-02 13:42 ` Christian Brauner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKYAXd86gaPoYJJHW6STdHhN282p5JFdr-xWwdvgv4HobFOBUg@mail.gmail.com \ --to=linkinjeon@kernel.org \ --cc=brauner@kernel.org \ --cc=christian.brauner@ubuntu.com \ --cc=hch@infradead.org \ --cc=hyc.lee@gmail.com \ --cc=linux-cifs@vger.kernel.org \ --cc=namjae.jeon@samsung.com \ --cc=senozhatsky@chromium.org \ --cc=stfrench@microsoft.com \ --subject='Re: [PATCH 06/11] ksmbd: fix subauth 0 handling in sid_to_id()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).