archive mirror
 help / color / mirror / Atom feed
From: Namjae Jeon <>
To: Colin King <>
Cc: Sergey Senozhatsky <>,
	Steve French <>,
	Hyunchul Lee <>,,,
Subject: Re: [PATCH][next] ksmbd: add missing assignments to ret on ndr_read_int64 read calls
Date: Tue, 7 Sep 2021 08:31:16 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

2021-09-06 22:44 GMT+09:00, Colin King <>:
> From: Colin Ian King <>
> Currently there are two ndr_read_int64 calls where ret is being checked
> for failure but ret is not being assigned a return value from the call.
> Static analyis is reporting the checks on ret as dead code.  Fix this.
> Addresses-Coverity: ("Logical dead code")
> Fixes: 303fff2b8c77 ("ksmbd: add validation for ndr read/write functions")
> Signed-off-by: Colin Ian King <>
Applied it to my queue. I will send it to Steve after testing.
Thanks for your patch!

  reply	other threads:[~2021-09-06 23:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 13:44 Colin King
2021-09-06 23:31 ` Namjae Jeon [this message]
2021-09-07  0:08 ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH][next] ksmbd: add missing assignments to ret on ndr_read_int64 read calls' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).