archive mirror
 help / color / mirror / Atom feed
From: Namjae Jeon <>
To: Colin King <>
Cc: Namjae Jeon <>,
	Sergey Senozhatsky <>,
	Steve French <>,
	Hyunchul Lee <>,,,
Subject: Re: [PATCH][next] ksmbd: Fix read on the uninitialized pointer sess
Date: Tue, 6 Jul 2021 21:43:58 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Colin,

2021-07-06 21:05 GMT+09:00, Colin King <>:
> From: Colin Ian King <>
> There is a error handling case that passes control to label out_err
> without pointer sess being assigned a value. The unassigned pointer
> may be any garbage value and so the test of rc < 0 && sess maybe
> true leading to sess being passed to the call to ksmbd_session_destroy.
> Fix this by setting sess to NULL in this corner case.
> Addresses-Coverity: ("Uninitialized pointer read")
> Fixes: f5a544e3bab7 ("ksmbd: add support for SMB3 multichannel")
> Signed-off-by: Colin Ian King <>
I will apply this patch. Thanks for your patch!

      reply	other threads:[~2021-07-06 12:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 12:05 Colin King
2021-07-06 12:43 ` Namjae Jeon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH][next] ksmbd: Fix read on the uninitialized pointer sess' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).