linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namjae Jeon <linkinjeon@kernel.org>
To: Ronnie Sahlberg <lsahlber@redhat.com>
Cc: linux-cifs <linux-cifs@vger.kernel.org>,
	Steve French <smfrench@gmail.com>
Subject: Re: [PATCH 4/4] ksmbd: Use the SMB3_Create definitions from the shared area
Date: Wed, 8 Sep 2021 16:51:20 +0900	[thread overview]
Message-ID: <CAKYAXd9SRaAPUEeyAFs+6SYBB25dYts=b+7VZrmzuySj+dDEVw@mail.gmail.com> (raw)
In-Reply-To: <20210907082523.2087981-4-lsahlber@redhat.com>

Hi Ronnie,
> @@ -2525,9 +2525,7 @@ int smb2_open(struct ksmbd_work *work)
>  		    req->CreateOptions & FILE_RANDOM_ACCESS_LE)
>  			req->CreateOptions = ~(FILE_SEQUENTIAL_ONLY_LE);
>
> -		if (req->CreateOptions &
> -		    (FILE_OPEN_BY_FILE_ID_LE | CREATE_TREE_CONNECTION |
> -		     FILE_RESERVE_OPFILTER_LE)) {
> +		if (req->CreateOptions & FILE_OPEN_BY_FILE_ID_LE) {
Is there any reason to remove CREATE_TREE_CONNECTION and
FILE_RESERVE_OPFILTER_LE check here ?
smb2.create.gentest failed by removing this check.

test: gentest
time: 2021-09-08 07:04:21.276746
time: 2021-09-08 07:04:21.413606
failure: gentest [
(../../source4/torture/smb2/create.c:222) Incorrect value for ok_mask
0x00ffcffe - should be 0x00efcf7e
]
The command "./bin/smbtorture //127.0.0.1/cifsd-test3/ -Utestuser%1234
smb2.create.gentest" exited with 1.


> @@ -3475,9 +3473,9 @@ static int smb2_populate_readdir_entry(struct
> ksmbd_conn *conn, int info_level,
>  		posix_info->Mode = cpu_to_le32(ksmbd_kstat->kstat->mode);
>  		posix_info->Inode = cpu_to_le64(ksmbd_kstat->kstat->ino);
>  		posix_info->DosAttributes =
> -			S_ISDIR(ksmbd_kstat->kstat->mode) ? ATTR_DIRECTORY_LE :
> ATTR_ARCHIVE_LE;
> +			S_ISDIR(ksmbd_kstat->kstat->mode) ? FILE_ATTRIBUTE_DIRECTORY_LE :
> FILE_ATTRIBUTE_ARCHIVE_LE;
checkpatch.pl error happen.

WARNING: line length of 116 exceeds 100 columns
#274: FILE: fs/ksmbd/smb2pdu.c:3476:
+			S_ISDIR(ksmbd_kstat->kstat->mode) ? FILE_ATTRIBUTE_DIRECTORY_LE :
FILE_ATTRIBUTE_ARCHIVE_LE;

I can directly update this patch, so no need to send v2 patch.

Thanks!

      reply	other threads:[~2021-09-08  7:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07  8:25 [PATCH 1/4] cifs: Move more definitions into " Ronnie Sahlberg
2021-09-07  8:25 ` [PATCH 2/4] ksmbd: " Ronnie Sahlberg
2021-09-07  8:25 ` [PATCH 3/4] cifs: Move SMB2_Create definitions to " Ronnie Sahlberg
2021-09-07  8:25 ` [PATCH 4/4] ksmbd: Use the SMB3_Create definitions from " Ronnie Sahlberg
2021-09-08  7:51   ` Namjae Jeon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKYAXd9SRaAPUEeyAFs+6SYBB25dYts=b+7VZrmzuySj+dDEVw@mail.gmail.com' \
    --to=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=lsahlber@redhat.com \
    --cc=smfrench@gmail.com \
    --subject='Re: [PATCH 4/4] ksmbd: Use the SMB3_Create definitions from the shared area' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).