From: Pavel Shilovsky <piastryyy@gmail.com>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: Steve French <smfrench@gmail.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH][CIFS] Add flock support
Date: Tue, 16 Jul 2019 18:05:53 -0700 [thread overview]
Message-ID: <CAKywueR-5osR4kGZ9irxhOs-UP6RhvzZd9qHNw7P5RdLU5qnYg@mail.gmail.com> (raw)
In-Reply-To: <CAN05THS4iCZdEruuLQRwvrMhdKrEL18-gN4CndtRPwxkuczz_Q@mail.gmail.com>
Looks good.
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
--
Best regards,
Pavel Shilovsky
вт, 16 июл. 2019 г. в 18:02, ronnie sahlberg <ronniesahlberg@gmail.com>:
>
> Nice.
>
> Reviewed-by me
>
> On Wed, Jul 17, 2019 at 10:51 AM Steve French <smfrench@gmail.com> wrote:
> >
> > Pavel spotted the problem - fixed and reattached updated patch
> >
> >
> > On Tue, Jul 16, 2019 at 7:02 PM Steve French <smfrench@gmail.com> wrote:
> > >
> > > The attached patch adds support for flock support similar to AFS, NFS etc.
> > >
> > > Although the patch did seem to work in my experiments with flock, I did notice
> > > that xfstest generic/504 fails because /proc/locks is not updated by cifs.ko
> > > after a successful lock. Any idea which helper function does that?
> > >
> > >
> > > --
> > > Thanks,
> > >
> > > Steve
> >
> >
> >
> > --
> > Thanks,
> >
> > Steve
next prev parent reply other threads:[~2019-07-17 1:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 0:02 [PATCH][CIFS] Add flock support Steve French
2019-07-17 0:49 ` Steve French
2019-07-17 1:02 ` ronnie sahlberg
2019-07-17 1:05 ` Pavel Shilovsky [this message]
2019-07-19 20:56 ` J. Bruce Fields
2019-07-19 21:30 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKywueR-5osR4kGZ9irxhOs-UP6RhvzZd9qHNw7P5RdLU5qnYg@mail.gmail.com \
--to=piastryyy@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).