From: Pavel Shilovsky <piastryyy@gmail.com>
To: "Aurélien Aptel" <aaptel@suse.com>
Cc: Paulo Alcantara <pc@cjr.nz>, linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] mount.cifs: fix crash when mount point does not exist
Date: Thu, 8 Jul 2021 16:14:13 -0700 [thread overview]
Message-ID: <CAKywueSU3UPaj2nOmQqMVkBJtrSqG5zO9BLyyQEECjqLMmrxpg@mail.gmail.com> (raw)
In-Reply-To: <87v97uu8nv.fsf@suse.com>
пт, 7 мая 2021 г. в 03:42, Aurélien Aptel <aaptel@suse.com>:
>
> Paulo Alcantara <pc@cjr.nz> writes:
> > @mountpointp is initially set to a statically allocated string in
> > main(), and if we fail to update it in acquire_mountpoint(), make sure
> > to set it to NULL and avoid freeing it at mount_exit.
> >
> > This fixes the following crash
> >
> > $ mount.cifs //srv/share /mnt/foo/bar -o ...
> > Couldn't chdir to /mnt/foo/bar: No such file or directory
> > munmap_chunk(): invalid pointer
> > Aborted
>
> LGTM
>
> Reviewed-by: Aurelien Aptel <aaptel@suse.com>
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
>
Merged. Thanks!
--
Best regards,
Pavel Shilovsky
prev parent reply other threads:[~2021-07-08 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 19:25 [PATCH] mount.cifs: fix crash when mount point does not exist Paulo Alcantara
2021-05-07 10:42 ` Aurélien Aptel
2021-07-08 23:14 ` Pavel Shilovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKywueSU3UPaj2nOmQqMVkBJtrSqG5zO9BLyyQEECjqLMmrxpg@mail.gmail.com \
--to=piastryyy@gmail.com \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@cjr.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).