From: Pavel Shilovsky <piastryyy@gmail.com>
To: Paulo Alcantara <pc@cjr.nz>
Cc: linux-cifs <linux-cifs@vger.kernel.org>,
"Steve French" <smfrench@gmail.com>,
"Aurélien Aptel" <aaptel@suse.com>,
"Duncan Findlay" <duncf@duncf.ca>,
"Pavel Shilovsky" <pshilov@microsoft.com>,
Stable <stable@vger.kernel.org>
Subject: Re: [PATCH] cifs: fix interrupted close commands
Date: Wed, 13 Jan 2021 10:28:55 -0800 [thread overview]
Message-ID: <CAKywueSoG8zCqmVgaOtvG5AM4fi47+bFJ3VdHPAa=sJa+v2duA@mail.gmail.com> (raw)
In-Reply-To: <20210113171616.11730-1-pc@cjr.nz>
ср, 13 янв. 2021 г. в 09:16, Paulo Alcantara <pc@cjr.nz>:
>
> Retry close command if it gets interrupted to not leak open handles on
> the server.
>
> Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
> Reported-by: Duncan Findlay <duncf@duncf.ca>
> Suggested-by: Pavel Shilovsky <pshilov@microsoft.com>
> Fixes: 6988a619f5b7 ("cifs: allow syscalls to be restarted in __smb_send_rqst()")
> Cc: stable@vger.kernel.org
> ---
> fs/cifs/smb2pdu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
> index 067eb44c7baa..794fc3b68b4f 100644
> --- a/fs/cifs/smb2pdu.c
> +++ b/fs/cifs/smb2pdu.c
> @@ -3248,7 +3248,7 @@ __SMB2_close(const unsigned int xid, struct cifs_tcon *tcon,
> free_rsp_buf(resp_buftype, rsp);
>
> /* retry close in a worker thread if this one is interrupted */
> - if (rc == -EINTR) {
> + if (is_interrupt_error(rc)) {
> int tmp_rc;
>
> tmp_rc = smb2_handle_cancelled_close(tcon, persistent_fid,
> --
> 2.29.2
>
Thanks for the fix!
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
--
Best regards,
Pavel Shilovsky
next prev parent reply other threads:[~2021-01-13 18:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 7:21 [bug report] Inconsistent state with CIFS mount after interrupted process in Linux 5.10 Duncan Findlay
2021-01-13 12:29 ` Aurélien Aptel
2021-01-13 16:31 ` Pavel Shilovsky
2021-01-13 16:51 ` Paulo Alcantara
2021-01-13 17:02 ` Steve French
2021-01-13 17:16 ` [PATCH] cifs: fix interrupted close commands Paulo Alcantara
2021-01-13 18:28 ` Pavel Shilovsky [this message]
2021-01-14 7:32 ` Shyam Prasad N
2021-01-14 17:22 ` [EXTERNAL] " Pavel Shilovskiy
2021-01-13 18:35 ` [bug report] Inconsistent state with CIFS mount after interrupted process in Linux 5.10 Pavel Shilovsky
2021-01-14 15:21 ` Aurélien Aptel
2021-01-14 17:10 ` Pavel Shilovsky
2021-01-13 16:57 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKywueSoG8zCqmVgaOtvG5AM4fi47+bFJ3VdHPAa=sJa+v2duA@mail.gmail.com' \
--to=piastryyy@gmail.com \
--cc=aaptel@suse.com \
--cc=duncf@duncf.ca \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@cjr.nz \
--cc=pshilov@microsoft.com \
--cc=smfrench@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).