linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Shilovsky <piastryyy@gmail.com>
To: "Aurélien Aptel" <aaptel@suse.com>
Cc: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] smb3: fix unmount hang in open_shroot
Date: Fri, 13 Sep 2019 09:35:25 -0700	[thread overview]
Message-ID: <CAKywueSsNF+j+s0=+_UbsESTaz-K1Oj48LNK3SvBvXQTZE-PXQ@mail.gmail.com> (raw)
In-Reply-To: <8736h0i7p4.fsf@suse.com>

Agree. Both SMB2_open_init and SMB2_query_info_init should exit
through oshr_free to avoid double unlock.
--
Best regards,
Pavel Shilovsky

пт, 13 сент. 2019 г. в 07:36, Aurélien Aptel <aaptel@suse.com>:
>
> Aurélien Aptel  <aaptel@suse.com> writes:
> > Good catch. Since the compounding changes it is SMB2_open_init() that is
> > triggering the reconnect -> mark_open_files_invalid() code path so it
> > looks good to me. Might be worth updating the comment to
> > s/SMB2_open/SMB2_open_init/ before you commit.
>
> Ah it seems you also need to make SMB2_open_init exit via the oshr_free
> label otherwise you the mutex gets unlocked twice (see Dan Carpenter
> automatic test email). This smatch tool is pretty nice...
>
> Cheers
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

      reply	other threads:[~2019-09-13 16:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 23:10 [PATCH] smb3: fix unmount hang in open_shroot Steve French
2019-09-13 11:34 ` Aurélien Aptel
2019-09-13 14:36   ` Aurélien Aptel
2019-09-13 16:35     ` Pavel Shilovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKywueSsNF+j+s0=+_UbsESTaz-K1Oj48LNK3SvBvXQTZE-PXQ@mail.gmail.com' \
    --to=piastryyy@gmail.com \
    --cc=aaptel@suse.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).