Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
From: ronnie sahlberg <ronniesahlberg@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [RFC][SMB3][PATCH] Allow share to be mounted with "cache=ro" if immutable share
Date: Wed, 28 Aug 2019 16:11:33 +1000
Message-ID: <CAN05THRQrrXKYzbF4_mRrDF+77KMV=EvLodKFjhMUpCpB5uKyg@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mu_koRUCV9snYu_A6at8r+kJ85DgFszG4=seEEn+qb0LQ@mail.gmail.com>

On Wed, Aug 28, 2019 at 3:04 PM Steve French <smfrench@gmail.com> wrote:
>
> Increases performance a lot in cases where we know that the share is
> not changing

Good idea but we can do it without adding a new mount option.
Instead of "cache=ro" I think we should look at the WRITE bit in the
tree connect response access mask since this should tell us if the share is
read-only server-side or not.

If the share is thus read-only we should then have that reflected in the
"ro" mount option.

I.e.
* use TreeConnect/AccessMaks/WRITE flag to enable this more aggressive caching
and not a mount option.
* Probably also fail the mount if the WRITE flag is clear and the user
did not specify "ro"
as a mount option.

ronnie

>
>
>
> --
> Thanks,
>
> Steve

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  5:02 Steve French
2019-08-28  6:11 ` ronnie sahlberg [this message]
2019-08-28 10:20 ` Aurélien Aptel
2019-08-28 10:27   ` ronnie sahlberg
2019-08-28 10:54     ` Aurélien Aptel
2019-08-28 22:17     ` Steve French

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN05THRQrrXKYzbF4_mRrDF+77KMV=EvLodKFjhMUpCpB5uKyg@mail.gmail.com' \
    --to=ronniesahlberg@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org linux-cifs@archiver.kernel.org
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox