From: ronnie sahlberg <ronniesahlberg@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: Ronnie Sahlberg <lsahlber@redhat.com>,
linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH 2/2] cifs: fix incorrect error return in build_unc_path_to_root
Date: Tue, 27 Aug 2019 12:20:40 +1000 [thread overview]
Message-ID: <CAN05THRiEV0=zY5Q04CV7-gUQHs5NYyO4t7N_zQZbwdpcSZi8g@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mvSjf1vXnoan1vasH=CoOLjQ7se-M5_HaULC=rZSFWFvA@mail.gmail.com>
On Tue, Aug 27, 2019 at 12:15 PM Steve French <smfrench@gmail.com> wrote:
>
> Do you have a simple repro for this one that would lead us to want to cc:stable
I don't have a reproducer.
>
> On Mon, Aug 26, 2019 at 8:36 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
> >
> > Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> > ---
> > fs/cifs/connect.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> > index 1ed449f4a8ec..c5dc8265b671 100644
> > --- a/fs/cifs/connect.c
> > +++ b/fs/cifs/connect.c
> > @@ -4232,7 +4232,7 @@ build_unc_path_to_root(const struct smb_vol *vol,
> > unsigned int unc_len = strnlen(vol->UNC, MAX_TREE_SIZE + 1);
> >
> > if (unc_len > MAX_TREE_SIZE)
> > - return -EINVAL;
> > + return ERR_PTR(-EINVAL);
> >
> > full_path = kmalloc(unc_len + pplen + 1, GFP_KERNEL);
> > if (full_path == NULL)
> > --
> > 2.13.6
> >
>
>
> --
> Thanks,
>
> Steve
next prev parent reply other threads:[~2019-08-27 2:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 1:35 [PATCH 1/2] cifs: create a helper to find a writeable handle py path name Ronnie Sahlberg
2019-08-27 1:35 ` [PATCH 2/2] cifs: fix incorrect error return in build_unc_path_to_root Ronnie Sahlberg
2019-08-27 2:14 ` Steve French
2019-08-27 2:20 ` ronnie sahlberg [this message]
2019-08-27 23:00 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN05THRiEV0=zY5Q04CV7-gUQHs5NYyO4t7N_zQZbwdpcSZi8g@mail.gmail.com' \
--to=ronniesahlberg@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).