From: ronnie sahlberg <ronniesahlberg@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: Ronnie Sahlberg <lsahlber@redhat.com>,
linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: add support for fallocate mode 0 for non-sparse files
Date: Wed, 15 Jan 2020 12:25:11 +1000 [thread overview]
Message-ID: <CAN05THSBKBw3Az8UUW8fuV_K9_e9is+po1Q05m8mbcd5Rv_uUw@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mst8zDCachJMZC-BgtJs2M7c1F+1VCf-Hfe68Qz0vQ8aQ@mail.gmail.com>
On Wed, Jan 15, 2020 at 11:25 AM Steve French <smfrench@gmail.com> wrote:
>
> Does it affect (or enable) any xfstests?
It shouldn't affect any current tests.
It adds support for
xfs_io -c "falloc 0 512M" <file>
generic/071 now passes with this patch. Possibly other tests as well
that use "xfs_io -c falloc" as well
>
> On Tue, Jan 14, 2020 at 7:23 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
> >
> > RHBZ 1336264
> >
> > Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> > ---
> > fs/cifs/smb2ops.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> > index 6250370c1170..91818f7c1b9c 100644
> > --- a/fs/cifs/smb2ops.c
> > +++ b/fs/cifs/smb2ops.c
> > @@ -3106,9 +3106,13 @@ static long smb3_simple_falloc(struct file *file, struct cifs_tcon *tcon,
> > else if (i_size_read(inode) >= off + len)
> > /* not extending file and already not sparse */
> > rc = 0;
> > - /* BB: in future add else clause to extend file */
> > - else
> > - rc = -EOPNOTSUPP;
> > + /* extend file */
> > + else {
> > + eof = cpu_to_le64(off + len);
> > + rc = SMB2_set_eof(xid, tcon, cfile->fid.persistent_fid,
> > + cfile->fid.volatile_fid, cfile->pid,
> > + &eof);
> > + }
> > if (rc)
> > trace_smb3_falloc_err(xid, cfile->fid.persistent_fid,
> > tcon->tid, tcon->ses->Suid, off, len, rc);
> > --
> > 2.13.6
> >
>
>
> --
> Thanks,
>
> Steve
next prev parent reply other threads:[~2020-01-15 2:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 1:23 [PATCH 0/1] add support for fallocate mode 0 Ronnie Sahlberg
2020-01-15 1:23 ` [PATCH] cifs: add support for fallocate mode 0 for non-sparse files Ronnie Sahlberg
2020-01-15 1:25 ` Steve French
2020-01-15 2:25 ` ronnie sahlberg [this message]
2020-01-15 20:14 ` Steve French
2020-01-16 2:03 ` Steve French
2020-01-16 8:42 ` ronnie sahlberg
2020-01-17 0:27 ` Pavel Shilovsky
2020-01-17 0:56 ` ronnie sahlberg
2020-01-17 0:04 Ronnie Sahlberg
2020-01-17 1:15 Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN05THSBKBw3Az8UUW8fuV_K9_e9is+po1Q05m8mbcd5Rv_uUw@mail.gmail.com \
--to=ronniesahlberg@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).