From: ronnie sahlberg <ronniesahlberg@gmail.com>
To: Pavel Shilovsky <piastryyy@gmail.com>
Cc: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] smb3: fix refcount underflow warning on unmount when no directory leases
Date: Fri, 13 Dec 2019 05:36:47 +1000 [thread overview]
Message-ID: <CAN05THSZXrOvZtwYWgejMGKbxrGePNdFSPV5+hUkX8yHySee8Q@mail.gmail.com> (raw)
In-Reply-To: <CAKywueQSgGgPB+tQz28_VCe1LiyxpY7tU9tByypkTJALdHOOWg@mail.gmail.com>
This makes sense. Thanks for this patch.
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
On Wed, Dec 11, 2019 at 5:53 AM Pavel Shilovsky <piastryyy@gmail.com> wrote:
>
> пн, 9 дек. 2019 г. в 20:48, Steve French <smfrench@gmail.com>:
> >
> > Fix refcount underflow warning when unmounting to servers which didn't grant
> > directory leases.
> >
> > [ 301.680095] refcount_t: underflow; use-after-free.
> > [ 301.680192] WARNING: CPU: 1 PID: 3569 at lib/refcount.c:28
> > refcount_warn_saturate+0xb4/0xf3
> > ...
> > [ 301.682139] Call Trace:
> > [ 301.682240] close_shroot+0x97/0xda [cifs]
> > [ 301.682351] SMB2_tdis+0x7c/0x176 [cifs]
> > [ 301.682456] ? _get_xid+0x58/0x91 [cifs]
> > [ 301.682563] cifs_put_tcon.part.0+0x99/0x202 [cifs]
> > [ 301.682637] ? ida_free+0x99/0x10a
> > [ 301.682727] ? cifs_umount+0x3d/0x9d [cifs]
> > [ 301.682829] cifs_put_tlink+0x3a/0x50 [cifs]
> > [ 301.682929] cifs_umount+0x44/0x9d [cifs]
> >
> > Fixes: 72e73c78c446 ("cifs: close the shared root handle on tree disconnect")
> >
> > Signed-off-by: Steve French <stfrench@microsoft.com>
> > Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
> > Reviewed-by: Aurelien Aptel <aaptel@suse.com>
> > Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
> > Reported-and-tested-by: Arthur Marsh <arthur.marsh@internode.on.net>
> >
> > --
> > Thanks,
> >
> > Steve
>
> Looking at this more, I think that the fact that the handle is valid
> doesn't mean that it has a directory lease. So, I think we need to
> track that fact separately. I coded a quick follow-on fix (untested)
> to describe my idea - see the attached patch.
>
> Thoughts?
>
> --
> Best regards,
> Pavel Shilovsky
next prev parent reply other threads:[~2019-12-12 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 4:48 [PATCH] smb3: fix refcount underflow warning on unmount when no directory leases Steve French
2019-12-10 19:53 ` Pavel Shilovsky
2019-12-12 19:36 ` ronnie sahlberg [this message]
2019-12-12 23:08 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN05THSZXrOvZtwYWgejMGKbxrGePNdFSPV5+hUkX8yHySee8Q@mail.gmail.com \
--to=ronniesahlberg@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=piastryyy@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).