linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ronnie sahlberg <ronniesahlberg@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH][SMB3] Allow skipping signing verification for perf sensitive use cases
Date: Wed, 4 Sep 2019 13:35:20 +1000	[thread overview]
Message-ID: <CAN05THSdkvUZc1E=n46K_12BXEv6uifNk3hMEML6nrEmyx-ryA@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mv9UTz8CPWz1B3Rk-NdCziX-JmBieNypF9vgoV9T=Bwow@mail.gmail.com>

reviewed-by me

On Wed, Sep 4, 2019 at 12:59 PM Steve French <smfrench@gmail.com> wrote:
>
> Updated patch
>
>
> On Tue, Sep 3, 2019 at 9:53 PM Steve French <smfrench@gmail.com> wrote:
> >
> > Ok. Will fix the bool. I don't think it belongs in mount mask since it is a server not superblock parm
> >
> > On Tue, Sep 3, 2019, 21:37 ronnie sahlberg <ronniesahlberg@gmail.com> wrote:
> >>
> >> Change
> >> bool ignore_signature;
> >> to
> >> bool ignore_signature:1;
> >>
> >> And shouldn't this be part of CIFS_MOUNT_MASK too ?
> >>
> >>
> >> On Wed, Sep 4, 2019 at 12:25 PM Steve French <smfrench@gmail.com> wrote:
> >> >
> >> > Add new mount option "signloosely" which enables signing but skips the
> >> > sometimes expensive signing checks in the responses (signatures are
> >> > calculated and sent correctly in the SMB2/SMB3 requests even with this
> >> > mount option but skipped in the responses).  Although weaker for security
> >> > (and also data integrity in case a packet were corrupted), this can provide
> >> > enough of a performance benefit (calculating the signature to verify a
> >> > packet can be expensive especially for large packets) to be useful in
> >> > some cases.
> >> >
> >> >
> >> > --
> >> > Thanks,
> >> >
> >> > Steve
>
>
>
> --
> Thanks,
>
> Steve

      reply	other threads:[~2019-09-04  3:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04  2:24 [PATCH][SMB3] Allow skipping signing verification for perf sensitive use cases Steve French
2019-09-04  2:37 ` ronnie sahlberg
     [not found]   ` <CAH2r5msuaE_nuEBzxN0LLpriQzv8fYuBkZDUMo09eFqzyfUf9w@mail.gmail.com>
2019-09-04  2:58     ` Steve French
2019-09-04  3:35       ` ronnie sahlberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN05THSdkvUZc1E=n46K_12BXEv6uifNk3hMEML6nrEmyx-ryA@mail.gmail.com' \
    --to=ronniesahlberg@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).